| Message ID | 20241024022700.1236660-1-min_halo@163.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e7cd4b811c9e019f5acbce85699c622b30194c24 |
| Headers | show |
| Series | [v2] usbip: tools: Fix detach_port() invalid port error path | expand |
On 10/23/24 20:27, Zongmin Zhou wrote: > From: Zongmin Zhou <zhouzongmin@kylinos.cn> > > The detach_port() doesn't return error > when detach is attempted on an invalid port. > > Fixes: 40ecdeb1a187 ("usbip: usbip_detach: fix to check for invalid ports") > Cc: stable@vger.kernel.org > Reviewed-by: Hongren Zheng <i@zenithal.me> > Reviewed-by: Shuah Khan <skhan@linuxfoundation.org> > Signed-off-by: Zongmin Zhou <zhouzongmin@kylinos.cn> > --- > tools/usb/usbip/src/usbip_detach.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/usb/usbip/src/usbip_detach.c b/tools/usb/usbip/src/usbip_detach.c > index b29101986b5a..6b78d4a81e95 100644 > --- a/tools/usb/usbip/src/usbip_detach.c > +++ b/tools/usb/usbip/src/usbip_detach.c > @@ -68,6 +68,7 @@ static int detach_port(char *port) > } > > if (!found) { > + ret = -1; > err("Invalid port %s > maxports %d", > port, vhci_driver->nports); > goto call_driver_close; Thank you. Greg, Please pick this up. thanks, -- Shuah
diff --git a/tools/usb/usbip/src/usbip_detach.c b/tools/usb/usbip/src/usbip_detach.c index b29101986b5a..6b78d4a81e95 100644 --- a/tools/usb/usbip/src/usbip_detach.c +++ b/tools/usb/usbip/src/usbip_detach.c @@ -68,6 +68,7 @@ static int detach_port(char *port) } if (!found) { + ret = -1; err("Invalid port %s > maxports %d", port, vhci_driver->nports); goto call_driver_close;