| Message ID | 20241028080415.697793-1-wojackbb@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | USB: serial: option: add MediaTek T7XX compositions | expand |
On Mon, Oct 28, 2024 at 04:04:15PM +0800, wojackbb@gmail.com wrote: > From: Jack Wu <wojackbb@gmail.com> > > Add the MediaTek T7XX compositions: Can you say something about what the various interfaces are used for here? > T: Bus=03 Lev=01 Prnt=01 Port=05 Cnt=01 Dev#= 74 Spd=480 MxCh= 0 > D: Ver= 2.10 Cls=ef(misc ) Sub=02 Prot=01 MxPS=64 #Cfgs= 1 > P: Vendor=0e8d ProdID=7129 Rev= 0.01 > S: Manufacturer=MediaTek Inc. > S: Product=USB DATA CARD > S: SerialNumber=004402459035402 > C:* #Ifs=10 Cfg#= 1 Atr=a0 MxPwr=500mA > Signed-off-by: Jack Wu <wojackbb@gmail.com> > --- > drivers/usb/serial/option.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c > index 4f18f189f309..b6118f545386 100644 > --- a/drivers/usb/serial/option.c > +++ b/drivers/usb/serial/option.c > @@ -2244,6 +2244,7 @@ static const struct usb_device_id option_ids[] = { > .driver_info = NCTRL(2) }, > { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x7127, 0xff, 0x00, 0x00), > .driver_info = NCTRL(2) | NCTRL(3) | NCTRL(4) }, > + { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x7129, 0xff, 0x00, 0x00) }, /* MediaTek T7XX */ Should you mark some of the interfaces are not accepting modem control requests similar to 0x7126 and 0x7127? > { USB_DEVICE(CELLIENT_VENDOR_ID, CELLIENT_PRODUCT_MEN200) }, > { USB_DEVICE(CELLIENT_VENDOR_ID, CELLIENT_PRODUCT_MPL200), > .driver_info = RSVD(1) | RSVD(4) }, Johan
I:* If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option E: Ad=83(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms E: Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms It is USB AP Log Port. I:* If#= 3 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option E: Ad=84(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms E: Ad=03(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms It is USB AP GNSS Port. I:* If#= 4 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option E: Ad=85(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms E: Ad=04(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms It is USB AP META Port. I:* If#= 5 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=42 Prot=01 Driver=(none) E: Ad=86(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms E: Ad=05(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms It is ADB port. I:* If#= 6 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option E: Ad=87(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms E: Ad=06(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms It is USB MD AT Port. User can use the port send AT command. I:* If#= 7 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option E: Ad=88(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms E: Ad=07(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms It is USB MD META Port. I:* If#= 8 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option E: Ad=89(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms E: Ad=08(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms It is USB NTZ Port. User can use the port send MIPC command. MIPC is an instruction set designed by MTK, similar to QCT's QMI I:* If#= 9 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option E: Ad=8a(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms E: Ad=09(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms It is USB Debug port. Sorry, I don't understand "not accepting modem control". Should I set the non-MD ports to true? for example: USB AP Log Port. Johan Hovold <johan@kernel.org> 於 2024年10月29日 週二 下午8:11寫道： > > On Mon, Oct 28, 2024 at 04:04:15PM +0800, wojackbb@gmail.com wrote: > > From: Jack Wu <wojackbb@gmail.com> > > > > Add the MediaTek T7XX compositions: > > Can you say something about what the various interfaces are used for > here? > > > T: Bus=03 Lev=01 Prnt=01 Port=05 Cnt=01 Dev#= 74 Spd=480 MxCh= 0 > > D: Ver= 2.10 Cls=ef(misc ) Sub=02 Prot=01 MxPS=64 #Cfgs= 1 > > P: Vendor=0e8d ProdID=7129 Rev= 0.01 > > S: Manufacturer=MediaTek Inc. > > S: Product=USB DATA CARD > > S: SerialNumber=004402459035402 > > C:* #Ifs=10 Cfg#= 1 Atr=a0 MxPwr=500mA > > > Signed-off-by: Jack Wu <wojackbb@gmail.com> > > --- > > drivers/usb/serial/option.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c > > index 4f18f189f309..b6118f545386 100644 > > --- a/drivers/usb/serial/option.c > > +++ b/drivers/usb/serial/option.c > > @@ -2244,6 +2244,7 @@ static const struct usb_device_id option_ids[] = { > > .driver_info = NCTRL(2) }, > > { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x7127, 0xff, 0x00, 0x00), > > .driver_info = NCTRL(2) | NCTRL(3) | NCTRL(4) }, > > + { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x7129, 0xff, 0x00, 0x00) }, /* MediaTek T7XX */ > > Should you mark some of the interfaces are not accepting modem control > requests similar to 0x7126 and 0x7127? > > > { USB_DEVICE(CELLIENT_VENDOR_ID, CELLIENT_PRODUCT_MEN200) }, > > { USB_DEVICE(CELLIENT_VENDOR_ID, CELLIENT_PRODUCT_MPL200), > > .driver_info = RSVD(1) | RSVD(4) }, > > Johan
[ Please avoid top-posting. ] On Wed, Nov 06, 2024 at 07:09:22PM +0800, 吳逼逼 wrote: > I:* If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option > E: Ad=83(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > It is USB AP Log Port. > > I:* If#= 3 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option > E: Ad=84(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=03(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > It is USB AP GNSS Port. > > I:* If#= 4 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option > E: Ad=85(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=04(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > It is USB AP META Port. > > I:* If#= 5 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=42 Prot=01 Driver=(none) > E: Ad=86(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=05(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > It is ADB port. > > I:* If#= 6 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option > E: Ad=87(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=06(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > It is USB MD AT Port. User can use the port send AT command. > > I:* If#= 7 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option > E: Ad=88(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=07(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > It is USB MD META Port. > > I:* If#= 8 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option > E: Ad=89(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=08(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > It is USB NTZ Port. User can use the port send MIPC command. > MIPC is an instruction set designed by MTK, similar to QCT's QMI > > I:* If#= 9 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option > E: Ad=8a(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=09(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > It is USB Debug port. Thanks for this. Please include this in some form in the commit message (e.g. a table listing the functions). > Sorry, I don't understand "not accepting modem control". > Should I set the non-MD ports to true? > for example: USB AP Log Port. I meant that you should mark the interfaces that reject modem-control requests using the NCTRL() macro similar to what was done for the device with PID 0x7127. Johan
1. I will upload a new change and it will contain this description 2. Regarding NCTRL(), MTK tells us that it is the same as PID 0x7127 Johan Hovold <johan@kernel.org> 於 2024年11月6日 週三 下午10:07寫道： > > [ Please avoid top-posting. ] > > On Wed, Nov 06, 2024 at 07:09:22PM +0800, 吳逼逼 wrote: > > I:* If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option > > E: Ad=83(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > > E: Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > > It is USB AP Log Port. > > > > I:* If#= 3 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option > > E: Ad=84(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > > E: Ad=03(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > > It is USB AP GNSS Port. > > > > I:* If#= 4 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option > > E: Ad=85(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > > E: Ad=04(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > > It is USB AP META Port. > > > > I:* If#= 5 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=42 Prot=01 Driver=(none) > > E: Ad=86(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > > E: Ad=05(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > > It is ADB port. > > > > I:* If#= 6 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option > > E: Ad=87(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > > E: Ad=06(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > > It is USB MD AT Port. User can use the port send AT command. > > > > I:* If#= 7 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option > > E: Ad=88(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > > E: Ad=07(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > > It is USB MD META Port. > > > > I:* If#= 8 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option > > E: Ad=89(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > > E: Ad=08(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > > It is USB NTZ Port. User can use the port send MIPC command. > > MIPC is an instruction set designed by MTK, similar to QCT's QMI > > > > I:* If#= 9 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option > > E: Ad=8a(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > > E: Ad=09(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > > It is USB Debug port. > > Thanks for this. Please include this in some form in the commit message > (e.g. a table listing the functions). > > > Sorry, I don't understand "not accepting modem control". > > Should I set the non-MD ports to true? > > for example: USB AP Log Port. > > I meant that you should mark the interfaces that reject modem-control > requests using the NCTRL() macro similar to what was done for the device > with PID 0x7127. > > Johan
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index 4f18f189f309..b6118f545386 100644 --- a/drivers/usb/serial/option.c +++ b/drivers/usb/serial/option.c @@ -2244,6 +2244,7 @@ static const struct usb_device_id option_ids[] = { .driver_info = NCTRL(2) }, { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x7127, 0xff, 0x00, 0x00), .driver_info = NCTRL(2) | NCTRL(3) | NCTRL(4) }, + { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x7129, 0xff, 0x00, 0x00) }, /* MediaTek T7XX */ { USB_DEVICE(CELLIENT_VENDOR_ID, CELLIENT_PRODUCT_MEN200) }, { USB_DEVICE(CELLIENT_VENDOR_ID, CELLIENT_PRODUCT_MPL200), .driver_info = RSVD(1) | RSVD(4) },