| Message ID | 20241103034402.2460252-3-amitsd@google.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 3b9d67e7e9237cb91f4830456e45f7e213ce42c3 |
| Headers | show |
| Series | Add new time property for battery charger type detection | expand |
On Sat, 02 Nov 2024 20:43:29 -0700, Amit Sunil Dhamne wrote: > Add usage of "sink-bc12-completion-time-ms" connector property to > max33359 controller for delaying PD negotiation till BC1.2 detection > completes. This overcomes the occasional delays observed while > receiving PD messages where BC1.2 detection runs in parallel. > > Signed-off-by: Amit Sunil Dhamne <amitsd@google.com> > Reviewed-by: Badhri Jagan Sridharan <badhri@google.com> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > Documentation/devicetree/bindings/usb/maxim,max33359.yaml | 1 + > 1 file changed, 1 insertion(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/maxim,max33359.example.dtb: maxtcpc@25: connector: Unevaluated properties are not allowed ('sink-bc12-completion-time-ms' was unexpected) from schema $id: http://devicetree.org/schemas/usb/maxim,max33359.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/maxim,max33359.example.dtb: connector: Unevaluated properties are not allowed ('sink-bc12-completion-time-ms' was unexpected) from schema $id: http://devicetree.org/schemas/connector/usb-connector.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241103034402.2460252-3-amitsd@google.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Sun, Nov 03, 2024 at 12:22:50AM -0500, Rob Herring (Arm) wrote: > > On Sat, 02 Nov 2024 20:43:29 -0700, Amit Sunil Dhamne wrote: > > Add usage of "sink-bc12-completion-time-ms" connector property to > > max33359 controller for delaying PD negotiation till BC1.2 detection > > completes. This overcomes the occasional delays observed while > > receiving PD messages where BC1.2 detection runs in parallel. > > > > Signed-off-by: Amit Sunil Dhamne <amitsd@google.com> > > Reviewed-by: Badhri Jagan Sridharan <badhri@google.com> > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > Documentation/devicetree/bindings/usb/maxim,max33359.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/maxim,max33359.example.dtb: maxtcpc@25: connector: Unevaluated properties are not allowed ('sink-bc12-completion-time-ms' was unexpected) > from schema $id: http://devicetree.org/schemas/usb/maxim,max33359.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/maxim,max33359.example.dtb: connector: Unevaluated properties are not allowed ('sink-bc12-completion-time-ms' was unexpected) > from schema $id: http://devicetree.org/schemas/connector/usb-connector.yaml# This can be ignored as patch 1 couldn't be applied. Rob
diff --git a/Documentation/devicetree/bindings/usb/maxim,max33359.yaml b/Documentation/devicetree/bindings/usb/maxim,max33359.yaml index 276bf7554215..20b62228371b 100644 --- a/Documentation/devicetree/bindings/usb/maxim,max33359.yaml +++ b/Documentation/devicetree/bindings/usb/maxim,max33359.yaml @@ -69,6 +69,7 @@ examples: PDO_FIXED_DATA_SWAP | PDO_FIXED_DUAL_ROLE) PDO_FIXED(9000, 2000, 0)>; + sink-bc12-completion-time-ms = <500>; }; }; };