| Message ID | 20241107113534.402265-1-chenqiuji666@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 8b524944f92ccad925b574f645e9c2709cf60d1e |
| Headers | show |
| Series | [v2] USB: serial: ftdi_sio: Fix atomicity violation in get_serial_info() | expand |
On Thu, Nov 07, 2024 at 07:35:34PM +0800, Qiu-ji Chen wrote: > Our static checker found a bug where set_serial_info() uses a mutex, but > get_serial_info() does not. Fortunately, the impact of this is relatively > minor. It doesn't cause a crash or any other serious issues. However, if a > race condition occurs between set_serial_info() and get_serial_info(), > there is a chance that the data returned by get_serial_info() will be > inconsistent. > > Signed-off-by: Qiu-ji Chen <chenqiuji666@gmail.com> > Fixes: 3ae36bed3a93 ("fdti_sio: switch to ->[sg]et_serial()") > --- > Similar issues have been submitted or confirmed: > https://lore.kernel.org/all/20241002125845.785464707@linuxfoundation.org/ > https://lore.kernel.org/all/20241106095819.15194-1-chenqiuji666@gmail.com/ > --- > V2: > Revised the description, placed the reference link below "---". > Used the correct patch prefix. > Thanks Johan Hovold for helpful suggestion. Applied for -next, thanks. Johan
diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c index c6f17d732b95..e07c5e3eb18c 100644 --- a/drivers/usb/serial/ftdi_sio.c +++ b/drivers/usb/serial/ftdi_sio.c @@ -1443,9 +1443,11 @@ static void get_serial_info(struct tty_struct *tty, struct serial_struct *ss) struct usb_serial_port *port = tty->driver_data; struct ftdi_private *priv = usb_get_serial_port_data(port); + mutex_lock(&priv->cfg_lock); ss->flags = priv->flags; ss->baud_base = priv->baud_base; ss->custom_divisor = priv->custom_divisor; + mutex_unlock(&priv->cfg_lock); } static int set_serial_info(struct tty_struct *tty, struct serial_struct *ss)
Our static checker found a bug where set_serial_info() uses a mutex, but get_serial_info() does not. Fortunately, the impact of this is relatively minor. It doesn't cause a crash or any other serious issues. However, if a race condition occurs between set_serial_info() and get_serial_info(), there is a chance that the data returned by get_serial_info() will be inconsistent. Signed-off-by: Qiu-ji Chen <chenqiuji666@gmail.com> Fixes: 3ae36bed3a93 ("fdti_sio: switch to ->[sg]et_serial()") --- Similar issues have been submitted or confirmed: https://lore.kernel.org/all/20241002125845.785464707@linuxfoundation.org/ https://lore.kernel.org/all/20241106095819.15194-1-chenqiuji666@gmail.com/ --- V2: Revised the description, placed the reference link below "---". Used the correct patch prefix. Thanks Johan Hovold for helpful suggestion. --- drivers/usb/serial/ftdi_sio.c | 2 ++ 1 file changed, 2 insertions(+)