| Message ID | 20241120051328.7613-1-amilsananak@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | add a device in uvc_driver | expand |
Hi amilsananak,
add the necessary information in the commit message.
Look at this example, which is also adding support for a webcam
commit 53c264544dfce30f7741a2b1e78f90d046e5d8ff
media: uvcvideo: Add support for Apple T2-attached FaceTime HD Camera
Adds the requisite device id to support detection of the Apple FaceTime
HD webcam exposed over the T2 BCE VHCI interface.
look at the git log to see more examples
$ git log drivers/media/usb/uvc/uvc_driver.c
On Wed, Nov 20, 2024 at 10:43:27AM +0530, amilsananak wrote:
> From: amilsanan <amilsananak@gmail.com>
>
> Signed-off-by: amilsanan <amilsananak@gmail.com>
> ---
> drivers/media/usb/uvc/uvc_driver.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
> index f0febdc08..1a3229ab6 100644
> --- a/drivers/media/usb/uvc/uvc_driver.c
> +++ b/drivers/media/usb/uvc/uvc_driver.c
> @@ -2441,6 +2441,15 @@ static const struct usb_device_id uvc_ids[] = {
> .driver_info = (kernel_ulong_t)&(const struct uvc_device_info){
> .uvc_version = 0x010a,
> } },
I think you should add a comment containing the name of the camera model you
want to add support for. Look at other examples in uvc_ids[]
e.g. look at this comment for a camera also from Quanta
/* Quanta USB2.0 HD UVC Webcam */
> + { .match_flags = USB_DEVICE_ID_MATCH_DEVICE
> + | USB_DEVICE_ID_MATCH_INT_INFO,
> + .idVendor = 0x0408,
> + .idProduct = 0x4033,
> + .bInterfaceClass = USB_CLASS_VIDEO,
> + .bInterfaceSubClass = 1,
> + .bInterfaceProtocol = UVC_PC_PROTOCOL_15,
> + .driver_info = (kernel_ulong_t) &(const struct uvc_device_info )
> + {.uvc_version = 0x010a, } },
> /* LogiLink Wireless Webcam */
> { .match_flags = USB_DEVICE_ID_MATCH_DEVICE
> | USB_DEVICE_ID_MATCH_INT_INFO,
> --
> 2.43.0
>
--
Kind Regards
Mehdi Djait
diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c index f0febdc08..1a3229ab6 100644 --- a/drivers/media/usb/uvc/uvc_driver.c +++ b/drivers/media/usb/uvc/uvc_driver.c @@ -2441,6 +2441,15 @@ static const struct usb_device_id uvc_ids[] = { .driver_info = (kernel_ulong_t)&(const struct uvc_device_info){ .uvc_version = 0x010a, } }, + { .match_flags = USB_DEVICE_ID_MATCH_DEVICE + | USB_DEVICE_ID_MATCH_INT_INFO, + .idVendor = 0x0408, + .idProduct = 0x4033, + .bInterfaceClass = USB_CLASS_VIDEO, + .bInterfaceSubClass = 1, + .bInterfaceProtocol = UVC_PC_PROTOCOL_15, + .driver_info = (kernel_ulong_t) &(const struct uvc_device_info ) + {.uvc_version = 0x010a, } }, /* LogiLink Wireless Webcam */ { .match_flags = USB_DEVICE_ID_MATCH_DEVICE | USB_DEVICE_ID_MATCH_INT_INFO,