media: rc: iguanair: handle timeouts

Commit Message

Oliver Neukum Nov. 26, 2024, 1:17 p.m. UTC

In case of a timeout the IO must be cancelled or
the next IO using the URB will fail and/or overwrite
an operational URB.

The automatic bisection fails because it arrives
at a commit that correctly lets the test case run
without an error.

Signed-off-by: Oliver Neukum <[e-mail]>
Fixes: e99a7cfe93fd9  ("[media] iguanair: reuse existing urb callback for command responses")
Reported-by: [e-mail]
Tested-by: [e-mail]
---
 drivers/media/rc/iguanair.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Greg KH Nov. 26, 2024, 10:27 p.m. UTC | #1

On Tue, Nov 26, 2024 at 02:17:22PM +0100, Oliver Neukum wrote:
> In case of a timeout the IO must be cancelled or
> the next IO using the URB will fail and/or overwrite
> an operational URB.
> 
> The automatic bisection fails because it arrives
> at a commit that correctly lets the test case run
> without an error.
> 
> Signed-off-by: Oliver Neukum <[e-mail]>
> Fixes: e99a7cfe93fd9  ("[media] iguanair: reuse existing urb callback for command responses")
> Reported-by: [e-mail]
> Tested-by: [e-mail]
> ---
>  drivers/media/rc/iguanair.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/media/rc/iguanair.c b/drivers/media/rc/iguanair.c
> index 276bf3c8a8cb..8af94246e591 100644
> --- a/drivers/media/rc/iguanair.c
> +++ b/drivers/media/rc/iguanair.c
> @@ -194,8 +194,10 @@ static int iguanair_send(struct iguanair *ir, unsigned size)
>  	if (rc)
>  		return rc;
>  
> -	if (wait_for_completion_timeout(&ir->completion, TIMEOUT) == 0)
> +	if (wait_for_completion_timeout(&ir->completion, TIMEOUT) == 0) {
> +		usb_kill_urb(ir->urb_out);
>  		return -ETIMEDOUT;
> +	}
>  
>  	return rc;
>  }
> -- 
> 2.47.0
> 
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- You have marked a patch with a "Fixes:" tag for a commit that is in an
  older released kernel, yet you do not have a cc: stable line in the
  signed-off-by area at all, which means that the patch will not be
  applied to any older kernel releases.  To properly fix this, please
  follow the documented rules in the
  Documentation/process/stable-kernel-rules.rst file for how to resolve
  this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

Patch

diff --git a/drivers/media/rc/iguanair.c b/drivers/media/rc/iguanair.c
index 276bf3c8a8cb..8af94246e591 100644
--- a/drivers/media/rc/iguanair.c
+++ b/drivers/media/rc/iguanair.c
@@ -194,8 +194,10 @@  static int iguanair_send(struct iguanair *ir, unsigned size)
 	if (rc)
 		return rc;
 
-	if (wait_for_completion_timeout(&ir->completion, TIMEOUT) == 0)
+	if (wait_for_completion_timeout(&ir->completion, TIMEOUT) == 0) {
+		usb_kill_urb(ir->urb_out);
 		return -ETIMEDOUT;
+	}
 
 	return rc;
 }