From patchwork Wed Feb 12 10:08:40 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Prashanth K X-Patchwork-Id: 13971863 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45FB51F0E5F for ; Wed, 12 Feb 2025 10:08:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739354932; cv=none; b=d2P5hU9GFOmuJeQK6cw+xJNUBD+OsNlSPNJAwt+JQnPssDcg3FeDFdFyLhelYhjopiFL/Bt8i/V+TPzgqYFbW6kLKXFjr1dcCurKVGU4/ct831wWUob7zlt4MvsfVmv9xeb/YsVXeWq8zFe6J0ROht8qhqggUsC0PNa+0WiR3s4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739354932; c=relaxed/simple; bh=TCwfIE/pUasluVSwZTdHWUH2y9kGY+p5IU5lrrQ0aXU=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=Hd0fhGcFqNn8oitgeeoAWQreV3sRsjWtGlSaoIjIZmQqTEW9Td2doAXycL68iiAxm/niYqHSSh58WUBxQ5seLcKTwaCjWZL1WYi82cejxZHSq0VGc1ZC05PhjCFe+f3lfm5rsVhWk/ii/tDVXxlS/tAlLvFC6t746h46Sl5L6pA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=oMm7YIZo; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="oMm7YIZo" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 51C95PQb026413 for ; Wed, 12 Feb 2025 10:08:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=B21EnyUYOIhZzIf5xVM2mRo1SahizWAydB+ PPvQassE=; b=oMm7YIZobwLDYtUoNSqzPIWZNhkDJkCirtGEzxbCSz8WKm4YUUU rzYtbqDN9Zs+O6DnQCx8tK/28YOGM7xA4m2o72pbddvppru7lX/eYRFTxZ/JYfqo Tv04T9FJutBmZeNFZtRZgcQm29ZxBzd92e8HNqKgZITmT/5bY9DdM/qGZTRh5oU3 ZX/T5eLDVZ+Z5sanm8QXPVTr41dp1tdLpcB9T2Y2RSAlNz/DoxdAWnHTGVGW1F7g ScD0tVnUeiKctd+lHdmid3tP/M5C5jRZJ89W2fKzpy/MryMsd6Wt9PDqIoFB6iLI g/fm5q1BKZNd7uao4ITlGuR0IC9uJnGpynw== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 44r5j5bbpx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 12 Feb 2025 10:08:48 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-21f7671a821so80989685ad.1 for ; Wed, 12 Feb 2025 02:08:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739354927; x=1739959727; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=B21EnyUYOIhZzIf5xVM2mRo1SahizWAydB+PPvQassE=; b=NNZbM4KXUHYSAQVDIJAgtCOWwNlqWO0n+M/XYSE2c4RBvrrIYFo7XFuVNJqt+CPA/x G+6Sj3xrh0BAP+QHtbc17etekCms2hTC6CUIzibGmLn971+YXXaNFOByFHK7gnAUUhVb inqeV5+adNSOXCvnViDwx7h5o3kFI3H6hPCwiZMhKdHxiBEzPDcxgHckZ73TYVq8F8h9 eZekSAaFA0NNa9eLXVmFaDXJCRzXVnOEZw6mtfvYqkX/5gW42bjBluAnuUNakidJdxDc nZa4lMnxRbz04bMQQzvhVPQ7wIs1Gic0gfyxgBrS/vL/WKpkgSADUT+msZRwb/8VSkfQ A5ig== X-Gm-Message-State: AOJu0YzZg/FkH+2w/3GQSdEmoiRkM7gr+ju5Dkm8J5/seard3v4nQodH OybMx8GgNaLar5HfIgf2Pi8q8GMeMS3JBMYTkv1wM+XUenh1K7vZvfEoek9+OBqyl1+G8LliFQx IkT3MS9cCH2Gq7dmnFNWGW+bGUQSISMixF5M1njV3f4ZLuLpiuAzaujMu8bQ= X-Gm-Gg: ASbGnctL26Vr33Wh3Yggmdh5j425uiHZ1J6GZ2W+lzZLFVx6TMSnmM6zB0Tw6M7PVJK vkkp4NNAnjvVJAaO48zcrNEs3kAG/yPb7QEhXXhaAIQWAdqJZPiEQWzrFUS2kQU+Zu/yCNaQsYk UK+GxKBbj/HmYOKQC9Ny5EuAX6HozohFZn14i822Wi31WBJ7/pcj7ERjUpBfS38s1KGz1iHKxXF RS/WxrUR26KF4VPyuHVemIlLtxtleKGJPB9w2pexmQfQ+n/377CGKdKe6A7E04hwos2+qgfki2G A/04VC4enwSR1XVJR7hFjPX32OiY6IYthA== X-Received: by 2002:a17:903:32c8:b0:21f:5638:2d8 with SMTP id d9443c01a7336-220bbdd906dmr49597985ad.53.1739354927475; Wed, 12 Feb 2025 02:08:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IE5QcjisXpRuziURHZeTlGA14PANI0hISRmK+4kzlfLZqi/cdkjxjyPK2eRmbaTegnFEn+qyw== X-Received: by 2002:a17:903:32c8:b0:21f:5638:2d8 with SMTP id d9443c01a7336-220bbdd906dmr49597525ad.53.1739354927105; Wed, 12 Feb 2025 02:08:47 -0800 (PST) Received: from hu-prashk-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21f365517desm109635795ad.86.2025.02.12.02.08.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Feb 2025 02:08:46 -0800 (PST) From: Prashanth K To: Greg Kroah-Hartman , Ferry Toth , Ricardo B Marliere , Kees Cook Cc: linux-usb@vger.kernel.org, Elson Roy Serrao , linux-kernel@vger.kernel.org, Prashanth K , stable@vger.kernel.org Subject: [PATCH] usb: gadget: u_ether: Set is_suspend flag if remote wakeup fails Date: Wed, 12 Feb 2025 15:38:40 +0530 Message-Id: <20250212100840.3812153-1-prashanth.k@oss.qualcomm.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Proofpoint-ORIG-GUID: _j0w8RdSID_3nvqPEs-0M9hN2NXw0mBM X-Proofpoint-GUID: _j0w8RdSID_3nvqPEs-0M9hN2NXw0mBM X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-12_03,2025-02-11_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 priorityscore=1501 mlxscore=0 bulkscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 spamscore=0 clxscore=1015 impostorscore=0 mlxlogscore=720 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2501170000 definitions=main-2502120077 Currently while UDC suspends, u_ether attempts to remote wakeup the host if there are any pending transfers. However, if remote wakeup fails, the UDC remains suspended but the is_suspend flag is not set. And since is_suspend flag isn't set, the subsequent eth_start_xmit() would queue USB requests to suspended UDC. To fix this, bail out from gether_suspend() only if remote wakeup operation is successful. Cc: stable@vger.kernel.org Fixes: 0a1af6dfa077 ("usb: gadget: f_ecm: Add suspend/resume and remote wakeup support") Signed-off-by: Prashanth K --- drivers/usb/gadget/function/u_ether.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/function/u_ether.c b/drivers/usb/gadget/function/u_ether.c index 09e2838917e2..f58590bf5e02 100644 --- a/drivers/usb/gadget/function/u_ether.c +++ b/drivers/usb/gadget/function/u_ether.c @@ -1052,8 +1052,8 @@ void gether_suspend(struct gether *link) * There is a transfer in progress. So we trigger a remote * wakeup to inform the host. */ - ether_wakeup_host(dev->port_usb); - return; + if (!ether_wakeup_host(dev->port_usb)) + return; } spin_lock_irqsave(&dev->lock, flags); link->is_suspend = true;