| Message ID | 20250213091553.198050-1-412574090@163.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | usb: fix error while OF and ACPI all config Y | expand |
On Thu, Feb 13, 2025 at 05:15:53PM +0800, 412574090@163.com wrote: > From: weiyufeng <weiyufeng@kylinos.cn> > > When both OF and ACPI are configured as Y simultaneously，this may > cause error while install os with usb disk，while reading data from > the usb disk, the onboard_ hub driver will reinitialize the > hub, causing system installation exceptions. > > Signed-off-by: weiyufeng <weiyufeng@kylinos.cn> > --- > drivers/usb/misc/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/misc/Kconfig b/drivers/usb/misc/Kconfig > index 6497c4e81e95..94e75e7adcc1 100644 > --- a/drivers/usb/misc/Kconfig > +++ b/drivers/usb/misc/Kconfig > @@ -318,7 +318,7 @@ config BRCM_USB_PINMAP > > config USB_ONBOARD_DEV > tristate "Onboard USB device support" > - depends on OF > + depends on OF && !ACPI > help > Say Y here if you want to support discrete onboard USB devices > that don't require an additional control bus for initialization, > -- > 2.25.1 > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what needs to be done here to properly describe this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot
On Thu, Feb 13, 2025 at 05:15:53PM +0800, 412574090@163.com wrote: > From: weiyufeng <weiyufeng@kylinos.cn> > > When both OF and ACPI are configured as Y simultaneously，this may > cause error while install os with usb disk，while reading data from > the usb disk, the onboard_ hub driver will reinitialize the > hub, causing system installation exceptions. > > Signed-off-by: weiyufeng <weiyufeng@kylinos.cn> > --- > drivers/usb/misc/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/misc/Kconfig b/drivers/usb/misc/Kconfig > index 6497c4e81e95..94e75e7adcc1 100644 > --- a/drivers/usb/misc/Kconfig > +++ b/drivers/usb/misc/Kconfig > @@ -318,7 +318,7 @@ config BRCM_USB_PINMAP > > config USB_ONBOARD_DEV > tristate "Onboard USB device support" > - depends on OF > + depends on OF && !ACPI > help > Say Y here if you want to support discrete onboard USB devices > that don't require an additional control bus for initialization, > -- > 2.25.1 > What commit id does this fix? And why did this just show up now? Also, this feels very odd, why not fix the driver to work properly here instead of attempting to just not build it at all? Building code with OF and ACPI enabled should be allowed. thanks, greg k-h
diff --git a/drivers/usb/misc/Kconfig b/drivers/usb/misc/Kconfig index 6497c4e81e95..94e75e7adcc1 100644 --- a/drivers/usb/misc/Kconfig +++ b/drivers/usb/misc/Kconfig @@ -318,7 +318,7 @@ config BRCM_USB_PINMAP config USB_ONBOARD_DEV tristate "Onboard USB device support" - depends on OF + depends on OF && !ACPI help Say Y here if you want to support discrete onboard USB devices that don't require an additional control bus for initialization,