From patchwork Fri Feb 28 15:11:16 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?J=2E_Neusch=C3=A4fer_via_B4_Relay?= X-Patchwork-Id: 13996610 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C2411EF36F; Fri, 28 Feb 2025 15:11:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740755495; cv=none; b=HwS1+LaWtwHNCi6D+kQbfLtM/VbepJl9jzXzycOSIZvVHO4E3/5FtKJKC8SuY+U+gPUGVZONjn831ObW0VWa6tBH3304hIGvnwnw3wxy5maeuJ1QcvOX1kkoNXl+NHgY1tF3T5m8p3B5VM5sFu1WnUaD+SWobgxDLxnpahJP+yo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740755495; c=relaxed/simple; bh=1o77/8igQZt/xJ2Kd8mV46bACMnbG99oXC2sWZBzzJg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Pt/WIYAWmPizdZxoK4x9a2LhOWqKulL0Ut/pzabLhN1HlUl3hHSPVnn+d7iAQiUU9GvXuX6kf++c4MgfHjPE5ciPBI56B4ZhrJv1qIJJmDGYl4DqtN/2y5a9E/UfN/sVmqYDNqBrt63UfgRtV+3iCxoLZDCL7H/PQXd0QvrnlRU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Y2RZDy6U; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Y2RZDy6U" Received: by smtp.kernel.org (Postfix) with ESMTPS id C815AC4CEE5; Fri, 28 Feb 2025 15:11:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740755494; bh=1o77/8igQZt/xJ2Kd8mV46bACMnbG99oXC2sWZBzzJg=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=Y2RZDy6UxMTgoHApth9amNouIqWjfnbDOd65PK3Tm0XC/rXFjbjedOcjmaAEJHNDd UV6iMXNo2HySv53iNOTgba5bXfLGsGrTAizkbqssrpJwpHa8c59a6BQyTP+NuqqGg/ 8H/ALSa3oxRbpjzMLsSq6pZmW14mrpT7IbAwxoW3IIy3rjDP+hy22nXizy8ou5//XU iitPXNL+tfHV6zDEHs6j2qAaSAjrTJOsQHiQYS3Bxa0Xnd8gg5NWmMbwHz/xeFU8Dp J0fcV4e10S7LzIlAEf8u1tIZiCW66ZQyjDx3JmAyHWd39VFOZFDCSxzynTNkZWHkWP ulMwkjupIjs3A== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5CEBC19776; Fri, 28 Feb 2025 15:11:34 +0000 (UTC) From: =?utf-8?q?Jonathan_Neusch=C3=A4fer_via_B4_Relay?= Date: Fri, 28 Feb 2025 16:11:16 +0100 Subject: [PATCH v3 1/9] usb: storage: jumpshot: Use const for constant arrays Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250228-misc-const-v3-1-09b417ded9c4@posteo.net> References: <20250228-misc-const-v3-0-09b417ded9c4@posteo.net> In-Reply-To: <20250228-misc-const-v3-0-09b417ded9c4@posteo.net> To: Alan Stern , Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net, linux-kernel@vger.kernel.org, =?utf-8?q?Jonathan_Neusch=C3=A4fer?= X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1740755487; l=1808; i=j.ne@posteo.net; s=20240329; h=from:subject:message-id; bh=vYhXHGRk3wSzAZtFyzQxidAFQUuE+w6UkTPB8JZk5oU=; b=tMxBK4bYZASZaHDupcd8lpaS1+U5sINyheFD6lc5vO3grKfy9/oMQjtSzmdgSYmafSPXuenju 6gdeGzbTKhGD73i7o1ZK2yb+YCfijV7PSMujmH801PWpIZ4l3yA+iZu X-Developer-Key: i=j.ne@posteo.net; a=ed25519; pk=NIe0bK42wNaX/C4bi6ezm7NJK0IQE+8MKBm7igFMIS4= X-Endpoint-Received: by B4 Relay for j.ne@posteo.net/20240329 with auth_id=156 X-Original-From: =?utf-8?q?Jonathan_Neusch=C3=A4fer?= Reply-To: j.ne@posteo.net From: Jonathan Neuschäfer These arrays are not modified. Make them const. Declaring data as const makes it easier to see what's going on, and can prevent unintended writes through placement in a read-only section. Signed-off-by: Jonathan Neuschäfer --- V3: - elaborate why const is a good idea V2: - use consistent authorship information --- drivers/usb/storage/jumpshot.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/usb/storage/jumpshot.c b/drivers/usb/storage/jumpshot.c index 39ca84d6859122903de4e64b13e697e8b7d4ab31..089c6f8ac85fbb683cca8b03a2ff06c0ca776167 100644 --- a/drivers/usb/storage/jumpshot.c +++ b/drivers/usb/storage/jumpshot.c @@ -367,16 +367,16 @@ static int jumpshot_handle_mode_sense(struct us_data *us, struct scsi_cmnd * srb, int sense_6) { - static unsigned char rw_err_page[12] = { + static const unsigned char rw_err_page[12] = { 0x1, 0xA, 0x21, 1, 0, 0, 0, 0, 1, 0, 0, 0 }; - static unsigned char cache_page[12] = { + static const unsigned char cache_page[12] = { 0x8, 0xA, 0x1, 0, 0, 0, 0, 0, 0, 0, 0, 0 }; - static unsigned char rbac_page[12] = { + static const unsigned char rbac_page[12] = { 0x1B, 0xA, 0, 0x81, 0, 0, 0, 0, 0, 0, 0, 0 }; - static unsigned char timer_page[8] = { + static const unsigned char timer_page[8] = { 0x1C, 0x6, 0, 0, 0, 0 }; unsigned char pc, page_code; @@ -477,7 +477,7 @@ static int jumpshot_transport(struct scsi_cmnd *srb, struct us_data *us) int rc; unsigned long block, blocks; unsigned char *ptr = us->iobuf; - static unsigned char inquiry_response[8] = { + static const unsigned char inquiry_response[8] = { 0x00, 0x80, 0x00, 0x01, 0x1F, 0x00, 0x00, 0x00 };