| Message ID | 69cc710fa8b7d18c494c9f482fd2b8e6fb7c0c94.1525865206.git.chunfeng.yun@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, On Wed, 2018-05-09 at 14:33 +0300, Felipe Balbi wrote: > Hi, > > Chunfeng Yun <chunfeng.yun@mediatek.com> writes: > > The USB3CV version 2.1.80 (March 26, 2018) requires all devices > > ( gen1, gen2, single lane, dual lane) to return the value of 0x0320 > > in the bcdUSB field > > this sounds really odd. What happens when I get a USB 3.1 compliant > device off-the-shelf and run it through USB3CV? will it fail now? It will fail, the last version require it 0x0310 > > Care to share a screenshot or the raw html of the test result? A screenshot is attached >
Hi, Chunfeng Yun <chunfeng.yun@mediatek.com> writes: > On Wed, 2018-05-09 at 14:33 +0300, Felipe Balbi wrote: >> Hi, >> >> Chunfeng Yun <chunfeng.yun@mediatek.com> writes: >> > The USB3CV version 2.1.80 (March 26, 2018) requires all devices >> > ( gen1, gen2, single lane, dual lane) to return the value of 0x0320 >> > in the bcdUSB field >> >> this sounds really odd. What happens when I get a USB 3.1 compliant >> device off-the-shelf and run it through USB3CV? will it fail now? > Yes, it will fail, the last version requires it 0x0310 >> >> Care to share a screenshot or the raw html of the test result? > A screenshot is attached really odd. But I'll apply the patch. thanks
diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c index 63a7cb8..f242c2b 100644 --- a/drivers/usb/gadget/composite.c +++ b/drivers/usb/gadget/composite.c @@ -1601,7 +1601,7 @@ static int fill_ext_prop(struct usb_configuration *c, int interface, u8 *buf) cdev->gadget->ep0->maxpacket; if (gadget_is_superspeed(gadget)) { if (gadget->speed >= USB_SPEED_SUPER) { - cdev->desc.bcdUSB = cpu_to_le16(0x0310); + cdev->desc.bcdUSB = cpu_to_le16(0x0320); cdev->desc.bMaxPacketSize0 = 9; } else { cdev->desc.bcdUSB = cpu_to_le16(0x0210);
The USB3CV version 2.1.80 (March 26, 2018) requires all devices ( gen1, gen2, single lane, dual lane) to return the value of 0x0320 in the bcdUSB field Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> --- drivers/usb/gadget/composite.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)