From patchwork Thu Mar 5 21:23:49 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thinh Nguyen X-Patchwork-Id: 11422669 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4EF3B92A for ; Thu, 5 Mar 2020 21:23:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 25DD02166E for ; Thu, 5 Mar 2020 21:23:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=synopsys.com header.i=@synopsys.com header.b="PJLgzcz7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726162AbgCEVXv (ORCPT ); Thu, 5 Mar 2020 16:23:51 -0500 Received: from smtprelay-out1.synopsys.com ([149.117.87.133]:47408 "EHLO smtprelay-out1.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726111AbgCEVXv (ORCPT ); Thu, 5 Mar 2020 16:23:51 -0500 Received: from mailhost.synopsys.com (sv1-mailhost2.synopsys.com [10.205.2.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by smtprelay-out1.synopsys.com (Postfix) with ESMTPS id B5E91C10CC; Thu, 5 Mar 2020 21:23:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1583443431; bh=yrq7Q9RqsiuUmyEzEOOBnbBOQwoF7QudkSxK5FWQMz8=; h=Date:In-Reply-To:References:From:Subject:To:Cc:From; b=PJLgzcz7QyDxpORLYGj7+Q6jdvt7xRFbn3JOjRIHx2Tg9IC3LEzwsDV8LLIRT6SN6 85A8pHj/dE7iJ99AWUmsaiMgIMlWVWibFda9OySAT24T+cJ1Rus/6CzRy3HAQd0BFP t5e/CZiOe9yGphXNkSLJT0Uhq5XhiMVGWL1rBqsQ2De6vxUjMxWPXH7LAF+ht94rTg xfMlZktmAR4tPIWthU9BAy+I4f1v/T6DEbyy/+T1DBynoPsnUdUP3cID8Yi6cghOgg 7PeNepYnfYe1smiZUFdsJeLGNnvo/QIbaUyEakXyjLA1VDc7huGeD2a7xtUUnj4j3Q 7pEk10feesNDA== Received: from te-lab16 (nanobot.internal.synopsys.com [10.10.186.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mailhost.synopsys.com (Postfix) with ESMTPSA id 67C37A006D; Thu, 5 Mar 2020 21:23:49 +0000 (UTC) Received: by te-lab16 (sSMTP sendmail emulation); Thu, 05 Mar 2020 13:23:49 -0800 Date: Thu, 05 Mar 2020 13:23:49 -0800 Message-Id: <6daaa98986b2061c2784e7229df2af8baeb9d783.1583443184.git.thinhn@synopsys.com> In-Reply-To: References: From: Thinh Nguyen Subject: [PATCH 1/6] usb: dwc3: gadget: Don't clear flags before transfer ended To: Felipe Balbi , Greg Kroah-Hartman , Thinh Nguyen , linux-usb@vger.kernel.org Cc: John Youn Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org We track END_TRANSFER command completion. Don't clear transfer started/ended flag prematurely. Otherwise, we'd run into the problem with restarting transfer before END_TRANSFER command finishes. Fixes: 6d8a019614f3 ("usb: dwc3: gadget: check for Missed Isoc from event status") Signed-off-by: Thinh Nguyen --- drivers/usb/dwc3/gadget.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index 1b7d2f9cb673..b87bdec84210 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -2563,10 +2563,8 @@ static void dwc3_gadget_endpoint_transfer_in_progress(struct dwc3_ep *dep, dwc3_gadget_ep_cleanup_completed_requests(dep, event, status); - if (stop) { + if (stop) dwc3_stop_active_transfer(dep, true, true); - dep->flags = DWC3_EP_ENABLED; - } /* * WORKAROUND: This is the 2nd half of U1/U2 -> U0 workaround.