adding a new device in uvc_driver

Commit Message

amilsananak Aug. 30, 2024, 11:07 a.m. UTC

adding the webcam of new acer aspire7

output of lsusb: "Bus 001 Device 002: ID 0408:4033 Quanta Computer, Inc.
ACER HD User Facing

"

Comments

Greg KH Aug. 30, 2024, 11:17 a.m. UTC | #1

On Fri, Aug 30, 2024 at 04:37:29PM +0530, Amil Sanan wrote:
> adding the webcam of new acer aspire7
> 
> output of lsusb: "Bus 001 Device 002: ID 0408:4033 Quanta Computer, Inc.
> ACER HD User Facing
> 
> "

> From d18ad3bf9bbc93da3eeb0ca4ea6598955ac05a99 Mon Sep 17 00:00:00 2001
> From: amilsanan <[e-mail]>
> Date: Thu, 29 Aug 2024 17:38:25 +0530
> Subject: [PATCH] add a device in uvc_driver
> 
> Signed-off-by: amilsanan <[e-mail]>
> ---
>  drivers/media/usb/uvc/uvc_driver.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
> index f0febdc08..1a3229ab6 100644
> --- a/drivers/media/usb/uvc/uvc_driver.c
> +++ b/drivers/media/usb/uvc/uvc_driver.c
> @@ -2441,6 +2441,15 @@ static const struct usb_device_id uvc_ids[] = {
>  	  .driver_info		= (kernel_ulong_t)&(const struct uvc_device_info){
>  		.uvc_version = 0x010a,
>  	  } },
> +	  { .match_flags 	= USB_DEVICE_ID_MATCH_DEVICE
> +			| USB_DEVICE_ID_MATCH_INT_INFO,
> +	  .idVendor = 0x0408,
> +	  .idProduct = 0x4033,
> +	  .bInterfaceClass = USB_CLASS_VIDEO,
> +	  .bInterfaceSubClass = 1,
> +	  .bInterfaceProtocol =	UVC_PC_PROTOCOL_15,
> +	  .driver_info = (kernel_ulong_t) &(const struct uvc_device_info ) 
> +		{.uvc_version = 0x010a, } },
>  	/* LogiLink Wireless Webcam */
>  	{ .match_flags		= USB_DEVICE_ID_MATCH_DEVICE
>  				| USB_DEVICE_ID_MATCH_INT_INFO,
> -- 
> 2.43.0
> 


Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch was attached, please place it inline so that it can be
  applied directly from the email message itself.

- It looks like you did not use your "real" name for the patch on either
  the Signed-off-by: line, or the From: line (both of which have to
  match).  Please read the kernel file,
  Documentation/process/submitting-patches.rst for how to do this
  correctly.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

Greg KH Sept. 2, 2024, 5:57 a.m. UTC | #2

On Mon, Sep 02, 2024 at 09:37:22AM +0530, Amil Sanan wrote:
> I don't understand what is the issue

The bot said what was wrong:

> > - Your patch was attached, please place it inline so that it can be
> >   applied directly from the email message itself.
> >
> > - It looks like you did not use your "real" name for the patch on either
> >   the Signed-off-by: line, or the From: line (both of which have to
> >   match).  Please read the kernel file,
> >   Documentation/process/submitting-patches.rst for how to do this
> >   correctly.

Both need to be fixed up.

Please see the hundreds of examples on the mailing list for details on
how to do this in a way that we can accept it.

thanks,

greg k-h

Laurent Pinchart Sept. 2, 2024, 6:08 a.m. UTC | #3

On Mon, Sep 02, 2024 at 07:57:02AM +0200, Greg KH wrote:
> On Mon, Sep 02, 2024 at 09:37:22AM +0530, Amil Sanan wrote:
> > I don't understand what is the issue
> 
> The bot said what was wrong:
> 
> > > - Your patch was attached, please place it inline so that it can be
> > >   applied directly from the email message itself.

I previously pointed you to git-send-email and
https://git-send-email.io/ and I highly recommend using that workflow to
submit patches. Some people use different tools, and you could decide to
do so as well, but you won't receive much support from the community
regarding the tooling in that case.

Also, as requested before, you *must* disable HTML e-mails or your mails
won't make it properly to the lists.

> > > - It looks like you did not use your "real" name for the patch on either
> > >   the Signed-off-by: line, or the From: line (both of which have to
> > >   match).  Please read the kernel file,
> > >   Documentation/process/submitting-patches.rst for how to do this
> > >   correctly.
> 
> Both need to be fixed up.
> 
> Please see the hundreds of examples on the mailing list for details on
> how to do this in a way that we can accept it.

Patch

From d18ad3bf9bbc93da3eeb0ca4ea6598955ac05a99 Mon Sep 17 00:00:00 2001
From: amilsanan <[e-mail]>
Date: Thu, 29 Aug 2024 17:38:25 +0530
Subject: [PATCH] add a device in uvc_driver

Signed-off-by: amilsanan <[e-mail]>
---
 drivers/media/usb/uvc/uvc_driver.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
index f0febdc08..1a3229ab6 100644
--- a/drivers/media/usb/uvc/uvc_driver.c
+++ b/drivers/media/usb/uvc/uvc_driver.c
@@ -2441,6 +2441,15 @@  static const struct usb_device_id uvc_ids[] = {
 	  .driver_info		= (kernel_ulong_t)&(const struct uvc_device_info){
 		.uvc_version = 0x010a,
 	  } },
+	  { .match_flags 	= USB_DEVICE_ID_MATCH_DEVICE
+			| USB_DEVICE_ID_MATCH_INT_INFO,
+	  .idVendor = 0x0408,
+	  .idProduct = 0x4033,
+	  .bInterfaceClass = USB_CLASS_VIDEO,
+	  .bInterfaceSubClass = 1,
+	  .bInterfaceProtocol =	UVC_PC_PROTOCOL_15,
+	  .driver_info = (kernel_ulong_t) &(const struct uvc_device_info ) 
+		{.uvc_version = 0x010a, } },
 	/* LogiLink Wireless Webcam */
 	{ .match_flags		= USB_DEVICE_ID_MATCH_DEVICE
 				| USB_DEVICE_ID_MATCH_INT_INFO,
-- 
2.43.0