From patchwork Wed Jun 20 22:22:55 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 10478797 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4B09F600F6 for ; Wed, 20 Jun 2018 22:23:11 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3A03E28FB3 for ; Wed, 20 Jun 2018 22:23:11 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2A56C28FBB; Wed, 20 Jun 2018 22:23:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BAECD28FB3 for ; Wed, 20 Jun 2018 22:23:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933508AbeFTWW5 (ORCPT ); Wed, 20 Jun 2018 18:22:57 -0400 Received: from mail-oi0-f68.google.com ([209.85.218.68]:43243 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933308AbeFTWW4 (ORCPT ); Wed, 20 Jun 2018 18:22:56 -0400 Received: by mail-oi0-f68.google.com with SMTP id t133-v6so1063136oif.10; Wed, 20 Jun 2018 15:22:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=wPQ6rw8QbQsZVkjYwUhnh4MmKBTegAQscmezDVbzZME=; b=JhRDbTXC9o6mIJzPz0uRmih0RGWIXPctwXM02aZyqc+ang21eq6rwbYJLwFECVDqPE JsZhraKs8D1zdAyeDl+3wd6soNzqsNIZ3uEtxcI6xVfhgC7T8AVL5GxN1GWmXNiqLpzA IxkJm4CHcnJgWWaXUbssui06jl4kzbUlfTpV0r2x3tkiTqgjbavA/le/0pGbTvPS/so7 BsxR8MuuQsYpHsvV8ZB9E5n33bHFLBdazafi/GxVbuKkwMtv3R/PHIZaPRGlrWmbMUDm gooWXK3Z+6LX/hywV2hf7ug1qf0nLY1bjszST1J2KXlwd8SmHl0n38wbQ1NdtWvvbAzh +gZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=wPQ6rw8QbQsZVkjYwUhnh4MmKBTegAQscmezDVbzZME=; b=c2Cu9OyYkb+HHEHuF5xelZtVavCdyKmts2Tycra8SCpv+1MuYCp9rXXsEdDRe/UolJ 9vhBmWVKViGXQco9BnpGZph3njLCR8rIN453Jmhujubc5SNleeYO7E9tSxbk0qc5EBsa +OZGQ42kdwkvAOqHxjikBu60frXc7e2kD+iFdq5wAdnCg1C1YYCuTjauXHzYROvDep4z QqsLvSbQX7j1GZuV2Dnssr5yOsXpMkrZKInb2q8eu6zEL8E0YBBGm4N8YKXpUxaoH5K8 F9w56UqKw+CEBYZINb0MdCxP/lx+X01FsVC00unb3Zo8/RUR/gmVDD8C5lbICQ/ICzJC 43mg== X-Gm-Message-State: APt69E2l9RNjpEnNFCVXMoQRugV8dAAidO5kVd+Gkfrm6j3ZANihVPGF OffiBj6tPN5bSJ3uKu6xzq0D8hKMn/EVRGqDvWI= X-Google-Smtp-Source: ADUXVKIIc1Ad16Xrd12mE/FAwWqQX4cBrPn6rinx/c/0iN9Q3M8KNFUFy0bgF7lJs+vFgYXFv/VhaHFR14Y6rQxrPxc= X-Received: by 2002:aca:f244:: with SMTP id q65-v6mr13889516oih.71.1529533375660; Wed, 20 Jun 2018 15:22:55 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a9d:1049:0:0:0:0:0 with HTTP; Wed, 20 Jun 2018 15:22:55 -0700 (PDT) In-Reply-To: References: <20180530173414.6121-1-andrew.smirnov@gmail.com> From: Fabio Estevam Date: Wed, 20 Jun 2018 19:22:55 -0300 Message-ID: Subject: Re: [PATCH] usb: chipidea: Fix ULPI on imx51 To: Andrey Smirnov Cc: Greg Kroah-Hartman , Nikita Yushchenko , Peter Chen , USB list , linux-kernel , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Fabio Estevam , Chris Healy , Lucas Stach , Sebastian Reichel Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Wed, Jun 20, 2018 at 7:07 PM, Fabio Estevam wrote: > This patches causes a regression on a imx51-babbage running 4.18-rc1: > I get a kernel hang. > > If I revert it on top of 4.18-rc1, then it boots fine and USB host is > functional. > > I understand this patch fixes a kernel hang for you, so which commit > is responsible for the hang you observe? > > It seems this commit fixes a hang for you and causes another hang for me :-) > > Any ideas? I am able to boot again if I skip passing the CI_HDRC_OVERRIDE_PHY_CONTROL flag: --- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/drivers/usb/chipidea/ci_hdrc_imx.c +++ b/drivers/usb/chipidea/ci_hdrc_imx.c @@ -294,7 +294,6 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev) if ((of_device_is_compatible(np, "fsl,imx53-usb") || of_device_is_compatible(np, "fsl,imx51-usb")) && pdata.usb_phy && of_usb_get_phy_mode(np) == USBPHY_INTERFACE_MODE_ULPI) { - pdata.flags |= CI_HDRC_OVERRIDE_PHY_CONTROL; data->override_phy_control = true; usb_phy_init(pdata.usb_phy); }