diff mbox series

[2/2] USB: net2280: Remove ->disconnect() callback from net2280_pullup()

Message ID Pine.LNX.4.44L0.1808101531050.1425-100000@iolanthe.rowland.org (mailing list archive)
State New, archived
Headers show
Series USB: gadget core: Call ->disconnect() from usb_gadget_disconnect() | expand

Commit Message

Alan Stern Aug. 10, 2018, 7:32 p.m. UTC 
The net2280 UDC driver invokes the gadget driver's ->disconnect()
callback routine when the net2280_pullup() routine turns off the D+
pullup.  This is now unnecessary, because the gadget core performs the
callback on our behalf.  This patch removes the unneeded callback.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>

---


[as1875]


 drivers/usb/gadget/udc/net2280.c |    3 ---
 1 file changed, 3 deletions(-)
diff mbox series

Patch

Index: usb-4.x/drivers/usb/gadget/udc/net2280.c
===================================================================
--- usb-4.x.orig/drivers/usb/gadget/udc/net2280.c
+++ usb-4.x/drivers/usb/gadget/udc/net2280.c
@@ -1550,9 +1550,6 @@  static int net2280_pullup(struct usb_gad
 
 	spin_unlock_irqrestore(&dev->lock, flags);
 
-	if (!is_on && dev->driver)
-		dev->driver->disconnect(&dev->gadget);
-
 	return 0;
 }