diff mbox series

USB: serial: mos7840: fix error code in mos7840_write()

Message ID YA/ubifCUlJXxG5g@mwanda (mailing list archive)
State Accepted
Commit a70aa7dc60099bbdcbd6faca42a915d80f31161e
Headers show
Series USB: serial: mos7840: fix error code in mos7840_write() | expand

Commit Message

Dan Carpenter Jan. 26, 2021, 10:26 a.m. UTC 
This should return -ENOMEM instead of 0 if the kmalloc() fails.

Fixes: 3f5429746d91 ("USB: Moschip 7840 USB-Serial Driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/usb/serial/mos7840.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Johan Hovold Jan. 26, 2021, 2:31 p.m. UTC | #1 
On Tue, Jan 26, 2021 at 01:26:54PM +0300, Dan Carpenter wrote:
> This should return -ENOMEM instead of 0 if the kmalloc() fails.
> 
> Fixes: 3f5429746d91 ("USB: Moschip 7840 USB-Serial Driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Applied, thanks.

Johan
diff mbox series

Patch

diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c
index 23f91d658cb4..30c25ef0dacd 100644
--- a/drivers/usb/serial/mos7840.c
+++ b/drivers/usb/serial/mos7840.c
@@ -883,8 +883,10 @@  static int mos7840_write(struct tty_struct *tty, struct usb_serial_port *port,
 	if (urb->transfer_buffer == NULL) {
 		urb->transfer_buffer = kmalloc(URB_TRANSFER_BUFFER_SIZE,
 					       GFP_ATOMIC);
-		if (!urb->transfer_buffer)
+		if (!urb->transfer_buffer) {
+			bytes_sent = -ENOMEM;
 			goto exit;
+		}
 	}
 	transfer_size = min(count, URB_TRANSFER_BUFFER_SIZE);