| Message ID | YtpD4MKBa43higNc@kili (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 0c25bab1abb43dbe2662e88f56e157ccac76f8c2 |
| Headers | show |
| Series | [1/3] usb: typec: anx7411: Fix an array out of bounds | expand |
On Fri, Jul 22, 2022 at 09:29:52AM +0300, Dan Carpenter wrote: > Semi colons and commas are equivalent in this context but semi-colons > are better style. Hi Dan Carpenter, thanks for your patch. Reviewed-by: Xin Ji <xji@analogixsemi.com> Thanks, Xin > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > --- > drivers/usb/typec/anx7411.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/usb/typec/anx7411.c b/drivers/usb/typec/anx7411.c > index 311b56aaea9f..18a6a6a8b9eb 100644 > --- a/drivers/usb/typec/anx7411.c > +++ b/drivers/usb/typec/anx7411.c > @@ -1421,12 +1421,12 @@ static int anx7411_psy_register(struct anx7411_data *ctx) > psy_desc->type = POWER_SUPPLY_TYPE_USB; > psy_desc->usb_types = anx7411_psy_usb_types; > psy_desc->num_usb_types = ARRAY_SIZE(anx7411_psy_usb_types); > - psy_desc->properties = anx7411_psy_props, > - psy_desc->num_properties = ARRAY_SIZE(anx7411_psy_props), > + psy_desc->properties = anx7411_psy_props; > + psy_desc->num_properties = ARRAY_SIZE(anx7411_psy_props); > > - psy_desc->get_property = anx7411_psy_get_prop, > - psy_desc->set_property = anx7411_psy_set_prop, > - psy_desc->property_is_writeable = anx7411_psy_prop_writeable, > + psy_desc->get_property = anx7411_psy_get_prop; > + psy_desc->set_property = anx7411_psy_set_prop; > + psy_desc->property_is_writeable = anx7411_psy_prop_writeable; > > ctx->usb_type = POWER_SUPPLY_USB_TYPE_C; > ctx->psy = devm_power_supply_register(ctx->dev, psy_desc, &psy_cfg); > -- > 2.35.1
diff --git a/drivers/usb/typec/anx7411.c b/drivers/usb/typec/anx7411.c index 311b56aaea9f..18a6a6a8b9eb 100644 --- a/drivers/usb/typec/anx7411.c +++ b/drivers/usb/typec/anx7411.c @@ -1421,12 +1421,12 @@ static int anx7411_psy_register(struct anx7411_data *ctx) psy_desc->type = POWER_SUPPLY_TYPE_USB; psy_desc->usb_types = anx7411_psy_usb_types; psy_desc->num_usb_types = ARRAY_SIZE(anx7411_psy_usb_types); - psy_desc->properties = anx7411_psy_props, - psy_desc->num_properties = ARRAY_SIZE(anx7411_psy_props), + psy_desc->properties = anx7411_psy_props; + psy_desc->num_properties = ARRAY_SIZE(anx7411_psy_props); - psy_desc->get_property = anx7411_psy_get_prop, - psy_desc->set_property = anx7411_psy_set_prop, - psy_desc->property_is_writeable = anx7411_psy_prop_writeable, + psy_desc->get_property = anx7411_psy_get_prop; + psy_desc->set_property = anx7411_psy_set_prop; + psy_desc->property_is_writeable = anx7411_psy_prop_writeable; ctx->usb_type = POWER_SUPPLY_USB_TYPE_C; ctx->psy = devm_power_supply_register(ctx->dev, psy_desc, &psy_cfg);
Semi colons and commas are equivalent in this context but semi-colons are better style. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- drivers/usb/typec/anx7411.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)