From patchwork Fri Apr 19 11:25:29 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Artur Petrosyan X-Patchwork-Id: 10909751 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8399A14DB for ; Fri, 19 Apr 2019 20:06:16 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 125951FF83 for ; Fri, 19 Apr 2019 20:06:15 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 068071FFB1; Fri, 19 Apr 2019 20:06:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1FE0825223 for ; Fri, 19 Apr 2019 20:06:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728120AbfDSUF4 (ORCPT ); Fri, 19 Apr 2019 16:05:56 -0400 Received: from dc8-smtprelay2.synopsys.com ([198.182.47.102]:36838 "EHLO smtprelay-out1.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728068AbfDSUFw (ORCPT ); Fri, 19 Apr 2019 16:05:52 -0400 Received: from mailhost.synopsys.com (dc8-mailhost2.synopsys.com [10.13.135.210]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by smtprelay-out1.synopsys.com (Postfix) with ESMTPS id B1D3BC1209; Fri, 19 Apr 2019 11:25:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1555673131; bh=4+S92Ayez9OQURkxLcIuAowTTX2V5zeHy2PCgCHR/9g=; h=From:To:CC:Subject:Date:References:In-Reply-To:From; b=O67LjOsCwfJ4Ky47+PeXd7IktU7Ubntk0pM1iFUcxBbQRqX/ccRLwoLdK4SVq8dhi VTWFf0GbANJwI8a4At0FUV/yrGwSXgUI423lTUoR5hPniXZhjTYI+ef7ABWmr+0N+j TiU/NbIbk+QItns+dg5NpaPwr383WRhPcM2nn6j3IZLmOR13Pvl1yEDkV3LTMIb6bf lKqk4zn7UgqzR8pzG3nrk+FhfP5YtZqeS/vhRjZ5hPEtkSHFIk2M3Q8LrQbxl2OU77 Ywha4bEp5zzxyp3XqTXvvCkhLpTJILxR7yDvOmDF0bDvG+DmWb2xrJRaA8xmh9+nX1 bhyJ2ODnIlGKw== Received: from us01wehtc1.internal.synopsys.com (us01wehtc1-vip.internal.synopsys.com [10.12.239.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mailhost.synopsys.com (Postfix) with ESMTPS id 0D2ABA0065; Fri, 19 Apr 2019 11:25:31 +0000 (UTC) Received: from US01HYBRID2.internal.synopsys.com (10.15.246.24) by us01wehtc1.internal.synopsys.com (10.12.239.235) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 19 Apr 2019 04:25:30 -0700 Received: from NAM03-CO1-obe.outbound.protection.outlook.com (10.13.134.195) by mrs.synopsys.com (10.15.246.24) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 19 Apr 2019 04:25:30 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=synopsys.onmicrosoft.com; s=selector1-synopsys-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4+S92Ayez9OQURkxLcIuAowTTX2V5zeHy2PCgCHR/9g=; b=jKoP+W9UWTKCkk3a4yoiuzdq70tqh19+nqJ4i/0nywxmG0zB1gOjpyuBR4KiuMy43Awt4ziJzjUdgxoJC1VdBeWuHvwprcG3T+BsD77MvocJeTZDUao9V3Ic7NBHv5cBPacQBVTdHsc/fc6O+WaySFM7FkxGoABFFHnD4IpAVFU= Received: from SN1PR12MB2431.namprd12.prod.outlook.com (52.132.195.146) by SN1PR12MB2383.namprd12.prod.outlook.com (52.132.194.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1813.14; Fri, 19 Apr 2019 11:25:29 +0000 Received: from SN1PR12MB2431.namprd12.prod.outlook.com ([fe80::5ca6:ee5f:1147:df5a]) by SN1PR12MB2431.namprd12.prod.outlook.com ([fe80::5ca6:ee5f:1147:df5a%4]) with mapi id 15.20.1813.013; Fri, 19 Apr 2019 11:25:29 +0000 From: Artur Petrosyan To: Felipe Balbi , Greg Kroah-Hartman , Minas Harutyunyan , "linux-usb@vger.kernel.org" CC: John Youn , Artur Petrosyan Subject: [PATCH v1 12/14] usb: dwc2: Clear fifo_map when resetting core. Thread-Topic: [PATCH v1 12/14] usb: dwc2: Clear fifo_map when resetting core. Thread-Index: AQHU9qKXjJ2vykcArkSxArt/WbmDZg== Date: Fri, 19 Apr 2019 11:25:29 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: VI1PR08CA0185.eurprd08.prod.outlook.com (2603:10a6:800:d2::15) To SN1PR12MB2431.namprd12.prod.outlook.com (2603:10b6:802:27::18) authentication-results: spf=none (sender IP is ) smtp.mailfrom=arturp@synopsys.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [84.53.141.189] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 10650e2b-c238-406a-dc63-08d6c4b9b948 x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(5600141)(711020)(4605104)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020);SRVR:SN1PR12MB2383; x-ms-traffictypediagnostic: SN1PR12MB2383: x-microsoft-antispam-prvs: x-forefront-prvs: 0012E6D357 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(366004)(136003)(39850400004)(396003)(376002)(346002)(189003)(199004)(6436002)(102836004)(486006)(26005)(186003)(386003)(4326008)(305945005)(2906002)(6506007)(446003)(76176011)(7736002)(97736004)(5660300002)(81156014)(66476007)(11346002)(81166006)(66556008)(6486002)(476003)(256004)(14444005)(53936002)(25786009)(107886003)(71190400001)(71200400001)(86362001)(6512007)(99286004)(54906003)(110136005)(316002)(2616005)(68736007)(8676002)(66066001)(6116002)(36756003)(14454004)(478600001)(2501003)(8936002)(118296001)(3846002)(66446008)(52116002)(64756008)(66946007)(73956011);DIR:OUT;SFP:1102;SCL:1;SRVR:SN1PR12MB2383;H:SN1PR12MB2431.namprd12.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: synopsys.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: eEDIC+ELmC8FxNod97/gMtmf3cbSR/LHfVGpFqPsfUGYANc5vn31wZYJmlxso+yvltbW+CGMdyNf7wrt/sZcpft6VNl1gsad+masIHw3/cwfzIqqjmHyh45yzSkDmDFcMOeTND7YS1ESo/jYIDteX0+CMfLU1hE6L/054eQF04jh42HywF8H45zcJsPNMhSTgtA2imG2ik/FVlpqRACktxq7cbQaGCUQa+UXaltzWTuLnsrkpgeQioPr8MyW1uUrBz4L5xkRz7lQZJjmCpmQEq9hItI4rya69AnULPccAH6alIL82r5cmxmQgJKdQQOkPBoMbro+OdRS3X87gH+9sUXiMMIvcRDH9ZL2cK7zsCjTbTgWvEku8ooxB1cZ69ZbIb0UDyHVK2oHigG11PHfWJo09Ur3UFzlS5jOp7Ib/go= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 10650e2b-c238-406a-dc63-08d6c4b9b948 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Apr 2019 11:25:29.0848 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: c33c9f88-1eb7-4099-9700-16013fd9e8aa X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB2383 X-OriginatorOrg: synopsys.com Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP If core enters host hibernation when switching from device mode to host mode disconnection of host cable asserts a WARNING in dwc2_hsotg_init_fifo() that fifo_map is not cleared. To avoid the WARNING, fifo_map should be cleared in dwc2_core_reset() function. - Cleared fifo_map when resetting the core. Signed-off-by: Artur Petrosyan --- drivers/usb/dwc2/core.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/usb/dwc2/core.c b/drivers/usb/dwc2/core.c index fb471d18a3de..fbbd6a2f10ad 100644 --- a/drivers/usb/dwc2/core.c +++ b/drivers/usb/dwc2/core.c @@ -532,6 +532,12 @@ int dwc2_core_reset(struct dwc2_hsotg *hsotg, bool skip_wait) greset |= GRSTCTL_CSFTRST; dwc2_writel(hsotg, greset, GRSTCTL); + /* Clear fifo_map */ + #if IS_ENABLED(CONFIG_USB_DWC2_PERIPHERAL) || \ + IS_ENABLED(CONFIG_USB_DWC2_DUAL_ROLE) + hsotg->fifo_map = 0; + #endif /* CONFIG_USB_DWC2_PERIPHERAL || CONFIG_USB_DWC2_DUAL_ROLE */ + if (dwc2_hsotg_wait_bit_clear(hsotg, GRSTCTL, GRSTCTL_CSFTRST, 50)) { dev_warn(hsotg->dev, "%s: HANG! Soft Reset timeout GRSTCTL GRSTCTL_CSFTRST\n", __func__);