| Message ID | bab16136-a57c-e7ed-0261-c44e76923c82@ivitera.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | usb: gadget: audio: add bi-directional volume and mute support | expand |
On Sat, Jul 10, 2021 at 02:53:20PM +0200, Pavel Hofman wrote: > > Similar to UAC1 spec, UAC2 feature unit descriptor > has variable size. > > Current audio-v2 feature unit descriptor structure > is used for parsing descriptors, but can't be used > to define your own descriptor. > > Add a new macro similar to what audio v1 already has. > > Signed-off-by: Ruslan Bilovol <ruslan.bilovol@gmail.com> > --- > include/linux/usb/audio-v2.h | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) Who wrote this Ruslan or you? If Ruslan, you need to put a "From:" line as the first line of the changelog text, and you also need to sign off on this, as the patch is coming through you. Same for the other 4 patches. Also, they were not "linked" together at all, can you use 'git send-email' to send them so that they are correctly associated with each other so our tools will work easier on them? thanks, greg k-h
diff --git a/include/linux/usb/audio-v2.h b/include/linux/usb/audio-v2.h index ead8c9a47c6a..8fc2abd7aecb 100644 --- a/include/linux/usb/audio-v2.h +++ b/include/linux/usb/audio-v2.h @@ -156,6 +156,20 @@ struct uac2_feature_unit_descriptor { __u8 bmaControls[]; /* variable length */ } __attribute__((packed)); +#define UAC2_DT_FEATURE_UNIT_SIZE(ch) (6 + ((ch) + 1) * 4) + +/* As above, but more useful for defining your own descriptors: */ +#define DECLARE_UAC2_FEATURE_UNIT_DESCRIPTOR(ch) \ +struct uac2_feature_unit_descriptor_##ch { \ + __u8 bLength; \ + __u8 bDescriptorType; \ + __u8 bDescriptorSubtype; \ + __u8 bUnitID; \ + __u8 bSourceID; \ + __le32 bmaControls[ch + 1]; \ + __u8 iFeature; \ +} __packed + /* 4.7.2.10 Effect Unit Descriptor */ struct uac2_effect_unit_descriptor {
Similar to UAC1 spec, UAC2 feature unit descriptor has variable size. Current audio-v2 feature unit descriptor structure is used for parsing descriptors, but can't be used to define your own descriptor. Add a new macro similar to what audio v1 already has. Signed-off-by: Ruslan Bilovol <ruslan.bilovol@gmail.com> --- include/linux/usb/audio-v2.h | 14 ++++++++++++++ 1 file changed, 14 insertions(+)