| Message ID | d120fc57ba8836df3f1dc597335499e2233aef53.1574893374.git.thinhn@synopsys.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | usb: dwc3: gadget: Do link recovery for SS and SSP | expand |
Thinh Nguyen <Thinh.Nguyen@synopsys.com> writes: > The controller always supports link recovery for device in SS and SSP. > Remove the speed limit check. Also, when the device is in RESUME or > RESET state, it means the controller received the resume/reset request. > The driver must send the link recovery to acknowledge the request. They > are valid states for the driver to send link recovery. > > Signed-off-by: Thinh Nguyen <thinhn@synopsys.com> Care to add a Fixes tag?
Felipe Balbi wrote: > Thinh Nguyen <Thinh.Nguyen@synopsys.com> writes: > >> The controller always supports link recovery for device in SS and SSP. >> Remove the speed limit check. Also, when the device is in RESUME or >> RESET state, it means the controller received the resume/reset request. >> The driver must send the link recovery to acknowledge the request. They >> are valid states for the driver to send link recovery. >> >> Signed-off-by: Thinh Nguyen <thinhn@synopsys.com> > Care to add a Fixes tag? > Sure. I just resent it. Thanks, Thinh
diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index 7f97856e6b20..08bb26fe9fd4 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -1709,7 +1709,6 @@ static int __dwc3_gadget_wakeup(struct dwc3 *dwc) u32 reg; u8 link_state; - u8 speed; /* * According to the Databook Remote wakeup request should @@ -1719,16 +1718,13 @@ static int __dwc3_gadget_wakeup(struct dwc3 *dwc) */ reg = dwc3_readl(dwc->regs, DWC3_DSTS); - speed = reg & DWC3_DSTS_CONNECTSPD; - if ((speed == DWC3_DSTS_SUPERSPEED) || - (speed == DWC3_DSTS_SUPERSPEED_PLUS)) - return 0; - link_state = DWC3_DSTS_USBLNKST(reg); switch (link_state) { + case DWC3_LINK_STATE_RESET: case DWC3_LINK_STATE_RX_DET: /* in HS, means Early Suspend */ case DWC3_LINK_STATE_U3: /* in HS, means SUSPEND */ + case DWC3_LINK_STATE_RESUME: break; default: return -EINVAL;
The controller always supports link recovery for device in SS and SSP. Remove the speed limit check. Also, when the device is in RESUME or RESET state, it means the controller received the resume/reset request. The driver must send the link recovery to acknowledge the request. They are valid states for the driver to send link recovery. Signed-off-by: Thinh Nguyen <thinhn@synopsys.com> --- drivers/usb/dwc3/gadget.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)