mbox series

[v3,0/4] simatic-ipc additions to p2sb apl lake gpio

Message ID 20220513083652.974-1-henning.schild@siemens.com (mailing list archive)
Headers show
Series simatic-ipc additions to p2sb apl lake gpio | expand

Message

Henning Schild May 13, 2022, 8:36 a.m. UTC 
changed since v2:
 - put GPIO led module under same config switch
 - some style changes from review
 - init gpios with gpiod_get_index and drop gpiod_set_value
 - drop bogus "if" from watchdog Kconfig

changed since v1:
 - rebased
 - split p1 into p1-3

This switches the simatic-ipc modules to using the upcoming p2sb 
interface introduced by Andy with 
"platform/x86: introduce p2sb_bar() helper".
The series relies on these p2sb changes already applied and Andy will
likely take them into his series at some point.

It also switches to one apollo lake device to using gpio leds.

Henning Schild (4):
  leds: simatic-ipc-leds: convert to use P2SB accessor
  watchdog: simatic-ipc-wdt: convert to use P2SB accessor
  platform/x86: simatic-ipc: drop custom P2SB bar code
  leds: simatic-ipc-leds-gpio: add GPIO version of Siemens driver

 drivers/leds/simple/Kconfig                   |   6 +-
 drivers/leds/simple/Makefile                  |   1 +
 drivers/leds/simple/simatic-ipc-leds-gpio.c   | 105 ++++++++++++++++++
 drivers/leds/simple/simatic-ipc-leds.c        |  80 +------------
 drivers/platform/x86/simatic-ipc.c            |  43 +------
 drivers/watchdog/Kconfig                      |   1 +
 drivers/watchdog/simatic-ipc-wdt.c            |  15 +--
 .../platform_data/x86/simatic-ipc-base.h      |   2 -
 8 files changed, 126 insertions(+), 127 deletions(-)
 create mode 100644 drivers/leds/simple/simatic-ipc-leds-gpio.c

Comments

Andy Shevchenko May 23, 2022, 4:24 p.m. UTC | #1 
On Fri, May 13, 2022 at 10:36:48AM +0200, Henning Schild wrote:
> changed since v2:
>  - put GPIO led module under same config switch
>  - some style changes from review
>  - init gpios with gpiod_get_index and drop gpiod_set_value
>  - drop bogus "if" from watchdog Kconfig
> 
> changed since v1:
>  - rebased
>  - split p1 into p1-3
> 
> This switches the simatic-ipc modules to using the upcoming p2sb 
> interface introduced by Andy with 
> "platform/x86: introduce p2sb_bar() helper".
> The series relies on these p2sb changes already applied and Andy will
> likely take them into his series at some point.
> 
> It also switches to one apollo lake device to using gpio leds.

Hmm... This series misses LEDS maintainer. Okay, I will include them when
sending v6 after v5.19-rc1.
Andy Shevchenko June 7, 2022, 3:18 p.m. UTC | #2 
On Mon, May 23, 2022 at 07:24:08PM +0300, Andy Shevchenko wrote:
> On Fri, May 13, 2022 at 10:36:48AM +0200, Henning Schild wrote:
> > changed since v2:
> >  - put GPIO led module under same config switch
> >  - some style changes from review
> >  - init gpios with gpiod_get_index and drop gpiod_set_value
> >  - drop bogus "if" from watchdog Kconfig
> > 
> > changed since v1:
> >  - rebased
> >  - split p1 into p1-3
> > 
> > This switches the simatic-ipc modules to using the upcoming p2sb 
> > interface introduced by Andy with 
> > "platform/x86: introduce p2sb_bar() helper".
> > The series relies on these p2sb changes already applied and Andy will
> > likely take them into his series at some point.
> > 
> > It also switches to one apollo lake device to using gpio leds.
> 
> Hmm... This series misses LEDS maintainer. Okay, I will include them when
> sending v6 after v5.19-rc1.

I have sent v6 [1], please make sure everything is okay.

[1]: https://lore.kernel.org/platform-driver-x86/20220606164138.66535-1-andriy.shevchenko@linux.intel.com/
Henning Schild June 7, 2022, 4:15 p.m. UTC | #3 
Am Tue, 7 Jun 2022 18:18:05 +0300
schrieb Andy Shevchenko <andriy.shevchenko@linux.intel.com>:

> On Mon, May 23, 2022 at 07:24:08PM +0300, Andy Shevchenko wrote:
> > On Fri, May 13, 2022 at 10:36:48AM +0200, Henning Schild wrote:  
> > > changed since v2:
> > >  - put GPIO led module under same config switch
> > >  - some style changes from review
> > >  - init gpios with gpiod_get_index and drop gpiod_set_value
> > >  - drop bogus "if" from watchdog Kconfig
> > > 
> > > changed since v1:
> > >  - rebased
> > >  - split p1 into p1-3
> > > 
> > > This switches the simatic-ipc modules to using the upcoming p2sb 
> > > interface introduced by Andy with 
> > > "platform/x86: introduce p2sb_bar() helper".
> > > The series relies on these p2sb changes already applied and Andy
> > > will likely take them into his series at some point.
> > > 
> > > It also switches to one apollo lake device to using gpio leds.  
> > 
> > Hmm... This series misses LEDS maintainer. Okay, I will include
> > them when sending v6 after v5.19-rc1.  
> 
> I have sent v6 [1], please make sure everything is okay.

I received that and had a quick look over my bits. That all looked like
i sent it so i have no reason to doubt it would be working as expected.

In the coming two weeks i will not be able to get my hands on hardware,
so can not test but am pretty sure it is not needed another time.

regards,
Henning
 
> [1]:
> https://lore.kernel.org/platform-driver-x86/20220606164138.66535-1-andriy.shevchenko@linux.intel.com/