[v5,0/2] avoid globals and arch dependencies

Message

Sergio Paracuellos Feb. 13, 2023, 12:06 p.m. UTC

Hi all,

This series make an update in the MT7621 SoC's watchdog driver code. This
SoC already provides a system controller node to access reset status
register needed for the watchdog. Instead of using MIPS architecture
dependent operations in header 'asm/mach-ralink/ralink_regs.h' could use
a phandle to the system controller node and use it through regmap APIs
from the code. However this means to break dtb's ABI so previous series
patches related with this have been droped from this version.
Driver is also using some globals that are not needed at all if a driver
data structure is used along the code. Hence, add all new needed stuff
inside a new driver data structure.

Thanks in advance for reviewing this!

v1 of this series here [0].
v2 os thise series here [1].
v3 os thise series here [2].
v4 os thise series here [3].

Changes in v5:
    - Drop patches related with device tree ABI breakage and only
      maintain the rest.
    - Collect Arinc 'Reviewed-by' tag for watchdog node warning fix.

Changes in v4:
    - Add a patch to fix a watchdog node warning with 'make dtbs_check'
      because of a wrong node name.
    - Collect Guenter 'Reviewed-by' tags for watchdog driver code.
    - Add a missing 'COMPILE_TEST' to Kconfig which was lost when driver
      code was split in two patches in v2.

Changes in v3:
    - rename phandler from 'ralink,sysctl' into 'mediatek,sysctl'.
    - Drop error message added in PATCH 3 that modifies functionality
      and we only want to maintain current functionaloty by now.

Changes in v2:
    - Remove no needed compatible 'syscon' from bindings.
    - Rewrite new syscon phandle description in bindings.
    - Remove 'syscon' from compatible in 'mt7621.dtsi'.
    - Split PATCH 3 into two different patches:
        - PATCH 3: removes static globals using a driver data structure.
        - PATCH 4: remove ralink architecture dependent includes and code.

Best regards,
    Sergio Paracuellos

[0]: https://lore.kernel.org/linux-watchdog/[e-mail]/T/#t
[1]: https://lore.kernel.org/linux-watchdog/[e-mail]/T/#t
[2]: https://lore.kernel.org/linux-watchdog/[e-mail]/T/#t
[3]: https://lore.kernel.org/linux-watchdog/[e-mail]/T/#t

Sergio Paracuellos (2):
  mips: dts: ralink: mt7621: rename watchdog node from 'wdt' into
    'watchdog'
  watchdog: mt7621-wdt: avoid static global declarations

 arch/mips/boot/dts/ralink/mt7621.dtsi |   2 +-
 drivers/watchdog/mt7621_wdt.c         | 102 ++++++++++++++++----------
 2 files changed, 66 insertions(+), 38 deletions(-)