mbox series

[v2,RESEND,0/2] watchdog: apple: Increase reset delay to 150ms

Message ID 20241029013055.45538-1-towinchenmi@gmail.com (mailing list archive)
Headers show
Series watchdog: apple: Increase reset delay to 150ms | expand

Message

Nick Chan Oct. 29, 2024, 1:29 a.m. UTC 
Increase the reset delay to 150ms as the Apple A8X SoC can take up to
125ms to actually reset.

Since the code is being modified anyways, also fix a bug where watchdog
writes were not actually getting flushed after requesting reset, depsite
what the code comments said.

Changes since v1:
- Fix an existing bug where watchdog writes are not flushed

v1: https://lore.kernel.org/asahi/20240930060653.4024-1-towinchenmi@gmail.com

Nick Chan
---

Nick Chan (2):
  watchdog: apple: Actually flush writes after requesting watchdog
    restart
  watchdog: apple: Increase reset delay to 150ms

 drivers/watchdog/apple_wdt.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)


base-commit: dec9255a128e19c5fcc3bdb18175d78094cc624d

Comments

Hector Martin Nov. 1, 2024, 1:02 p.m. UTC | #1 
On 2024/10/29 10:29, Nick Chan wrote:
> Increase the reset delay to 150ms as the Apple A8X SoC can take up to
> 125ms to actually reset.
> 
> Since the code is being modified anyways, also fix a bug where watchdog
> writes were not actually getting flushed after requesting reset, depsite
> what the code comments said.
> 
> Changes since v1:
> - Fix an existing bug where watchdog writes are not flushed
> 
> v1: https://lore.kernel.org/asahi/20240930060653.4024-1-towinchenmi@gmail.com
> 
> Nick Chan
> ---
> 
> Nick Chan (2):
>   watchdog: apple: Actually flush writes after requesting watchdog
>     restart
>   watchdog: apple: Increase reset delay to 150ms
> 
>  drivers/watchdog/apple_wdt.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> 
> base-commit: dec9255a128e19c5fcc3bdb18175d78094cc624d

Acked-by: Hector Martin <marcan@marcan.st>

- Hector