From patchwork Mon Apr 8 19:38:36 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guenter Roeck X-Patchwork-Id: 10890027 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D3C48922 for ; Mon, 8 Apr 2019 19:41:02 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BEA3E285A4 for ; Mon, 8 Apr 2019 19:41:02 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B317D28746; Mon, 8 Apr 2019 19:41:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D119B285A4 for ; Mon, 8 Apr 2019 19:41:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726528AbfDHTkz (ORCPT ); Mon, 8 Apr 2019 15:40:55 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:35543 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728820AbfDHTjz (ORCPT ); Mon, 8 Apr 2019 15:39:55 -0400 Received: by mail-pg1-f193.google.com with SMTP id g8so7886505pgf.2; Mon, 08 Apr 2019 12:39:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=Q4IVqeF4eZZXzwVrhyw6JtwBOUJ05UVuGHVxZTEZZdU=; b=N3tNEhM4n5CfkxYTcyWJbYPcwVQRRdZLr2UhTXffPar0h9nfX6CfIxON0DdhDJVU52 aFKqgKzMN21GkK+pYfVMGlNVkIT3By/9vKd9XtvDu8+wrNazmhcOBQ6rvvzxOJ7ODnvw W4qczJuODQwMRZme95bXyat9m+WnkhQ+2JetESXGSELDlpO1BsryR4tatwbSaiHos0g/ LfpexKN9R4iU2ifWpf8IlmwpszQvWN+sXjpD69+pqGOSUQ8mX/KE0PpYBwZ/TPPIpz+3 GdnyzDxZv55laIigHrUGrVkI0Vs+BnMsF6xPr5tBO2XtNTVEC6gX3/epECu7SXgpAEzS Vm7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=Q4IVqeF4eZZXzwVrhyw6JtwBOUJ05UVuGHVxZTEZZdU=; b=OF996+BJfKNfWF9VPXkKoh+12gV4vXPgrajF4zf18EnG/DmpejRG7soe158+4R6/Xq IYOGfPFn0yn8cBcVsLWvIuU/W22lxaq8GVZlaHbaEG+W8k0pNJDmO2XeYm4vzqt2ipP6 cu2B+7DlwT+dN6QlwyFerReKNHqiXH3ESJrTytYDcDbZB98prsJy30RaPn/F7tIu6/nc Km7sevo99hS+Yx1g30c2uowuflCwCQ3Vz5Ggfc0GYJP6woMggOgLfxkm3sfwcvEY/Soa DC0C3Tm7IInOxhjjEVTCg+V0KHXDpQx8VIWkVgv6cNQ1yUrQ+a4hNgIn++pm2rd/5Wol RD1Q== X-Gm-Message-State: APjAAAVxX2NgTiL7RKM9RACm9wiO7XC5su6GM9hjKC/MfQNHwHTqhy52 jBlabIMtA4j2QTWmsQx814vRAAxC X-Google-Smtp-Source: APXvYqwkn4qLegFXQdKoqO/f/kRIxwjxg2aiOghzxxTAxLFve2jRnPPAed5TyPnVcHpjf7fzBmY7vA== X-Received: by 2002:a63:e004:: with SMTP id e4mr30532805pgh.344.1554752394183; Mon, 08 Apr 2019 12:39:54 -0700 (PDT) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id 20sm40639951pfn.131.2019.04.08.12.39.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 Apr 2019 12:39:53 -0700 (PDT) From: Guenter Roeck To: Wim Van Sebroeck Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, Guenter Roeck , Support Opensource Subject: [PATCH 12/22] watchdog: da9063_wdt: Use 'dev' instead of dereferencing it repeatedly Date: Mon, 8 Apr 2019 12:38:36 -0700 Message-Id: <1554752326-13319-13-git-send-email-linux@roeck-us.net> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1554752326-13319-1-git-send-email-linux@roeck-us.net> References: <1554752326-13319-1-git-send-email-linux@roeck-us.net> Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Introduce local variable 'struct device *dev' and use it instead of dereferencing it repeatedly. The conversion was done automatically with coccinelle using the following semantic patches. The semantic patches and the scripts used to generate this commit log are available at https://github.com/groeck/coccinelle-patches Cc: Support Opensource Signed-off-by: Guenter Roeck Acked-by: Steve Twiss --- drivers/watchdog/da9063_wdt.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/watchdog/da9063_wdt.c b/drivers/watchdog/da9063_wdt.c index 384dca16af8b..06eb9070203c 100644 --- a/drivers/watchdog/da9063_wdt.c +++ b/drivers/watchdog/da9063_wdt.c @@ -188,17 +188,18 @@ static const struct watchdog_ops da9063_watchdog_ops = { static int da9063_wdt_probe(struct platform_device *pdev) { + struct device *dev = &pdev->dev; struct da9063 *da9063; struct watchdog_device *wdd; - if (!pdev->dev.parent) + if (!dev->parent) return -EINVAL; - da9063 = dev_get_drvdata(pdev->dev.parent); + da9063 = dev_get_drvdata(dev->parent); if (!da9063) return -EINVAL; - wdd = devm_kzalloc(&pdev->dev, sizeof(*wdd), GFP_KERNEL); + wdd = devm_kzalloc(dev, sizeof(*wdd), GFP_KERNEL); if (!wdd) return -ENOMEM; @@ -208,7 +209,7 @@ static int da9063_wdt_probe(struct platform_device *pdev) wdd->max_timeout = DA9063_WDT_MAX_TIMEOUT; wdd->min_hw_heartbeat_ms = DA9063_RESET_PROTECTION_MS; wdd->timeout = DA9063_WDG_TIMEOUT; - wdd->parent = &pdev->dev; + wdd->parent = dev; wdd->status = WATCHDOG_NOWAYOUT_INIT_STATUS; @@ -222,7 +223,7 @@ static int da9063_wdt_probe(struct platform_device *pdev) set_bit(WDOG_HW_RUNNING, &wdd->status); } - return devm_watchdog_register_device(&pdev->dev, wdd); + return devm_watchdog_register_device(dev, wdd); } static struct platform_driver da9063_wdt_driver = {