| Message ID | 1576825096-26605-1-git-send-email-srinivas.neeli@xilinx.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | watchdog: cadence: Skip printing pointer value | expand |
On Fri, Dec 20, 2019 at 12:28:16PM +0530, Srinivas Neeli wrote: > "%p" is not printing the pointer value. > In driver, printing pointer value is not useful so avoiding print. > > Signed-off-by: Srinivas Neeli <srinivas.neeli@xilinx.com> Reviewed-by: Guenter Roeck <linux@roeck-us.net> > --- > drivers/watchdog/cadence_wdt.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/watchdog/cadence_wdt.c b/drivers/watchdog/cadence_wdt.c > index 06bd4e1a5923..672b184da875 100644 > --- a/drivers/watchdog/cadence_wdt.c > +++ b/drivers/watchdog/cadence_wdt.c > @@ -369,9 +369,8 @@ static int cdns_wdt_probe(struct platform_device *pdev) > return ret; > platform_set_drvdata(pdev, wdt); > > - dev_info(dev, "Xilinx Watchdog Timer at %p with timeout %ds%s\n", > - wdt->regs, cdns_wdt_device->timeout, > - nowayout ? ", nowayout" : ""); > + dev_info(dev, "Xilinx Watchdog Timer with timeout %ds%s\n", > + cdns_wdt_device->timeout, nowayout ? ", nowayout" : ""); > > return 0; > } > -- > 2.7.4 >
On 12/19/19 10:58 PM, Srinivas Neeli wrote: > "%p" is not printing the pointer value. > In driver, printing pointer value is not useful so avoiding print. > > Signed-off-by: Srinivas Neeli <srinivas.neeli@xilinx.com> Reviewed-by: Guenter Roeck <linux@roeck-us.net> > --- > drivers/watchdog/cadence_wdt.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/watchdog/cadence_wdt.c b/drivers/watchdog/cadence_wdt.c > index 06bd4e1a5923..672b184da875 100644 > --- a/drivers/watchdog/cadence_wdt.c > +++ b/drivers/watchdog/cadence_wdt.c > @@ -369,9 +369,8 @@ static int cdns_wdt_probe(struct platform_device *pdev) > return ret; > platform_set_drvdata(pdev, wdt); > > - dev_info(dev, "Xilinx Watchdog Timer at %p with timeout %ds%s\n", > - wdt->regs, cdns_wdt_device->timeout, > - nowayout ? ", nowayout" : ""); > + dev_info(dev, "Xilinx Watchdog Timer with timeout %ds%s\n", > + cdns_wdt_device->timeout, nowayout ? ", nowayout" : ""); > > return 0; > } >
diff --git a/drivers/watchdog/cadence_wdt.c b/drivers/watchdog/cadence_wdt.c index 06bd4e1a5923..672b184da875 100644 --- a/drivers/watchdog/cadence_wdt.c +++ b/drivers/watchdog/cadence_wdt.c @@ -369,9 +369,8 @@ static int cdns_wdt_probe(struct platform_device *pdev) return ret; platform_set_drvdata(pdev, wdt); - dev_info(dev, "Xilinx Watchdog Timer at %p with timeout %ds%s\n", - wdt->regs, cdns_wdt_device->timeout, - nowayout ? ", nowayout" : ""); + dev_info(dev, "Xilinx Watchdog Timer with timeout %ds%s\n", + cdns_wdt_device->timeout, nowayout ? ", nowayout" : ""); return 0; }
"%p" is not printing the pointer value. In driver, printing pointer value is not useful so avoiding print. Signed-off-by: Srinivas Neeli <srinivas.neeli@xilinx.com> --- drivers/watchdog/cadence_wdt.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)