| Message ID | 1650984810-6247-4-git-send-email-liuxp11@chinatelecom.cn (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | Some impovements about acpi hardware watchdog | expand |
On Tue, Apr 26, 2022 at 10:53:30PM +0800, Liu Xinpeng wrote: > Test shows that wachdog still reboots machine after the module > is removed. Use watchdog_stop_on_unregister to stop the watchdog > on removing. > > Signed-off-by: Liu Xinpeng <liuxp11@chinatelecom.cn> Reviewed-by: Guenter Roeck <linux@roeck-us.net> > --- > drivers/watchdog/wdat_wdt.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/watchdog/wdat_wdt.c b/drivers/watchdog/wdat_wdt.c > index 6f36a653767b..e6f95e99156d 100644 > --- a/drivers/watchdog/wdat_wdt.c > +++ b/drivers/watchdog/wdat_wdt.c > @@ -463,6 +463,7 @@ static int wdat_wdt_probe(struct platform_device *pdev) > > watchdog_set_nowayout(&wdat->wdd, nowayout); > watchdog_stop_on_reboot(&wdat->wdd); > + watchdog_stop_on_unregister(&wdat->wdd); > return devm_watchdog_register_device(dev, &wdat->wdd); > } > > -- > 2.23.0 >
diff --git a/drivers/watchdog/wdat_wdt.c b/drivers/watchdog/wdat_wdt.c index 6f36a653767b..e6f95e99156d 100644 --- a/drivers/watchdog/wdat_wdt.c +++ b/drivers/watchdog/wdat_wdt.c @@ -463,6 +463,7 @@ static int wdat_wdt_probe(struct platform_device *pdev) watchdog_set_nowayout(&wdat->wdd, nowayout); watchdog_stop_on_reboot(&wdat->wdd); + watchdog_stop_on_unregister(&wdat->wdd); return devm_watchdog_register_device(dev, &wdat->wdd); }
Test shows that wachdog still reboots machine after the module is removed. Use watchdog_stop_on_unregister to stop the watchdog on removing. Signed-off-by: Liu Xinpeng <liuxp11@chinatelecom.cn> --- drivers/watchdog/wdat_wdt.c | 1 + 1 file changed, 1 insertion(+)