From patchwork Tue Jul 30 02:15:40 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Balantzyan X-Patchwork-Id: 11064831 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 932DA14E5 for ; Tue, 30 Jul 2019 02:16:14 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 81AB128750 for ; Tue, 30 Jul 2019 02:16:14 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7481B28764; Tue, 30 Jul 2019 02:16:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 191A928750 for ; Tue, 30 Jul 2019 02:16:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731153AbfG3CQF (ORCPT ); Mon, 29 Jul 2019 22:16:05 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:39556 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730481AbfG3CQC (ORCPT ); Mon, 29 Jul 2019 22:16:02 -0400 Received: by mail-pf1-f196.google.com with SMTP id f17so24984019pfn.6; Mon, 29 Jul 2019 19:16:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=FzaH7PVhh1ba0vgranyXQGmQCp6gwkLqstIglv23EsQ=; b=LyvBSq7Lw08tXQ633RjUqWZpZn43VQW8t+28eD9ymlKdYMU1xpv9DXKYvHhHZXvEwI rxCMCp8aJCZBKhNHg1e0MvPgSxV574CcOl0jpNPjeN8TOeeacpIbJzdZkt5TMU0UWL34 k50ZjFj1jHUtn7lp3ww5c5jIj1KN9oEATWqr+AtuI7Y47AwUhihOMZ/Srs63HDwhgK2G xuZz47MLrSVuse0C3dhTNlCOjI3v06nvrEMr73mhiQDtimhsO8T7OGcLXk/LyviJI4UW Cy7qo8az3HqWjxcGAOqB8b1tSp0HOTe/m7IGwsRRa4PDmXgo2eLRsPDSaQYXvLF1YwZ5 cjKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=FzaH7PVhh1ba0vgranyXQGmQCp6gwkLqstIglv23EsQ=; b=bWAMIo0u071Cv9poiQdTwfjSrFsKD59snYMWW19EEznrwSHIO3lpwHFj1m8DeR6pz9 LQlxnHakDNnG5LI4UBgdYHcnNr1hzS6q3tEctErf+MFywy7Srj9cQdUemjv6bzzvl8pQ MrcNJ6R/qWk8iiK3q8K2o0wU1uTjUCe1cPb7XxGXBOaUpPytI7u96mLyW/+qM5/gAAsZ xcS9cyUUx5AHLKq/9eJgfXMo6OJWrK1MUgkUIsLbhv+1bsIqCt2n+ZDGHzrJc5Acs+UH QsZHQV/a7k97eXewFBtY5H4hdawrUQc6efbvPEofVtnMjUFXq7wmYzTqeb2AXYx2/s+x 4Dww== X-Gm-Message-State: APjAAAWWSwAZzRUq4RB14xyZHx34tb2GWLGlmY8TRZrqOaE++psZWDKw n6hL8Gfi1BpA1+XsnwjgA/g= X-Google-Smtp-Source: APXvYqyzqZjq9jxdFiLhWHSSW5Eg5iWQpzGeoNGFJopdLmyoTZfK/duGMg9X4ELFvax+xWwR0HFxWQ== X-Received: by 2002:a17:90a:29c5:: with SMTP id h63mr110083713pjd.83.1564452961866; Mon, 29 Jul 2019 19:16:01 -0700 (PDT) Received: from localhost.localdomain (d206-116-172-62.bchsia.telus.net. [206.116.172.62]) by smtp.gmail.com with ESMTPSA id x13sm66561133pfn.6.2019.07.29.19.16.01 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 29 Jul 2019 19:16:01 -0700 (PDT) From: Mark Balantzyan To: linux@roeck-us.net Cc: wim@linux-watchdog.org, linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org, andrianov@ispras.ru, Mark Balantzyan Subject: [PATCH 4/4] watchdog device drivers:pc87413_wdt: Continuing revision of conversion of pc87413_wdt to use common watchdog interface, removed undeclared identifiers Date: Mon, 29 Jul 2019 19:15:40 -0700 Message-Id: <20190730021540.66579-4-mbalant3@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190730021540.66579-1-mbalant3@gmail.com> References: <20190730021540.66579-1-mbalant3@gmail.com> Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There is a potential for the variable swc_base_addr in the call chain of the driver initialization function (init) to be used before initialization. This brought up the need for, by rewriting the driver to use the common watchdog interface, ensuring to have all resources in place. This patch addresses this need by rewriting into common watchdog interface utilization for the driver. Signed-off-by: Mark Balantzyan --- drivers/watchdog/pc87413_wdt.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/watchdog/pc87413_wdt.c b/drivers/watchdog/pc87413_wdt.c index bc6c4e19..6863145a 100644 --- a/drivers/watchdog/pc87413_wdt.c +++ b/drivers/watchdog/pc87413_wdt.c @@ -370,7 +370,6 @@ reboot_unreg: static void __exit pc87413_exit(void) { watchdog_unregister_device(&pc87413wdt_wdd); - unregister_reboot_notifier(&pc87413_notifier); release_region(swc_base_addr, 0x20); pr_info("watchdog component driver removed\n");