| Message ID | 20200416163514.7334-5-michaelsh@mellanox.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | support watchdog with longer timeout period | expand |
On Thu, Apr 16, 2020 at 07:35:14PM +0300, michaelsh@mellanox.com wrote: > From: Michael Shych <michaelsh@mellanox.com> > > Add documentation with details of new type of Mellanox watchdog driver. > > Signed-off-by: Michael Shych <michaelsh@mellanox.com> > Stray empty line. Also, the subject should reflect the driver name. Guenter > Reviewed-by: Vadim Pasternak <vadimp@mellanox.com> > --- > Documentation/watchdog/mlx-wdt.rst | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/Documentation/watchdog/mlx-wdt.rst b/Documentation/watchdog/mlx-wdt.rst > index bf5bafac47f0..fa0a94e5c82e 100644 > --- a/Documentation/watchdog/mlx-wdt.rst > +++ b/Documentation/watchdog/mlx-wdt.rst > @@ -24,10 +24,19 @@ Type 2: > Maximum timeout is 255 sec. > Get time-left is supported. > > +Type 3: > + Same as Type 2 with extended maximum timeout period. > + Maximum timeout is 65535 sec. > + > Type 1 HW watchdog implementation exist in old systems and > all new systems have type 2 HW watchdog. > Two types of HW implementation have also different register map. > > +Type 3 HW watchdog implementation can exist on all Mellanox systems > +with new programmer logic device. > +It's differentiated by WD capability bit. > +Old systems still have only one main watchdog. > + > Mellanox system can have 2 watchdogs: main and auxiliary. > Main and auxiliary watchdog devices can be enabled together > on the same system. > -- > 2.11.0 >
Hi Guenter,
By some reason, I obtained only this your mail as a reply to sent patchset V1
Later on, I discovered your comments at
https://www.spinics.net/lists/platform-driver-x86/msg21412.html
And saw that you also have comments regarding [PATCH v1 3/4].
I'm resending patchset v2 that address your comments.
Thanks,
Michael.
> -----Original Message-----
> From: Guenter Roeck <groeck7@gmail.com> On Behalf Of Guenter Roeck
> Sent: Saturday, April 18, 2020 2:47 PM
> To: Michael Shych <michaelsh@mellanox.com>
> Cc: wim@linux-watchdog.org; andy@infradead.org; dvhart@infradead.org; linux-
> watchdog@vger.kernel.org; platform-driver-x86@vger.kernel.org; Vadim
> Pasternak <vadimp@mellanox.com>
> Subject: Re: [PATCH v1 4/4] Documentation/watchdog: Add description of new
> watchdog type 3
>
> On Thu, Apr 16, 2020 at 07:35:14PM +0300, michaelsh@mellanox.com wrote:
> > From: Michael Shych <michaelsh@mellanox.com>
> >
> > Add documentation with details of new type of Mellanox watchdog driver.
> >
> > Signed-off-by: Michael Shych <michaelsh@mellanox.com>
> >
>
> Stray empty line.
>
> Also, the subject should reflect the driver name.
>
> Guenter
>
> > Reviewed-by: Vadim Pasternak <vadimp@mellanox.com>
> > ---
> > Documentation/watchdog/mlx-wdt.rst | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> >
> > diff --git a/Documentation/watchdog/mlx-wdt.rst
> b/Documentation/watchdog/mlx-wdt.rst
> > index bf5bafac47f0..fa0a94e5c82e 100644
> > --- a/Documentation/watchdog/mlx-wdt.rst
> > +++ b/Documentation/watchdog/mlx-wdt.rst
> > @@ -24,10 +24,19 @@ Type 2:
> > Maximum timeout is 255 sec.
> > Get time-left is supported.
> >
> > +Type 3:
> > + Same as Type 2 with extended maximum timeout period.
> > + Maximum timeout is 65535 sec.
> > +
> > Type 1 HW watchdog implementation exist in old systems and
> > all new systems have type 2 HW watchdog.
> > Two types of HW implementation have also different register map.
> >
> > +Type 3 HW watchdog implementation can exist on all Mellanox systems
> > +with new programmer logic device.
> > +It's differentiated by WD capability bit.
> > +Old systems still have only one main watchdog.
> > +
> > Mellanox system can have 2 watchdogs: main and auxiliary.
> > Main and auxiliary watchdog devices can be enabled together
> > on the same system.
> > --
> > 2.11.0
> >
diff --git a/Documentation/watchdog/mlx-wdt.rst b/Documentation/watchdog/mlx-wdt.rst index bf5bafac47f0..fa0a94e5c82e 100644 --- a/Documentation/watchdog/mlx-wdt.rst +++ b/Documentation/watchdog/mlx-wdt.rst @@ -24,10 +24,19 @@ Type 2: Maximum timeout is 255 sec. Get time-left is supported. +Type 3: + Same as Type 2 with extended maximum timeout period. + Maximum timeout is 65535 sec. + Type 1 HW watchdog implementation exist in old systems and all new systems have type 2 HW watchdog. Two types of HW implementation have also different register map. +Type 3 HW watchdog implementation can exist on all Mellanox systems +with new programmer logic device. +It's differentiated by WD capability bit. +Old systems still have only one main watchdog. + Mellanox system can have 2 watchdogs: main and auxiliary. Main and auxiliary watchdog devices can be enabled together on the same system.