| Message ID | 20221102194436.123316-1-marex@denx.de (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [RESEND] dt-bindings: watchdog: gpio: Convert bindings to YAML | expand |
On 02/11/2022 15:44, Marek Vasut wrote: > Convert the gpio-wdt bindings from text to YAML ones, to permit DT validation. > > Signed-off-by: Marek Vasut <marex@denx.de> > --- > Cc: Guenter Roeck <linux@roeck-us.net> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Wim Van Sebroeck <wim@linux-watchdog.org> > Cc: linux-watchdog@vger.kernel.org > To: devicetree@vger.kernel.org > --- > NOTE: The Maintainer entry should likely be changed, although it seems > like this driver and its matching bindings are now unmaintained. Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. Even if driver does not have updated maintainers entry, generic rules apply. > --- > .../devicetree/bindings/watchdog/gpio-wdt.txt | 28 ------------ > .../bindings/watchdog/linux,wdt-gpio.yaml | 44 +++++++++++++++++++ > 2 files changed, 44 insertions(+), 28 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/watchdog/gpio-wdt.txt > create mode 100644 Documentation/devicetree/bindings/watchdog/linux,wdt-gpio.yaml > > diff --git a/Documentation/devicetree/bindings/watchdog/gpio-wdt.txt b/Documentation/devicetree/bindings/watchdog/gpio-wdt.txt > deleted file mode 100644 > index 198794963786b..0000000000000 > --- a/Documentation/devicetree/bindings/watchdog/gpio-wdt.txt > +++ /dev/null > @@ -1,28 +0,0 @@ > -* GPIO-controlled Watchdog > - > -Required Properties: > -- compatible: Should contain "linux,wdt-gpio". > -- gpios: From common gpio binding; gpio connection to WDT reset pin. > -- hw_algo: The algorithm used by the driver. Should be one of the > - following values: > - - toggle: Either a high-to-low or a low-to-high transition clears > - the WDT counter. The watchdog timer is disabled when GPIO is > - left floating or connected to a three-state buffer. > - - level: Low or high level starts counting WDT timeout, > - the opposite level disables the WDT. Active level is determined > - by the GPIO flags. > -- hw_margin_ms: Maximum time to reset watchdog circuit (milliseconds). > - > -Optional Properties: > -- always-running: If the watchdog timer cannot be disabled, add this flag to > - have the driver keep toggling the signal without a client. It will only cease > - to toggle the signal when the device is open and the timeout elapsed. > - > -Example: > - watchdog: watchdog { > - /* ADM706 */ > - compatible = "linux,wdt-gpio"; > - gpios = <&gpio3 9 GPIO_ACTIVE_LOW>; > - hw_algo = "toggle"; > - hw_margin_ms = <1600>; > - }; > diff --git a/Documentation/devicetree/bindings/watchdog/linux,wdt-gpio.yaml b/Documentation/devicetree/bindings/watchdog/linux,wdt-gpio.yaml > new file mode 100644 > index 0000000000000..6b014d60c9471 > --- /dev/null > +++ b/Documentation/devicetree/bindings/watchdog/linux,wdt-gpio.yaml > @@ -0,0 +1,44 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/watchdog/linux,wdt-gpio.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: GPIO-controlled Watchdog > + > +maintainers: > + - Marek Vasut <marex@denx.de> > + > +properties: > + compatible: > + const: linux,wdt-gpio > + > + gpios: > + description: gpio connection to WDT reset pin > + maxItems: 1 > + > + hw_algo: > + description: The algorithm used by the driver. > + enum: [ level, toggle ] > + > + hw_margin_ms: > + description: Maximum time to reset watchdog circuit (milliseconds). > + $ref: /schemas/types.yaml#/definitions/uint32 > + > +required: > + - compatible Several other properties were required. > + > +allOf: > + - $ref: "watchdog.yaml#" Drop quotes Best regards, Krzysztof
On 11/2/22 22:30, Krzysztof Kozlowski wrote: > On 02/11/2022 15:44, Marek Vasut wrote: >> Convert the gpio-wdt bindings from text to YAML ones, to permit DT validation. >> >> Signed-off-by: Marek Vasut <marex@denx.de> >> --- >> Cc: Guenter Roeck <linux@roeck-us.net> >> Cc: Rob Herring <robh+dt@kernel.org> >> Cc: Wim Van Sebroeck <wim@linux-watchdog.org> >> Cc: linux-watchdog@vger.kernel.org >> To: devicetree@vger.kernel.org >> --- >> NOTE: The Maintainer entry should likely be changed, although it seems >> like this driver and its matching bindings are now unmaintained. > > Please use scripts/get_maintainers.pl to get a list of necessary people > and lists to CC. It might happen, that command when run on an older > kernel, gives you outdated entries. Therefore please be sure you base > your patches on recent Linux kernel. > > Even if driver does not have updated maintainers entry, generic rules apply. I'm based on next-20221102, i.e. todays' next, should be recent enough. $ ./scripts/get_maintainer.pl -f drivers/watchdog/gpio_wdt.c Wim Van Sebroeck <wim@linux-watchdog.org> (maintainer:WATCHDOG DEVICE DRIVERS) Guenter Roeck <linux@roeck-us.net> (maintainer:WATCHDOG DEVICE DRIVERS) linux-watchdog@vger.kernel.org (open list:WATCHDOG DEVICE DRIVERS) linux-kernel@vger.kernel.org (open list) Running it against the bindings file, old or new, just adds the DT maintainers into the list, so not much help either. Hence the NOTE. [...] The rest is fixed in v2, thanks.
On 02/11/2022 18:04, Marek Vasut wrote: > On 11/2/22 22:30, Krzysztof Kozlowski wrote: >> On 02/11/2022 15:44, Marek Vasut wrote: >>> Convert the gpio-wdt bindings from text to YAML ones, to permit DT validation. >>> >>> Signed-off-by: Marek Vasut <marex@denx.de> >>> --- >>> Cc: Guenter Roeck <linux@roeck-us.net> >>> Cc: Rob Herring <robh+dt@kernel.org> >>> Cc: Wim Van Sebroeck <wim@linux-watchdog.org> >>> Cc: linux-watchdog@vger.kernel.org >>> To: devicetree@vger.kernel.org >>> --- >>> NOTE: The Maintainer entry should likely be changed, although it seems >>> like this driver and its matching bindings are now unmaintained. >> >> Please use scripts/get_maintainers.pl to get a list of necessary people >> and lists to CC. It might happen, that command when run on an older >> kernel, gives you outdated entries. Therefore please be sure you base >> your patches on recent Linux kernel. >> >> Even if driver does not have updated maintainers entry, generic rules apply. > > I'm based on next-20221102, i.e. todays' next, should be recent enough. > > $ ./scripts/get_maintainer.pl -f drivers/watchdog/gpio_wdt.c > Wim Van Sebroeck <wim@linux-watchdog.org> (maintainer:WATCHDOG DEVICE > DRIVERS) > Guenter Roeck <linux@roeck-us.net> (maintainer:WATCHDOG DEVICE DRIVERS) > linux-watchdog@vger.kernel.org (open list:WATCHDOG DEVICE DRIVERS) > linux-kernel@vger.kernel.org (open list) > > Running it against the bindings file, old or new, just adds the DT > maintainers into the list, so not much help either. Hence the NOTE. Yet you did not CC all DT binding maintainers, hence my reply. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/watchdog/gpio-wdt.txt b/Documentation/devicetree/bindings/watchdog/gpio-wdt.txt deleted file mode 100644 index 198794963786b..0000000000000 --- a/Documentation/devicetree/bindings/watchdog/gpio-wdt.txt +++ /dev/null @@ -1,28 +0,0 @@ -* GPIO-controlled Watchdog - -Required Properties: -- compatible: Should contain "linux,wdt-gpio". -- gpios: From common gpio binding; gpio connection to WDT reset pin. -- hw_algo: The algorithm used by the driver. Should be one of the - following values: - - toggle: Either a high-to-low or a low-to-high transition clears - the WDT counter. The watchdog timer is disabled when GPIO is - left floating or connected to a three-state buffer. - - level: Low or high level starts counting WDT timeout, - the opposite level disables the WDT. Active level is determined - by the GPIO flags. -- hw_margin_ms: Maximum time to reset watchdog circuit (milliseconds). - -Optional Properties: -- always-running: If the watchdog timer cannot be disabled, add this flag to - have the driver keep toggling the signal without a client. It will only cease - to toggle the signal when the device is open and the timeout elapsed. - -Example: - watchdog: watchdog { - /* ADM706 */ - compatible = "linux,wdt-gpio"; - gpios = <&gpio3 9 GPIO_ACTIVE_LOW>; - hw_algo = "toggle"; - hw_margin_ms = <1600>; - }; diff --git a/Documentation/devicetree/bindings/watchdog/linux,wdt-gpio.yaml b/Documentation/devicetree/bindings/watchdog/linux,wdt-gpio.yaml new file mode 100644 index 0000000000000..6b014d60c9471 --- /dev/null +++ b/Documentation/devicetree/bindings/watchdog/linux,wdt-gpio.yaml @@ -0,0 +1,44 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/watchdog/linux,wdt-gpio.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: GPIO-controlled Watchdog + +maintainers: + - Marek Vasut <marex@denx.de> + +properties: + compatible: + const: linux,wdt-gpio + + gpios: + description: gpio connection to WDT reset pin + maxItems: 1 + + hw_algo: + description: The algorithm used by the driver. + enum: [ level, toggle ] + + hw_margin_ms: + description: Maximum time to reset watchdog circuit (milliseconds). + $ref: /schemas/types.yaml#/definitions/uint32 + +required: + - compatible + +allOf: + - $ref: "watchdog.yaml#" + +additionalProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + watchdog { + compatible = "linux,wdt-gpio"; + gpios = <&gpio3 9 GPIO_ACTIVE_LOW>; + hw_algo = "toggle"; + hw_margin_ms = <1600>; + };
Convert the gpio-wdt bindings from text to YAML ones, to permit DT validation. Signed-off-by: Marek Vasut <marex@denx.de> --- Cc: Guenter Roeck <linux@roeck-us.net> Cc: Rob Herring <robh+dt@kernel.org> Cc: Wim Van Sebroeck <wim@linux-watchdog.org> Cc: linux-watchdog@vger.kernel.org To: devicetree@vger.kernel.org --- NOTE: The Maintainer entry should likely be changed, although it seems like this driver and its matching bindings are now unmaintained. --- .../devicetree/bindings/watchdog/gpio-wdt.txt | 28 ------------ .../bindings/watchdog/linux,wdt-gpio.yaml | 44 +++++++++++++++++++ 2 files changed, 44 insertions(+), 28 deletions(-) delete mode 100644 Documentation/devicetree/bindings/watchdog/gpio-wdt.txt create mode 100644 Documentation/devicetree/bindings/watchdog/linux,wdt-gpio.yaml