[v1,1/4] dt-bindings: watchdog: mediatek,mtk-wdt: add MT7988 syscon requirement

Commit Message

Frank Wunderlich (linux) July 9, 2024, 10:13 a.m. UTC

From: Frank Wunderlich <[e-mail]>

This is needed by u-boot-driver when using OF_UPSTREAM.

Signed-off-by: Frank Wunderlich <[e-mail]>
---
 .../devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml       | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

Krzysztof Kozlowski July 13, 2024, 10:21 a.m. UTC | #1

On 09/07/2024 12:13, Frank Wunderlich wrote:
> From: Frank Wunderlich <[e-mail]>
> 
> This is needed by u-boot-driver when using OF_UPSTREAM.

Thanks for providing context. What we miss here still, is the
description of the hardware and for what this syscon is used. Why this
become system controller and before was not? Or this is just for regmap
- then it does not work that way... You cannot have whatever driver
poking all around then claim - I have crappy driver poking to every
driver without implementing proper driver model, so I add syscon to
bindings.



Best regards,
Krzysztof

Frank Wunderlich July 13, 2024, 10:47 a.m. UTC | #2

Am 13. Juli 2024 12:21:46 MESZ schrieb Krzysztof Kozlowski <[e-mail]>:
>On 09/07/2024 12:13, Frank Wunderlich wrote:
>> From: Frank Wunderlich <[e-mail]>
>> 
>> This is needed by u-boot-driver when using OF_UPSTREAM.
>
>Thanks for providing context. What we miss here still, is the
>description of the hardware and for what this syscon is used. Why this
>become system controller and before was not? Or this is just for regmap
>- then it does not work that way... You cannot have whatever driver
>poking all around then claim - I have crappy driver poking to every
>driver without implementing proper driver model, so I add syscon to
>bindings.
>
>
>
>Best regards,
>Krzysztof
>

The nodes here are linked to the ethernet-node and syscon is only needed to get the regmap...the access to it is done by ethernet driver. It does work,but maybe not the right way...
regards Frank

Patch

diff --git a/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml b/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml
index 8d2520241e37..681df2ff9f2e 100644
--- a/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml
@@ -25,7 +25,6 @@  properties:
           - mediatek,mt6735-wdt
           - mediatek,mt6795-wdt
           - mediatek,mt7986-wdt
-          - mediatek,mt7988-wdt
           - mediatek,mt8183-wdt
           - mediatek,mt8186-wdt
           - mediatek,mt8188-wdt
@@ -43,6 +42,10 @@  properties:
               - mediatek,mt8365-wdt
               - mediatek,mt8516-wdt
           - const: mediatek,mt6589-wdt
+      - items:
+          - enum:
+              - mediatek,mt7988-wdt
+          - const: syscon
 
   reg:
     maxItems: 1