| Message ID | 20241212102050.374501-1-clement.legoffic@foss.st.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] watchdog: stm32_iwdg: fix error message during driver probe | expand |
On 12/12/24 11:20 AM, Clément Le Goffic wrote: > The commit 3ab1663af6c1 ("watchdog: stm32_iwdg: Add pretimeout support") > introduces the support for the pre-timeout interrupt. > > The support for this interrupt is optional but the driver uses the > platform_get_irq() wich produces an error message during the driver > probe if we don't have any `interrupts` property in the DT. > > Use the platform_get_irq_optional() API to get rid of the error message > as this property is optional. > > Fixes: 3ab1663af6c1 ("watchdog: stm32_iwdg: Add pretimeout support") > Signed-off-by: Clément Le Goffic <clement.legoffic@foss.st.com> Reviewed-by: Marek Vasut <marex@denx.de>
On 12/12/24 02:20, Clément Le Goffic wrote: > The commit 3ab1663af6c1 ("watchdog: stm32_iwdg: Add pretimeout support") > introduces the support for the pre-timeout interrupt. > > The support for this interrupt is optional but the driver uses the > platform_get_irq() wich produces an error message during the driver > probe if we don't have any `interrupts` property in the DT. > > Use the platform_get_irq_optional() API to get rid of the error message > as this property is optional. > > Fixes: 3ab1663af6c1 ("watchdog: stm32_iwdg: Add pretimeout support") > Signed-off-by: Clément Le Goffic <clement.legoffic@foss.st.com> Reviewed-by: Guenter Roeck <linux@roeck-us.net> > --- > v1 -> v2: Change the commit message because it only prints an error > message and dont break the DT backward compatibility. > > drivers/watchdog/stm32_iwdg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/watchdog/stm32_iwdg.c b/drivers/watchdog/stm32_iwdg.c > index d700e0d49bb95..8ad06b54c5adc 100644 > --- a/drivers/watchdog/stm32_iwdg.c > +++ b/drivers/watchdog/stm32_iwdg.c > @@ -286,7 +286,7 @@ static int stm32_iwdg_irq_init(struct platform_device *pdev, > if (!wdt->data->has_early_wakeup) > return 0; > > - irq = platform_get_irq(pdev, 0); > + irq = platform_get_irq_optional(pdev, 0); > if (irq <= 0) > return 0; > > > base-commit: fac04efc5c793dccbd07e2d59af9f90b7fc0dca4 > -- > 2.34.1 > >
diff --git a/drivers/watchdog/stm32_iwdg.c b/drivers/watchdog/stm32_iwdg.c index d700e0d49bb95..8ad06b54c5adc 100644 --- a/drivers/watchdog/stm32_iwdg.c +++ b/drivers/watchdog/stm32_iwdg.c @@ -286,7 +286,7 @@ static int stm32_iwdg_irq_init(struct platform_device *pdev, if (!wdt->data->has_early_wakeup) return 0; - irq = platform_get_irq(pdev, 0); + irq = platform_get_irq_optional(pdev, 0); if (irq <= 0) return 0;
The commit 3ab1663af6c1 ("watchdog: stm32_iwdg: Add pretimeout support") introduces the support for the pre-timeout interrupt. The support for this interrupt is optional but the driver uses the platform_get_irq() wich produces an error message during the driver probe if we don't have any `interrupts` property in the DT. Use the platform_get_irq_optional() API to get rid of the error message as this property is optional. Fixes: 3ab1663af6c1 ("watchdog: stm32_iwdg: Add pretimeout support") Signed-off-by: Clément Le Goffic <clement.legoffic@foss.st.com> --- v1 -> v2: Change the commit message because it only prints an error message and dont break the DT backward compatibility. drivers/watchdog/stm32_iwdg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: fac04efc5c793dccbd07e2d59af9f90b7fc0dca4 -- 2.34.1