| Message ID | 1533040864-9026-1-git-send-email-sgruszka@redhat.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add mt76x0 driver | expand |
Stanislaw Gruszka <sgruszka@redhat.com> writes: > Add mt76x0 driver for MT7610U based USB dongles. Currently driver > support only STA mode. > > mt76x0 is based on Jakub's mt7601u driver already included > in the kernel. I would like the driver be integrated as part > of mt76 (instead of separate driver in mediatek dir like mt7601u) > to utilize mt76 code for adding support for MT76x0 PCIe devices > in further development. So what's the future for mt7601u, are we going to delete it? What's Jakub's opinion about all this? And what's the delta featurewise between mt7601u and this driver? Which one will be loaded by default? Also I noticed that mt76 is missing an entry in MAINTAINERS file? Could someone send a separate patch to add that, please?
On Aug 01, Kalle Valo wrote: > Stanislaw Gruszka <sgruszka@redhat.com> writes: > > > Add mt76x0 driver for MT7610U based USB dongles. Currently driver > > support only STA mode. > > > > mt76x0 is based on Jakub's mt7601u driver already included > > in the kernel. I would like the driver be integrated as part > > of mt76 (instead of separate driver in mediatek dir like mt7601u) > > to utilize mt76 code for adding support for MT76x0 PCIe devices > > in further development. > > So what's the future for mt7601u, are we going to delete it? What's > Jakub's opinion about all this? And what's the delta featurewise between > mt7601u and this driver? Which one will be loaded by default? I think we can integrate mt7601u in mt76 as soon as mt76x0 is merged since the code path is pretty similar. Jakub what do you think? (That was actually on my ToDo list :)) For the moment I guess both drivers can coexist since the usb_device_id lists seem different Regards, Lorenzo > > Also I noticed that mt76 is missing an entry in MAINTAINERS file? Could > someone send a separate patch to add that, please? > > -- > Kalle Valo
Lorenzo Bianconi <lorenzo.bianconi@redhat.com> writes: > On Aug 01, Kalle Valo wrote: >> Stanislaw Gruszka <sgruszka@redhat.com> writes: >> >> > Add mt76x0 driver for MT7610U based USB dongles. Currently driver >> > support only STA mode. >> > >> > mt76x0 is based on Jakub's mt7601u driver already included >> > in the kernel. I would like the driver be integrated as part >> > of mt76 (instead of separate driver in mediatek dir like mt7601u) >> > to utilize mt76 code for adding support for MT76x0 PCIe devices >> > in further development. >> >> So what's the future for mt7601u, are we going to delete it? What's >> Jakub's opinion about all this? And what's the delta featurewise between >> mt7601u and this driver? Which one will be loaded by default? > > I think we can integrate mt7601u in mt76 as soon as mt76x0 is merged since the > code path is pretty similar. Jakub what do you think? (That was actually on my > ToDo list :)) > > For the moment I guess both drivers can coexist since the > usb_device_id lists seem different Ah, I didn't realise that. I was exactly worried that if we would now have two drivers supporting same device ids, but very good if that's not the case.
On Wed, Aug 01, 2018 at 10:39:58AM +0300, Kalle Valo wrote: > Stanislaw Gruszka <sgruszka@redhat.com> writes: > > > Add mt76x0 driver for MT7610U based USB dongles. Currently driver > > support only STA mode. > > > > mt76x0 is based on Jakub's mt7601u driver already included > > in the kernel. I would like the driver be integrated as part > > of mt76 (instead of separate driver in mediatek dir like mt7601u) > > to utilize mt76 code for adding support for MT76x0 PCIe devices > > in further development. > > So what's the future for mt7601u, are we going to delete it? What's > Jakub's opinion about all this? And what's the delta featurewise between > mt7601u and this driver? Which one will be loaded by default? mt7601u is driver for different chip: MT7601. This driver if for MT7610 chip. There are lot of similarities between the drivers, but there are bunch of differences too. And in the future development of mt76x0, due to integration into mt76 and mt76x2u and adding support for PCIe chips, the differences against mt7601u will be much be bigger. > Also I noticed that mt76 is missing an entry in MAINTAINERS file? Could > someone send a separate patch to add that, please? The question is if Felix would like to be the maintainer? Otherwise who would want to do this job? I think the best option would be to get some commitment from Mediatek if that possible, maybe Sean Wang could aggree to be the maintainer ? :-) Thanks Stanislaw
On Aug 01, Stanislaw Gruszka wrote: > On Wed, Aug 01, 2018 at 10:39:58AM +0300, Kalle Valo wrote: > > Stanislaw Gruszka <sgruszka@redhat.com> writes: > > > > > Add mt76x0 driver for MT7610U based USB dongles. Currently driver > > > support only STA mode. > > > > > > mt76x0 is based on Jakub's mt7601u driver already included > > > in the kernel. I would like the driver be integrated as part > > > of mt76 (instead of separate driver in mediatek dir like mt7601u) > > > to utilize mt76 code for adding support for MT76x0 PCIe devices > > > in further development. > > > > So what's the future for mt7601u, are we going to delete it? What's > > Jakub's opinion about all this? And what's the delta featurewise between > > mt7601u and this driver? Which one will be loaded by default? > > mt7601u is driver for different chip: MT7601. This driver if for MT7610 > chip. There are lot of similarities between the drivers, but there are > bunch of differences too. And in the future development of mt76x0, due > to integration into mt76 and mt76x2u and adding support for PCIe chips, > the differences against mt7601u will be much be bigger. > > > Also I noticed that mt76 is missing an entry in MAINTAINERS file? Could > > someone send a separate patch to add that, please? > > The question is if Felix would like to be the maintainer? Otherwise who would > want to do this job? I think the best option would be to get some > commitment from Mediatek if that possible, maybe Sean Wang could aggree > to be the maintainer ? :-) Maybe add multiple maintainers? I think the best option is Felix (if he agrees) since he started the work and he has more experience/knowledge of the code Regards, Lorenzo > > Thanks > Stanislaw
Lorenzo Bianconi <lorenzo.bianconi@redhat.com> writes: > On Aug 01, Stanislaw Gruszka wrote: >> On Wed, Aug 01, 2018 at 10:39:58AM +0300, Kalle Valo wrote: >> > Stanislaw Gruszka <sgruszka@redhat.com> writes: >> > >> > > Add mt76x0 driver for MT7610U based USB dongles. Currently driver >> > > support only STA mode. >> > > >> > > mt76x0 is based on Jakub's mt7601u driver already included >> > > in the kernel. I would like the driver be integrated as part >> > > of mt76 (instead of separate driver in mediatek dir like mt7601u) >> > > to utilize mt76 code for adding support for MT76x0 PCIe devices >> > > in further development. >> > >> > So what's the future for mt7601u, are we going to delete it? What's >> > Jakub's opinion about all this? And what's the delta featurewise between >> > mt7601u and this driver? Which one will be loaded by default? >> >> mt7601u is driver for different chip: MT7601. This driver if for MT7610 >> chip. There are lot of similarities between the drivers, but there are >> bunch of differences too. And in the future development of mt76x0, due >> to integration into mt76 and mt76x2u and adding support for PCIe chips, >> the differences against mt7601u will be much be bigger. >> >> > Also I noticed that mt76 is missing an entry in MAINTAINERS file? Could >> > someone send a separate patch to add that, please? >> >> The question is if Felix would like to be the maintainer? Otherwise who would >> want to do this job? I think the best option would be to get some >> commitment from Mediatek if that possible, maybe Sean Wang could aggree >> to be the maintainer ? :-) > > Maybe add multiple maintainers? I think the best option is Felix (if he agrees) > since he started the work and he has more experience/knowledge of the code Yeah, multiple maintainers would also work. Another option is to have one maintainer and one or more reviewers: R: Designated reviewer: FullName <address@domain> These reviewers should be CCed on patches. And even better if Mediatek could actively join the development and review.