From patchwork Fri Mar 8 15:25:01 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Piotr Figiel X-Patchwork-Id: 10845049 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D3E01139A for ; Fri, 8 Mar 2019 15:25:07 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A07022E4C2 for ; Fri, 8 Mar 2019 15:25:07 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 94F352E290; Fri, 8 Mar 2019 15:25:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EEB772E4C1 for ; Fri, 8 Mar 2019 15:25:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726412AbfCHPZF (ORCPT ); Fri, 8 Mar 2019 10:25:05 -0500 Received: from mail-eopbgr100075.outbound.protection.outlook.com ([40.107.10.75]:15584 "EHLO GBR01-LO2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726171AbfCHPZF (ORCPT ); Fri, 8 Mar 2019 10:25:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=camlinlimited.onmicrosoft.com; s=selector1-camlintechnologies-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5Ui5X4HluDPXYSIiMh2B/We/mifgWIfnaS380GY7J8s=; b=W69ap3BMS7hIZnEYMsoWj/7D4qc/4qsdIOTvQ1VYu0PqpyarDNnl0PHZwk9Jb6Pm0tTIdl3wFbKYxHe+GmumbshRyAiz2T9lOjFYcsl9k3ky46OkTaDwXO/qrnLlmUgG9nztjiQSP1WiT53/dqECrA5xlc/swCpcFpwKdSBOoMw= Received: from LNXP123MB2185.GBRP123.PROD.OUTLOOK.COM (20.179.129.83) by LNXP123MB2106.GBRP123.PROD.OUTLOOK.COM (20.179.129.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1686.18; Fri, 8 Mar 2019 15:25:01 +0000 Received: from LNXP123MB2185.GBRP123.PROD.OUTLOOK.COM ([fe80::396a:e27e:d5dd:6bf0]) by LNXP123MB2185.GBRP123.PROD.OUTLOOK.COM ([fe80::396a:e27e:d5dd:6bf0%5]) with mapi id 15.20.1686.018; Fri, 8 Mar 2019 15:25:01 +0000 From: Piotr Figiel To: "linux-wireless@vger.kernel.org" , "arend.vanspriel@broadcom.com" , "kvalo@codeaurora.org" CC: "franky.lin@broadcom.com" , "hante.meuleman@broadcom.com" , "chi-hsien.lin@cypress.com" , "wright.feng@cypress.com" , "brcm80211-dev-list@cypress.com" , Pawel Lenkow , Lech Perczak , =?iso-8859-2?q?Krzysztof_D?= =?iso-8859-2?q?robi=F1ski?= , Piotr Figiel Subject: [PATCH 0/3] brcmfmac: fix race during USB disconnect Thread-Topic: [PATCH 0/3] brcmfmac: fix race during USB disconnect Thread-Index: AQHU1cMYu1K1F6tlb0+neZWsLyV6+A== Date: Fri, 8 Mar 2019 15:25:01 +0000 Message-ID: <1552058658-23250-1-git-send-email-p.figiel@camlintechnologies.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [95.143.242.242] x-clientproxiedby: DB6PR07CA0010.eurprd07.prod.outlook.com (2603:10a6:6:2d::20) To LNXP123MB2185.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:dc::19) authentication-results: spf=none (sender IP is ) smtp.mailfrom=p.figiel@camlintechnologies.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.7.4 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a3c66f16-9f75-41f8-1c6b-08d6a3da3b29 x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(2017052603328)(7153060)(7193020);SRVR:LNXP123MB2106; x-ms-traffictypediagnostic: LNXP123MB2106: x-microsoft-exchange-diagnostics: =?iso-8859-2?q?1=3BLNXP123MB2106=3B23=3A2E?= =?iso-8859-2?q?58gCVu+SMKMWGQmMr3jU1VKwqDGQjrACvfUZzxSa20B6ypVI7V3RNrkSs8AA?= =?iso-8859-2?q?iFYASlLoZTKlSDxsPaXLMrKgumbe6Qq/aZ1y5XfdYwo5b7gd27JZHl1jIksd?= =?iso-8859-2?q?4Q4umN4zSMCDg9rw+0t16q9Qc4OJnFWytSXSX9bqNo2JBo60wGD+IJqpzgO5?= =?iso-8859-2?q?ErURzlA4BION4mCDGBRULY38bswBabt81GGmVueeVXy/GvB9G+TV7uy5298/?= =?iso-8859-2?q?QtsR99DaHKTKCKDiCpjmL8QyUO9K7Z/wm1mh7u8LoM64pxJnBBzgu+Bqsa4O?= =?iso-8859-2?q?wdNgX4guTyABs0yZocAlPmM8Yshp/36giKKr5jQYCF2fXV3P5VQiQlVbxaUS?= =?iso-8859-2?q?D4zK0ncjRjiu9bfvYxfXV9HJyVlJzFDDPPoYPnOW9fqfhykZ5CdnNKqIjeUy?= =?iso-8859-2?q?vT4Q4yt/tgDirqCRbtEQ5sgnlbSN/uyDIWaqFPr/HdvcDbxVUk4a9Gofi+KU?= =?iso-8859-2?q?xoWR581JWZdx/Y9yJYU6Yn0KwHYmrRt65lTETQLsbtHyJ7o8s4wjtupx+/ur?= =?iso-8859-2?q?RzYE3MoI3/DF14p/VhM/RE1yx1v1yGG0b5SSAlfY4b/DUljhcHArIL927RXC?= =?iso-8859-2?q?GMHJHbwvnb/kt8zdx2VxSUKCoEXdz302Ivawv3iTVVsyWmOaz+ZN9G9z4L7B?= =?iso-8859-2?q?txKY8CWf/5nenwZ3PF9h644HTX0wQKLrWIZQeKm9BkVoh0Pyy4kcXYakEoc5?= =?iso-8859-2?q?UKAPE30LY3ERfLCOEKMtR8yVdAjMycM3Y314UTDI0Jz6be2woOrwcF/miiEv?= =?iso-8859-2?q?JnOCR+6RR3ygo7CMgbogoEBkgIXHF3f7TKdF6Xop+U8TAyHB9yXJ3KzDoWf3?= =?iso-8859-2?q?ULvETvWRvCRjqAxuDrWC1+7XZ7PX22zJFJohZy3AW3Ia6YUGo4cEuAvNkJYo?= =?iso-8859-2?q?dV8m6TsfgZih7X593ST3GTVs4vtSmPilc8yqpYvXyV59DlhauL1mSfyyuSOb?= =?iso-8859-2?q?ELusGDl4IvFuTPc2ih4rbOD50X+yK8mhxom1ZDpRozBoaFofimq4FBM/U0Hc?= =?iso-8859-2?q?w2xaNdQ/C0voIPGoj/WqLHeAiJJ5Iy6BIa+15T9RCtJm9rAkSpwE1BRg+VYl?= =?iso-8859-2?q?lWzBG5/m5+y26Om9Hyj5O4jMqv6A/6HRCpwJr0ka2IQCloMNoGicpUbDN2ex?= =?iso-8859-2?q?0r8INUzH2ypMnkxLmpyZR2GqDZKZEOSbJiW3pft3gEBcicKo3udWz4hjQqWA?= =?iso-8859-2?q?4lC2ZT3j1qRbCc6HtcwiHFhCQK4iQ+8QE65CK5RStz0QqCI12RubbBt8KaVj?= =?iso-8859-2?q?dxYoXQMM1VPixLiByNum4E2q9WxYu4gHc+MIi+wTQDRij2xl9L1UwGEobfgA?= =?iso-8859-2?q?rh+9+gQqHB42oBzBaMA+Hv?= x-microsoft-antispam-prvs: x-forefront-prvs: 0970508454 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(979002)(376002)(136003)(346002)(396003)(366004)(39850400004)(189003)(199004)(8676002)(305945005)(97736004)(105586002)(486006)(99286004)(81166006)(3846002)(14454004)(81156014)(6116002)(476003)(106356001)(102836004)(6506007)(66066001)(186003)(6512007)(36756003)(26005)(110136005)(54906003)(6486002)(5660300002)(52116002)(4744005)(2616005)(386003)(2906002)(53936002)(107886003)(71190400001)(71200400001)(86362001)(2201001)(50226002)(6436002)(316002)(4326008)(68736007)(14444005)(256004)(25786009)(7736002)(2501003)(8936002)(478600001)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1101;SCL:1;SRVR:LNXP123MB2106;H:LNXP123MB2185.GBRP123.PROD.OUTLOOK.COM;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: camlintechnologies.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: vUPniBz+HMkMounXRpSyBhT/BGsz57LHcw0qzktMIz+bdyXqmCj/dWi4lu4EFUW0Rm7d9CsASwM1pHLo1JCsDi3wBUhzWV5MbCI1ha5jr0Hty0+/0ImyHVmmOYlZE64GhXoKkRitt/Fz6OYmKi4S1I8OH/EUYIbBgUkXDmx97xll89WM3VFFUKkTsMDnSJkLGHHyxATGjergAfeH4Zh3S2wSIUqAZMwzQ35Ck0dWaIbxTULstwSapF0xsPsUi2fU1lF9n1vtEh7kH7zSDWTsn1MEXCGNYgMlUz4TAnF/Gms/uwrqaVOUsGQ53+Sp7dPqY0lnyLkVI65zXcc502KuaFrkogAPBmbPkG9e3bU8AES1qtYt05sgD+1pfECGzEbuzjLb6iOhcgDUdB1ONSbGjvuEhR+39+mnGuukL7+9lgM= MIME-Version: 1.0 X-OriginatorOrg: camlintechnologies.com X-MS-Exchange-CrossTenant-Network-Message-Id: a3c66f16-9f75-41f8-1c6b-08d6a3da3b29 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Mar 2019 15:25:01.4484 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: fd4b1729-b18d-46d2-9ba0-2717b852b252 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: LNXP123MB2106 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There is an issue in brcmfmac clean-up during USB disconnect which may lead to usb_hub_wq lock-up and possible memory corruption. With this series fix the race causing the issue and also do minor clean-up of brcmf_usb_free_q. Piotr Figiel (3): brcmfmac: fix race during disconnect when USB completion is in progress brcmfmac: remove pending parameter from brcmf_usb_free_q brcmfmac: remove unused variable i from brcmf_usb_free_q .../net/wireless/broadcom/brcm80211/brcmfmac/usb.c | 27 +++++++++++----------- 1 file changed, 14 insertions(+), 13 deletions(-)