From patchwork Wed Feb 13 05:05:51 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Herbert Xu X-Patchwork-Id: 10809125 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6D0F41575 for ; Wed, 13 Feb 2019 05:06:05 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 56BF42C000 for ; Wed, 13 Feb 2019 05:06:05 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 495E32C15F; Wed, 13 Feb 2019 05:06:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B6CDA2C000 for ; Wed, 13 Feb 2019 05:06:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726145AbfBMFGB (ORCPT ); Wed, 13 Feb 2019 00:06:01 -0500 Received: from orcrist.hmeau.com ([104.223.48.154]:57640 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725562AbfBMFGB (ORCPT ); Wed, 13 Feb 2019 00:06:01 -0500 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1gtmk8-00057w-Qw; Wed, 13 Feb 2019 13:05:56 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1gtmk3-00018s-Es; Wed, 13 Feb 2019 13:05:51 +0800 Date: Wed, 13 Feb 2019 13:05:51 +0800 From: Herbert Xu To: David Miller , johannes@sipsolutions.net, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, j@w1.fi, tgraf@suug.ch, johannes.berg@intel.com Subject: [PATCH 0/2] mac80211: Fix incorrect usage of rhashtable walk API Message-ID: <20190213050551.x3jffq3ipghw6g2m@gondor.apana.org.au> MIME-Version: 1.0 Content-Disposition: inline User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi: This patch fixes a number of issues with the use of the rhashtable API in mac80211. First of all it converts the use of rashtable walks over to a simple linked list. This is because an rhashtable walk is inherently unstable and not meant for uses that require stability, e.g., when you're trying to lookup an object to delete. It also fixes a potential memory leak when the rhashtable insertion fails (which can occur due to OOM). Thanks,