From patchwork Mon Jun 3 18:37:37 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 10973835 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B7DBB76 for ; Mon, 3 Jun 2019 18:38:29 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A91412858E for ; Mon, 3 Jun 2019 18:38:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9CAC72873B; Mon, 3 Jun 2019 18:38:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 496042858E for ; Mon, 3 Jun 2019 18:38:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726844AbfFCSh6 (ORCPT ); Mon, 3 Jun 2019 14:37:58 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:38736 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726656AbfFCSh5 (ORCPT ); Mon, 3 Jun 2019 14:37:57 -0400 Received: by mail-pg1-f193.google.com with SMTP id v11so8769784pgl.5 for ; Mon, 03 Jun 2019 11:37:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=YZsnBAN22tVtHFJc56q+rxbdD8fX8T8HXkSym7OyHiQ=; b=Ps1O4MtbD2rEMRtRw6yvXGSxDXrH7HjPdY7KCq/lSlW7htShDFp+u033WFVJDjOXPb OLNlYon0Wpzph3sUz2BCPyDgUNjVZMpJf1kV0lUidQnpFyFPagCNB03AVdSVyyqUvAr/ bxUU+BnIId5lrXnzJ6D/l5svsqW8IvWW9U+R8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=YZsnBAN22tVtHFJc56q+rxbdD8fX8T8HXkSym7OyHiQ=; b=Orewtg/bPGD5qi/bS8lniW9B0+QenA++dyHRPR8VdMtRSsWppXgvi2hklfIBEsX0gC PQ8acNLUc3fjPW+5CSJ4qgmuUDULLHDHt+OWblnr075t64v9fzWxyBz3wOLMLyX5fcwY yWJCS/nUhXeSyqfPCMeYAS+QX16LhHDeP3YbsHxxm2iGWgmOUAfx6E/suFil9ZvtfngX p1iTU/xWM2SNJbqTjcOnbCrgsUaoAZaNxtIHdkDj/c5mGj3hqByR0jGJNwdkDlMthK1C gm7Xh6hVq5irj7bciel0i7OM36p+fJn8EM7qthW1Zes/ZTZsVqyfXu0K5XQKBEyUcmEu Hyag== X-Gm-Message-State: APjAAAU2TmbGj7chZdl0ORjpBa/JwcN+/tguxd3L2EAnyDsFSOdUKRB8 XqgQrPC1LgVwnYlBkPeD1scHug== X-Google-Smtp-Source: APXvYqwbLiM1y3Cof2KgcMMeZ8t9NIYK+vbdXny/5bFAdCAVPmxQ/CP9Y2AV9T+xZdprrAWMKhZjdw== X-Received: by 2002:a62:764d:: with SMTP id r74mr9422273pfc.110.1559587076759; Mon, 03 Jun 2019 11:37:56 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:24fa:e766:52c9:e3b2]) by smtp.gmail.com with ESMTPSA id t2sm14808969pfh.166.2019.06.03.11.37.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Jun 2019 11:37:56 -0700 (PDT) From: Douglas Anderson To: Ulf Hansson , Kalle Valo , Adrian Hunter , Arend van Spriel Cc: brcm80211-dev-list.pdl@broadcom.com, linux-rockchip@lists.infradead.org, Double Lo , briannorris@chromium.org, linux-wireless@vger.kernel.org, Naveen Gupta , Madhan Mohan R , mka@chromium.org, Wright Feng , Chi-Hsien Lin , netdev@vger.kernel.org, brcm80211-dev-list@cypress.com, Douglas Anderson , linux-mmc@vger.kernel.org, Shawn Lin , YueHaibing , Hans de Goede , Hante Meuleman , Michael Trimarchi , Wolfram Sang , Franky Lin , "David S. Miller" , linux-kernel@vger.kernel.org, Avri Altman Subject: [PATCH v2 0/3] brcmfmac: sdio: Deal better w/ transmission errors waking from idle Date: Mon, 3 Jun 2019 11:37:37 -0700 Message-Id: <20190603183740.239031-1-dianders@chromium.org> X-Mailer: git-send-email 2.22.0.rc1.311.g5d7573a151-goog MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This series attempts to deal better with the expected transmission errors that we get when waking up (from idle) the SDIO-based WiFi on rk3288-veyron-minnie, rk3288-veyron-speedy, and rk3288-veyron-mickey. Some details about those errors can be found in , but to summarize it here: if we try to send the wakeup command to the WiFi card at the same time it has decided to wake up itself then it will behave badly on the SDIO bus. This can cause timeouts or CRC errors. When I tested on 4.19 and 4.20 these CRC errors can be seen to cause re-tuning. Since I am currently developing on 4.19 this was the original problem I attempted to solve. On mainline it turns out that you don't see the retuning errors but you see tons of spam about timeouts trying to wakeup from sleep. I tracked down the commit that was causing that and have partially reverted it here. I have no real knowledge about Broadcom WiFi, but the commit that was causing problems sounds (from the descriptioin) to be a hack commit penalizing all Broadcom WiFi users because of a bug in a Cypress SD controller. I will let others comment if this is truly the case and, if so, what the right solution should be. There wasn't a good resolution on v1 and it's been a while, so I'm sending out a v2. Other than changing patch #1 to a full revert, the only other changes here are just to the patch descriptions. Changes in v2: - A full revert, not just a partial one (Arend). ...with explicit Cc. - Updated commit message to clarify based on discussion of v1. Douglas Anderson (3): Revert "brcmfmac: disable command decode in sdio_aos" mmc: core: API for temporarily disabling auto-retuning due to errors brcmfmac: sdio: Disable auto-tuning around commands expected to fail drivers/mmc/core/core.c | 27 +++++++++++++++++-- .../broadcom/brcm80211/brcmfmac/sdio.c | 9 +++---- include/linux/mmc/core.h | 2 ++ include/linux/mmc/host.h | 1 + 4 files changed, 32 insertions(+), 7 deletions(-)