[RFC,0/4] cfg80211: updates and fixes for TID specific configuration

Message

Sergey Matyukevich April 20, 2020, 11:34 a.m. UTC

Hello Johannes, Tamizh, and all

This patch series contains several minor fixes and enhancements for TID
specific configuration functionality. The first three patches include
minor fixes and TID specific AMSDU configuration.

The last patch is somewhat controversial, so the series is marked as RFC.
The last patch simplifies current override logic. It suggests to make no
difference between 'specific peer' and 'all peers' cases and to apply
new TID configuration immediately after resetting the previous one.

Regards,
Sergey

Sergey Matyukevich (4):
  cfg80211: fix mask type in cfg80211_tid_cfg structure
  mac80211: fix variable names in TID config methods
  cfg80211: add support for TID specific AMSDU configuration
  nl80211: simplify peer specific TID configuration

 include/net/cfg80211.h       |  6 ++++--
 include/uapi/linux/nl80211.h | 20 +++++++++++---------
 net/mac80211/cfg.c           |  6 +++---
 net/mac80211/driver-ops.h    |  4 ++--
 net/wireless/nl80211.c       | 11 +++++++----
 5 files changed, 27 insertions(+), 20 deletions(-)

Comments

Johannes Berg April 24, 2020, 10:18 a.m. UTC | #1

Hi,

> This patch series contains several minor fixes and enhancements for TID
> specific configuration functionality. The first three patches include
> minor fixes and TID specific AMSDU configuration.

Looks good, though I just saw you noticed a small bug :)

> The last patch is somewhat controversial, so the series is marked as RFC.
> The last patch simplifies current override logic. It suggests to make no
> difference between 'specific peer' and 'all peers' cases and to apply
> new TID configuration immediately after resetting the previous one.

Yeah, I tend to agree.

Can you resend with the small fix?

johannes

Sergey Matyukevich April 24, 2020, 10:26 a.m. UTC | #2

> > This patch series contains several minor fixes and enhancements for TID
> > specific configuration functionality. The first three patches include
> > minor fixes and TID specific AMSDU configuration.
> 
> Looks good, though I just saw you noticed a small bug :)
> 
> > The last patch is somewhat controversial, so the series is marked as RFC.
> > The last patch simplifies current override logic. It suggests to make no
> > difference between 'specific peer' and 'all peers' cases and to apply
> > new TID configuration immediately after resetting the previous one.
> 
> Yeah, I tend to agree.
> 
> Can you resend with the small fix?

Sure, will do. Is it ok if I add a patch supporting this feature in iw tool ?
Or you would prefer to review it separately after this series lands in
mac80211-next ?

Regards,
Sergey

Johannes Berg April 24, 2020, 10:29 a.m. UTC | #3

On Fri, 2020-04-24 at 13:26 +0300, Sergey Matyukevich wrote:
> > > This patch series contains several minor fixes and enhancements for TID
> > > specific configuration functionality. The first three patches include
> > > minor fixes and TID specific AMSDU configuration.
> > 
> > Looks good, though I just saw you noticed a small bug :)
> > 
> > > The last patch is somewhat controversial, so the series is marked as RFC.
> > > The last patch simplifies current override logic. It suggests to make no
> > > difference between 'specific peer' and 'all peers' cases and to apply
> > > new TID configuration immediately after resetting the previous one.
> > 
> > Yeah, I tend to agree.
> > 
> > Can you resend with the small fix?
> 
> Sure, will do. Is it ok if I add a patch supporting this feature in iw tool ?
> Or you would prefer to review it separately after this series lands in
> mac80211-next ?

That's fine. Not sure how you could possibly send them in the same
series with git, but go ahead :)

FWIW, I will always ignore nl80211.h update patches, I do those myself,
so no need to send that.

johannes