mbox series

[RFC,v2,0/5] cfg80211: updates and fixes for TID specific configuration

Message ID 20200424112905.26770-1-sergey.matyukevich.os@quantenna.com (mailing list archive)
Headers show
Series cfg80211: updates and fixes for TID specific configuration | expand

Message

Sergey Matyukevich April 24, 2020, 11:29 a.m. UTC
Hello Johannes, Tamizh, and all

This patch series contains several minor fixes and enhancements for TID
specific configuration functionality. The first three patches include
minor fixes and TID specific AMSDU configuration.

The 4th patch is somewhat controversial, so the series is marked as RFC.
This patch simplifies current override logic. It suggests to make no
difference between 'specific peer' and 'all peers' cases and to apply
new TID configuration immediately after resetting the previous one.

The 5th patch enables access to new kernel functionality from iw tool.
Note that nl80211.h changes are not included into iw. So to make this
change work in iw , header should be updated upfront, including new
AMSDU attribute from this patch series.

Regards,
Sergey

v1 -> v2

- add policy for new AMSDU attribute
- add patch for iw with support for per-tid per-node configuration


Sergey Matyukevich (5):
  cfg80211: fix mask type in cfg80211_tid_cfg structure
  mac80211: fix variable names in TID config methods
  cfg80211: add support for TID specific AMSDU configuration
  nl80211: simplify peer specific TID configuration
  iw: add TID specific configuration command

 include/net/cfg80211.h       |  6 ++++--
 include/uapi/linux/nl80211.h | 20 +++++++++++---------
 net/mac80211/cfg.c           |  6 +++---
 net/mac80211/driver-ops.h    |  4 ++--
 net/wireless/nl80211.c       | 13 +++++++++----
 5 files changed, 29 insertions(+), 20 deletions(-)

Comments

Tamizh chelvam April 27, 2020, 5:48 p.m. UTC | #1
On 2020-04-24 16:59, Sergey Matyukevich wrote:
> Hello Johannes, Tamizh, and all
> 
> This patch series contains several minor fixes and enhancements for TID
> specific configuration functionality. The first three patches include
> minor fixes and TID specific AMSDU configuration.
> 
> The 4th patch is somewhat controversial, so the series is marked as 
> RFC.
> This patch simplifies current override logic. It suggests to make no
> difference between 'specific peer' and 'all peers' cases and to apply
> new TID configuration immediately after resetting the previous one.
> 
> The 5th patch enables access to new kernel functionality from iw tool.
> Note that nl80211.h changes are not included into iw. So to make this
> change work in iw , header should be updated upfront, including new
> AMSDU attribute from this patch series.
> 
> Regards,
> Sergey
> 
> v1 -> v2
> 
> - add policy for new AMSDU attribute
> - add patch for iw with support for per-tid per-node configuration
> 
> 
> Sergey Matyukevich (5):
>   cfg80211: fix mask type in cfg80211_tid_cfg structure
>   mac80211: fix variable names in TID config methods
>   cfg80211: add support for TID specific AMSDU configuration
>   nl80211: simplify peer specific TID configuration
Patches looks good to me
Reviewed-by: Tamizh Chelvam <tamizhr@codeaurora.org>

>   iw: add TID specific configuration command
Looks neat to me :)
Reviewed-by: Tamizh Chelvam <tamizhr@codeaurora.org>
> 
>  include/net/cfg80211.h       |  6 ++++--
>  include/uapi/linux/nl80211.h | 20 +++++++++++---------
>  net/mac80211/cfg.c           |  6 +++---
>  net/mac80211/driver-ops.h    |  4 ++--
>  net/wireless/nl80211.c       | 13 +++++++++----
>  5 files changed, 29 insertions(+), 20 deletions(-)