| Message ID | 20200715230514.26792-1-alokad@codeaurora.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | Unsolicited broadcast probe resp support | expand |
On 7/16/2020 1:05 AM, Aloka Dixit wrote: > Unsolicited broadcast probe response tranmission is used for in-band > discovery in 6GHz band (IEEE P802.11ax/D6.0 26.17.2.3.2, AP behavior for > fast passive scanning). > > v3: Rebased. Removed check for 6Ghz, drivers should add that check. I have not seen any comments in v2 so could you motivate this removal. It is a sanity check that is always needed so doing it in the nl80211 api seems the proper place. Regards, Arend
On 2020-07-16 02:35, Arend Van Spriel wrote: > On 7/16/2020 1:05 AM, Aloka Dixit wrote: >> Unsolicited broadcast probe response tranmission is used for in-band >> discovery in 6GHz band (IEEE P802.11ax/D6.0 26.17.2.3.2, AP behavior >> for >> fast passive scanning). >> >> v3: Rebased. Removed check for 6Ghz, drivers should add that check. > > I have not seen any comments in v2 so could you motivate this removal. > It is a sanity check that is always needed so doing it in the nl80211 > api seems the proper place. > > Regards, > Arend Hi Arend, I found that if any application sends NL80211_ATTR_UNSOL_BCAST_PROBE_RESP with NL80211_UNSOL_BCAST_PROBE_RESP_INT=0 (which means disable) for 2.4/5GHz, the check here resulted in AP not being brought up. Technically disabling this feature for 2.4/5GHz is not required as it is disabled by default but it should not cause issues if done so explicitly. Hence I removed the check here so that drivers can decide to use/ignore this attribute.
Unsolicited broadcast probe response tranmission is used for in-band discovery in 6GHz band (IEEE P802.11ax/D6.0 26.17.2.3.2, AP behavior for fast passive scanning). v3: Rebased. Removed check for 6Ghz, drivers should add that check. v2: Removed flag 'enabled' and changed 6GHz frequency range as per IEEE P802.11ax/D6.1. Aloka Dixit (2): nl80211: Unsolicited broadcast probe response support mac80211: Unsolicited broadcast probe response support include/net/cfg80211.h | 18 ++++++++++++++ include/net/mac80211.h | 21 ++++++++++++++++ include/uapi/linux/nl80211.h | 32 ++++++++++++++++++++++++ net/mac80211/cfg.c | 42 ++++++++++++++++++++++++++++++++ net/mac80211/ieee80211_i.h | 7 ++++++ net/mac80211/tx.c | 26 ++++++++++++++++++++ net/wireless/nl80211.c | 47 ++++++++++++++++++++++++++++++++++++ 7 files changed, 193 insertions(+)