From patchwork Fri Mar 19 16:15:08 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 12151329 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AFD6C433C1 for ; Fri, 19 Mar 2021 16:14:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 454496197D for ; Fri, 19 Mar 2021 16:14:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230403AbhCSQOS (ORCPT ); Fri, 19 Mar 2021 12:14:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49578 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229875AbhCSQNx (ORCPT ); Fri, 19 Mar 2021 12:13:53 -0400 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BFF82C06174A for ; Fri, 19 Mar 2021 09:13:52 -0700 (PDT) Received: by mail-wm1-x334.google.com with SMTP id y124-20020a1c32820000b029010c93864955so7610564wmy.5 for ; Fri, 19 Mar 2021 09:13:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=okuKe8CA+ab8LpK2nHrz2TjkjOWAoDIz/1AJJ/f6Yvo=; b=QTyb0fDoJRKKgsn4iczhJTDMWyjPLmqUR8H/WbXZQiSLWzJcfwpESYJQaR6Ys+5nWK 8aatYCX9/918qrwGnMhgwyhWx3KttUmMngd2mT1HcFJNauKXH05BOZCJSmdmxg6GZG5Y /aGVfB6SHRj4/QRNc8M7ONbG99k4AQZPfugLkzx7lxpXnNIQYZgBvKlYrLIxCcvkKOCJ 16HYWJUDyYpWbrAbs3q4ZVSnvWBTG+YOdcr2LGJjd5uHlwkP/3DG/0Xj1N5/llmAjGEd kNkpnmagf9nYMvoVvmodNNJ02QkP0Z7G5AzKyiUK5w/50tS9FlF9CQtny1rQVEvolRRu YsXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=okuKe8CA+ab8LpK2nHrz2TjkjOWAoDIz/1AJJ/f6Yvo=; b=A8s0goCyFpeRK1HMsZO5geTOinjwaZrm2MEnZXaw20Xq6JRu8svd6/+/QT5zuaeXUs V800gnzYL2Jkv28KEPolKUkjWkZJYTwNGC+9lfQCWo8uuSqak7sH3Bwm+YgBo1KLVAWD lmf7wqnZttayYakPsbYop9NGEToqwODM2udNsfB9R1Wg2gKnWiqfDDJcxdfFkCMAT8H7 xWhYhX0Tc5DQYoz5wTczgFW0UQSzSnJT71TWi2thkW5rVLCYUiFqfsT//xoAcsV35Vve pWB50ybOykkn9UlKzQL7Fvt8JuNX/z1+/eQpz5cL23neZfY2g/ttc9iLSWIypuDQr9a+ m7MQ== X-Gm-Message-State: AOAM532/V4FygvWORqZCOvrScmi9y0CxR3eIPA6zM0BsATUFGBExfQ+O MOtSs0z4w3t9v0iPcpQ0vV5sng== X-Google-Smtp-Source: ABdhPJy1Y2dYEOKmDVNMGHcDAyblJrcLCxHbyHazdlT7KEzaQgw6rBJE644J/fMuAWxUGI/bycAP9A== X-Received: by 2002:a05:600c:4f14:: with SMTP id l20mr4352720wmq.71.1616170431461; Fri, 19 Mar 2021 09:13:51 -0700 (PDT) Received: from sagittarius-a.chello.ie (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id h8sm8432495wrt.94.2021.03.19.09.13.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Mar 2021 09:13:50 -0700 (PDT) From: Bryan O'Donoghue To: kvalo@codeaurora.org, wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org Cc: bryan.odonoghue@linaro.org, shawn.guo@linaro.org, benl@squareup.com, loic.poulain@linaro.org, bjorn.andersson@linaro.org Subject: [PATCH v3 00/12] wcn36xx: Enable downstream consistent Wake on Lan Date: Fri, 19 Mar 2021 16:15:08 +0000 Message-Id: <20210319161520.3590510-1-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.30.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org V3: - Ifdefs an IPV6 specific function which will not compile unless CONFIG_IPV6 is swithced on - Kernel test robot V2: - Drops work-around for scan in progress This is not required on a tip of tree kernel - Kalle - Churn out "this patch" form commit logs - Kalle - Adds comment about packing structures to commit log patch #8 - Kalle - Moves enablement of magic-packet and GTK rekey to last patch This means that the functionality is only switched on when the full series has been applied - Kalle https://www.spinics.net/lists/linux-wireless/msg206927.html V1: This series enables Wake on WLAN for the wcn36xx. Downstream implements two competing methods for WoWLAN, only one of which is used in practice. 1. The downstream prima driver and firmware have a dedicated wowlan SMD command set, however for whatever reason, the downstream driver doesn't actually use that code path for suspend/resume. Similarly the downstream kernel will mask out the SMD interrupt when entering into suspend, so its clear the firmware assisted wowlan command is not used at all. In short, the code is implemented but not used. 2. The alternative version of wake on wlan implemented downstream does A. An RXP filter B. Frimware ipv4 ARP offload C. Frimware ipv6 namesapece offload D. GTK replay counter save/update on suspend/resume This patchset replicates method #2 since it is the only method that actually works. When replicating the functionality from downstream to upsteam I found the RXP filter step to be redundant, so I skipped that. Verified on Android/4.19 with qcom out-of-tree low-power patch on wcn3680. Verified on Debian/kvalo/master on wcn3680 and wcn3620. The Debian/upstream test doesn't include the low-power patches from qcom so the time it takes the system to wake up when pinged is longer. Test method: 1. Enable magic packet wakeup on target iw phy0 wowlan enable magic-packet iw phy0 wowlan show 2. Flush arp tables on host sudo ip -s -s neigh flush all sudo ip -6 -s -s neigh flush all 3. Suspend device echo 1 > /sys/kernel/debug/clk/debug_suspend echo mem > /sys/power/state ; cat /sys/kernel/debug/rpm_stats echo 0 > /sys/module/wcn36xx/parameters/debug_mask dmesg 4. Ping either ipv4 or ipv6 ping 192.168.0.85 ping -6 fe80::6455:44ff:fe33:2211%wlo1 In both cases using Wireshark we see the target system receive an ARP or NS6 lookup and respond, followed by the host sending a ping or ping6 and the target system coming out of suspend. Similarly watching GTK keying on the AP when the device is in suspend, we see the firmware successfully rekey and when we resume, the host picking up the rekey material with persistence of the WiFi link during suspend/resume. commit: 5336fad96e8f ("wcn36xx: Enable firmware offloaded keepalive") ensures that the link is kept alive in suspend, this additional set gives the ability to - Resolve ARP/NS6 lookups without waking the system - Rekeying in suspend - Suspending and resuming based on received datagram https://git.linaro.org/people/bryan.odonoghue/kernel.git/log/?h=ath.master-wcn36xx-fw-offload-suspend-resume Bryan O'Donoghue (12): wcn36xx: Return result of set_power_params in suspend wcn36xx: Run suspend for the first ieee80211_vif wcn36xx: Add ipv4 ARP offload support in suspend wcn36xx: Do not flush indication queue on suspend/resume wcn36xx: Add ipv6 address tracking wcn36xx: Add ipv6 namespace offload in suspend wcn36xx: Add set_rekey_data callback wcn36xx: Add GTK offload to WoWLAN path wcn36xx: Add GTK offload info to WoWLAN resume wcn36xx: Add Host suspend indication support wcn36xx: Add host resume request support wcn36xx: Enable WOWLAN flags drivers/net/wireless/ath/wcn36xx/hal.h | 20 +- drivers/net/wireless/ath/wcn36xx/main.c | 118 ++++++++- drivers/net/wireless/ath/wcn36xx/smd.c | 265 +++++++++++++++++++++ drivers/net/wireless/ath/wcn36xx/smd.h | 17 ++ drivers/net/wireless/ath/wcn36xx/wcn36xx.h | 14 ++ 5 files changed, 420 insertions(+), 14 deletions(-) Tested-by: Benjamin Li