From patchwork Mon Sep 13 13:01:31 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 12488941 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8D71C433F5 for ; Mon, 13 Sep 2021 13:02:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8A64760F9F for ; Mon, 13 Sep 2021 13:02:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236961AbhIMNDf (ORCPT ); Mon, 13 Sep 2021 09:03:35 -0400 Received: from mail-dm6nam12on2088.outbound.protection.outlook.com ([40.107.243.88]:14912 "EHLO NAM12-DM6-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S236918AbhIMNDe (ORCPT ); Mon, 13 Sep 2021 09:03:34 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hb2LvPD626wNpnO0enrp9Kar1sY9soww8jlEwX2zlztNpl3+Iu3JZR6XSG87mW3E97CS0B6cXnX3HSBbs7A3eF7/TnTtn7FmZwAM+fnr0t7cNvPU/RbaI8/4DAAztbY7aTfbKaSNnQYv56I99bq4Vo0B/o7Wf4l5jmjg3OUhn2yu5eTQRh3Uq1tjaS1xHH6N0d022tJBPtFBrIgajFYt9L1s9uN0BO1uW93VD5nNPnLrkIbxsZbNdIRtgkIjI1s12sF5ExNQoSDJp3EIWLtrseYg2JZCMdXQkutSpd3OkjVudMHELZNwVmSbLl7P4HVGv9VE/ckhVgCQAYW2mORpYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=vEasab9Ix4f7UzKncEVfA4qRm1ge3YVHkjWFEieBUvA=; b=NyJ25kp6jrBGlZKPQLsN9/o39y445ibO5/OwLaulYrIxc0JBS+m+F843VnDzjYQbL4y0JrlXTxJI4tUwvUj/FoDl4uX3GVeQhEuZNHuccQIVG82hf0ZzU6vFUvR4e2fhjkP44g4vOlS4QMCvJy8VwPJVsr0pAJoqgWdC2PoVe/BuAt9t5YPbSm+nf6vjMAvNkFcpQfsfzy12o/RYihefx4PT8eS0m0p1bdw/mP3k4/0ps1MEDuSfe6+DhUSUH+lTPJSX1qDtl0GzFvt6b8y625uor1DLOhwwS+WNYKmpf9GQyHOpM2Uiof5kvQ7sJwutpdt0+kwpdS7TVooBEiBcDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vEasab9Ix4f7UzKncEVfA4qRm1ge3YVHkjWFEieBUvA=; b=YR2QHrDBRSAJAQyArWNLKB+btOv2MdXHWSQUSWSlqeCeOo4nR0auWzfyAUlJ1T1DIdKoqKGPOmtJ2yNJCPEwBf1ec2KeRts/wMbdiHDW03AdMvTcX+QFlj+ctGKxM6i91wdNdfXvRK6tjizxXp9DjMJy4iXOeX1WMtF/PQrVFcE= Authentication-Results: driverdev.osuosl.org; dkim=none (message not signed) header.d=none;driverdev.osuosl.org; dmarc=none action=none header.from=silabs.com; Received: from SN6PR11MB2718.namprd11.prod.outlook.com (2603:10b6:805:63::18) by SN6PR11MB2894.namprd11.prod.outlook.com (2603:10b6:805:d7::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.17; Mon, 13 Sep 2021 13:02:17 +0000 Received: from SN6PR11MB2718.namprd11.prod.outlook.com ([fe80::7050:a0a:415:2ccd]) by SN6PR11MB2718.namprd11.prod.outlook.com ([fe80::7050:a0a:415:2ccd%7]) with mapi id 15.20.4500.017; Mon, 13 Sep 2021 13:02:16 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH v3 00/32] staging/wfx: usual maintenance Date: Mon, 13 Sep 2021 15:01:31 +0200 Message-Id: <20210913130203.1903622-1-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.33.0 X-ClientProxiedBy: PR2P264CA0021.FRAP264.PROD.OUTLOOK.COM (2603:10a6:101::33) To SN6PR11MB2718.namprd11.prod.outlook.com (2603:10b6:805:63::18) MIME-Version: 1.0 Received: from pc-42.silabs.com (37.71.187.125) by PR2P264CA0021.FRAP264.PROD.OUTLOOK.COM (2603:10a6:101::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Mon, 13 Sep 2021 13:02:15 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 64f06eda-6147-4190-85be-08d976b6b655 X-MS-TrafficTypeDiagnostic: SN6PR11MB2894: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rhaQpP2iwXLmp7jS3bIbqehf1F3mXhlQKL7yRNabIgLQGiVVZhurKy58yB4cfaLpMu8DjW69Cl16c9s8Vg/ALhmH8ti1CCJYXZLref0CfQg5wXZdRLm/eCETN6rKe/u83w1psDbH+JP0OlpzxSulrmSmnvv2ifzglDtc005psUBYQIfhwpKb3JDDN2Cw7XDWvjZ8vZY0Rs0+dFEvUTwx1Sebe4LfV2dr55Y+gAYqHVwrnvBS7P/60yDUOmUR3xwxzl2ymB4Mi1KmG4rVcTSNAHGM1oQvaT89sNoPbjUdyqwIv0NVMWa4xNTDjHrjs31bWvdgqB43Cyg/7Cz9Y44/RQoKA9HwfcmubR16uWBYjEB/pvq2bq/TsJdSlcei4MOo8gRNfJdvzYmtI5hyvSoBA11E/APMpvNDgxplQ1x5BRVdESyLsBMru6YvT9ZfD6nexlr7lKJRy3Fnu19W6XxmtX6nwxQL8LrRWdGrMM1DzAXJgdRxnZEXDUsCYqVvD7hX2xR0X5cjhWkHlc6S+UTM7JPdE6Mz+Fpq4hg74h1c8xMKgTW+C5BGV9SFKssV4y9HgkmaD8pm0ryljl2RTLOaG8gxzTZkGH/HzIKfuJXQIcKXXWt2FHp2B0rmAkkZVEHIGY1iDZ6EP25QvR+TFzxED/cLhEi/lDPJXuDvDmB2fqLiF+H35ss9dw4I7Snk5C80E4Kr+mbGmJa+xPo519danBah6kLRsEGfPLBeBh42BpPCMA1j5fyEsHnwlXFQieMSBIUt5j120HThnQgV/0ewTBkYT3zqQjrNDd4Oj8nU22g= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR11MB2718.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(366004)(136003)(39850400004)(346002)(376002)(5660300002)(966005)(26005)(8936002)(6486002)(38350700002)(38100700002)(66946007)(7696005)(186003)(316002)(1076003)(8676002)(956004)(478600001)(2616005)(2906002)(52116002)(4326008)(36756003)(6666004)(54906003)(83380400001)(107886003)(66476007)(66556008)(86362001)(66574015);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?vlrZyX0eeNSNsA7gINZtclaLrI74?= =?utf-8?q?jtwiDWQNjc6xGu/lL7sN/JNH5XL9KwUCNgY/ybmYVTtUw0pWe3xAhSNclB2LQNGnC?= =?utf-8?q?zaebqOjQkwysit2p6YUcWe4HNqngt3vGLffAV15bd46rWVPU09SII+6I3QjNy8/Y/?= =?utf-8?q?8iyrcY1GSS6mdtngG/C2vSc8k5WCbO8/N5/wGz4nNPH0LZ7gxpmlFGzuyS63Zph5i?= =?utf-8?q?LYBhBo/0qm4tdgOdXU3V5+K95OiLDCz7IFDKkdwp2MlCLn4jzFhadblx0zWr60iIe?= =?utf-8?q?pU8NH15CSVqJkhy9zL4Z8vEg5TACmiC0wbfdR4TDbbTPNMQ/w8/Yc6N+vUH7EpNAg?= =?utf-8?q?50/nyAbqF+0QpxoajSRJAFCxHcYf3XVgz9SL5GOjsjAZ269FPdmajJlNH80a41ZTh?= =?utf-8?q?dI6pqTKOm7vVtYWqL4a8S5K3mF3Ek+zstXcDrJQIGBpkVZHjFIxUJzvg0DbWlRTMU?= =?utf-8?q?wPgs6FDZ8ogzVjLwTjEdUiIMwXE7hqS+Glj2RSE4jkrPzT7Tj7tEu52fNgx7GtZpm?= =?utf-8?q?jyjM39c1LpWUAtAR7YtuX7FCvMV5c4u1yVajP3i0m+G+IfAkJ3724nJVdlvdDK61G?= =?utf-8?q?vs/B7rhaiJsoRlDtCcV59IJiFswCudrbI+UWa4+GP835zye0kfAmvW50kwL6Esh9e?= =?utf-8?q?50XLFYkvS2Ae4ip2S6nufKL1KfPyDlR598VWMv7iwMatykqCbT3ZPldwG5gaP9+yR?= =?utf-8?q?Q3JoG6BLzeJILCpy7snx8CQndclM5wr7BuATW4nrrd+D+lVYOTHfBgz9Dr4mbbrvb?= =?utf-8?q?5HfL9sdptMHhG+Urm6Sl1PVk76/hIEjb4L/UXne6u7YHRepLiWXUyRlMlVWbzbyWh?= =?utf-8?q?cRljN8cXIIaWE6jy8HKgWHdW0uu5UUGi16cZkqLR4uW9xsA97hl/2Xi/GHqT/WHFB?= =?utf-8?q?IS+IC0nW9tAqgfOTWpCDXopOCzOzbEgYY2HFN7JbC+PzTDXUkh/NKt4HRgRD90Rds?= =?utf-8?q?k9nB6ySuMqqs5Dad9SiZYv070iKlNcMTGB/QasxAKv9Im7dH5Ix2WsbX5KVu3SKej?= =?utf-8?q?5zSPjo8aJ3OV47QU5JBBBeHGAJaf/KcNuZZcMJYb09b01wSTtCAL2AI0KpDW0Kq0W?= =?utf-8?q?xoIEfaa+4tleFniJGVJ6AtTun6NVGCZlWfTwB0x9vJm+EZ+ceHGV2lQqgRTtalsfX?= =?utf-8?q?jloe4JebgDsVhbv8YmJa4YKRBRqOilY9v8vcVMwmfhoCmkEuD6dwtposuiXEkmdzA?= =?utf-8?q?g4ZuCHDFc8mw/pJj0FOi+VNkNCDzh0A1ve0yIFUXxp9QcTzIsmPNHyEsWr1UpRM11?= =?utf-8?q?9wCDtglKa0P+cuSy?= X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: 64f06eda-6147-4190-85be-08d976b6b655 X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2718.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2021 13:02:16.7397 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rYbpXFCXKdDamnpjmn1DaPuQXoD6oiuv+gB0LIZyLuaTC7+hU4cmB97LjCs3bgh2MtaIBXKXFGt2QoSlPx1+BQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2894 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller Hi, The following PR contains now usual maintenance for the wfx driver. I have more-or-less sorted the patches by importance: - the first ones and the two last ones are fixes for a few corner-cases reported by users - the patches 9 and 10 add support for CSA and TDLS - then the end of the series is mostly cosmetics and nitpicking I have wait longer than I initially wanted before to send this PR. It is because didn't want to conflict with the PR currently in review[1] to relocate this driver into the main tree. However, this PR started to be very large and nothing seems to move on main-tree side so I decided to not wait longer. Kalle, I am going to send a new version of [1] as soon as this PR will be accepted. I hope you will have time to review it one day :-). [1] https://lore.kernel.org/all/20210315132501.441681-1-Jerome.Pouiller@silabs.com/ v3: - Fix patch 11 and drop patch 33 (Dan) - Fix one missing C99 comment - Drop useless WARN_ON() (Dan) v2: - Add patches 32 and 33 to solve a possible race when device is misconfigured - Fix C99 comments (Kari) - Replace "API 3.8" by "firmware API 3.8" (Kari) - Fix wording "aligned with first argument" instead of "aligned with opening parenthesis" Jérôme Pouiller (32): staging: wfx: use abbreviated message for "incorrect sequence" staging: wfx: do not send CAB while scanning staging: wfx: ignore PS when STA/AP share same channel staging: wfx: wait for SCAN_CMPL after a SCAN_STOP staging: wfx: avoid possible lock-up during scan staging: wfx: drop unused argument from hif_scan() staging: wfx: fix atomic accesses in wfx_tx_queue_empty() staging: wfx: take advantage of wfx_tx_queue_empty() staging: wfx: declare support for TDLS staging: wfx: fix support for CSA staging: wfx: relax the PDS existence constraint staging: wfx: simplify API coherency check staging: wfx: update with the firmware API 3.8 staging: wfx: uniformize counter names staging: wfx: fix misleading 'rate_id' usage staging: wfx: declare variables at beginning of functions staging: wfx: simplify hif_join() staging: wfx: reorder function for slightly better eye candy staging: wfx: fix error names staging: wfx: apply naming rules in hif_tx_mib.c staging: wfx: remove unused definition staging: wfx: remove useless debug statement staging: wfx: fix space after cast operator staging: wfx: remove references to WFxxx in comments staging: wfx: update files descriptions staging: wfx: reformat comment staging: wfx: avoid c99 comments staging: wfx: fix comments styles staging: wfx: remove useless comments after #endif staging: wfx: explain the purpose of wfx_send_pds() staging: wfx: indent functions arguments staging: wfx: ensure IRQ is ready before enabling it drivers/staging/wfx/bh.c | 37 ++++--- drivers/staging/wfx/bh.h | 4 +- drivers/staging/wfx/bus_sdio.c | 29 +++--- drivers/staging/wfx/bus_spi.c | 22 ++--- drivers/staging/wfx/data_rx.c | 7 +- drivers/staging/wfx/data_rx.h | 4 +- drivers/staging/wfx/data_tx.c | 87 +++++++++-------- drivers/staging/wfx/data_tx.h | 6 +- drivers/staging/wfx/debug.c | 54 ++++++----- drivers/staging/wfx/debug.h | 2 +- drivers/staging/wfx/fwio.c | 26 ++--- drivers/staging/wfx/fwio.h | 2 +- drivers/staging/wfx/hif_api_cmd.h | 14 +-- drivers/staging/wfx/hif_api_general.h | 25 ++--- drivers/staging/wfx/hif_api_mib.h | 85 ++++++++-------- drivers/staging/wfx/hif_rx.c | 23 ++--- drivers/staging/wfx/hif_rx.h | 3 +- drivers/staging/wfx/hif_tx.c | 60 +++++------- drivers/staging/wfx/hif_tx.h | 6 +- drivers/staging/wfx/hif_tx_mib.c | 14 +-- drivers/staging/wfx/hif_tx_mib.h | 2 +- drivers/staging/wfx/hwio.c | 6 +- drivers/staging/wfx/hwio.h | 20 ++-- drivers/staging/wfx/key.c | 30 +++--- drivers/staging/wfx/key.h | 4 +- drivers/staging/wfx/main.c | 37 +++++-- drivers/staging/wfx/main.h | 3 +- drivers/staging/wfx/queue.c | 43 ++++---- drivers/staging/wfx/queue.h | 6 +- drivers/staging/wfx/scan.c | 55 +++++++---- drivers/staging/wfx/scan.h | 4 +- drivers/staging/wfx/sta.c | 135 +++++++++++++++----------- drivers/staging/wfx/sta.h | 8 +- drivers/staging/wfx/traces.h | 2 +- drivers/staging/wfx/wfx.h | 14 ++- 35 files changed, 470 insertions(+), 409 deletions(-)