mbox series

[00/31] staging/wfx: apply suggestions from the linux-wireless review

Message ID 20220113085524.1110708-1-Jerome.Pouiller@silabs.com (mailing list archive)
Headers show
Series staging/wfx: apply suggestions from the linux-wireless review | expand

Message

Jérôme Pouiller Jan. 13, 2022, 8:54 a.m. UTC 
From: Jérôme Pouiller <jerome.pouiller@silabs.com>

Most of the patches of this series are the result of the review process on
linux-wireless[1].

The patches 1 to 25 are cosmetics. The last 3 patches are not fully backward
compatible. I believe it is not a problem in the staging area.

[1]: https://lore.kernel.org/netdev/20220111171424.862764-24-Jerome.Pouiller@silabs.com/T/


Jérôme Pouiller (31):
  staging: wfx: fix Makefile and Kconfig licenses
  staging: wfx: fix HIF API license
  staging: wfx: fix missing headers
  staging: wfx: fix comment correctness
  staging: wfx: explain uncommon Makefile statement
  staging: wfx: remove unnecessary braces
  staging: wfx: remove useless #ifdef
  staging: wfx: use IS_ALIGNED()
  staging: wfx: replace magic value by WFX_HIF_BUFFER_SIZE
  stagigg: wfx: replace magic number by HIF_ID_IS_INDICATION
  staging: wfx: preserve endianness of struct hif_ind_startup
  staging: wfx: fix ambiguous function name
  staging: wfx: fix ambiguous function name
  staging: wfx: prefix functions from hif_*.h with wfx_
  staging: wfx: prefix functions from hwio.h with wfx_
  staging: wfx: prefix functions from debug.h with wfx_
  staging: wfx: prefix tx_policy_is_equal() with wfx_
  staging: wfx: prefix structs hif_* with wfx_
  staging: wfx: prefix structs tx_policy and hwbus_ops with wfx_
  staging: wfx: reformat code on 100 columns
  staging: wfx: reformat comments on 100 columns
  staging: wfx: fix structs alignments
  staging: wfx: use explicit labels for errors
  staging: wfx: replace compiletime_assert() by BUILD_BUG_ON_MSG()
  staging: wfx: do not display functions names in logs
  staging: wfx: remove force_ps_timeout
  staging: wfx: map 'compatible' attribute with board name
  staging: wfx: fix firmware location
  staging: wfx: drop legacy compatible values
  staging: wfx: rename "config-file" DT attribute
  staging: wfx: do not probe the device if not in the DT

 .../bindings/net/wireless/silabs,wfx.yaml     |  23 +-
 drivers/staging/wfx/Kconfig                   |   5 +
 drivers/staging/wfx/Makefile                  |   3 +-
 drivers/staging/wfx/bh.c                      |  67 +++---
 drivers/staging/wfx/bh.h                      |   1 +
 drivers/staging/wfx/bus.h                     |   8 +-
 drivers/staging/wfx/bus_sdio.c                |  97 +++++----
 drivers/staging/wfx/bus_spi.c                 |  98 +++++----
 drivers/staging/wfx/data_rx.c                 |  10 +-
 drivers/staging/wfx/data_rx.h                 |   5 +-
 drivers/staging/wfx/data_tx.c                 | 144 ++++++-------
 drivers/staging/wfx/data_tx.h                 |  20 +-
 drivers/staging/wfx/debug.c                   |  80 ++-----
 drivers/staging/wfx/debug.h                   |   6 +-
 drivers/staging/wfx/fwio.c                    | 113 +++++-----
 drivers/staging/wfx/hif_api_cmd.h             | 150 ++++++-------
 drivers/staging/wfx/hif_api_general.h         |  64 +++---
 drivers/staging/wfx/hif_api_mib.h             |  68 +++---
 drivers/staging/wfx/hif_rx.c                  | 168 +++++++--------
 drivers/staging/wfx/hif_tx.c                  | 194 ++++++++---------
 drivers/staging/wfx/hif_tx.h                  |  67 +++---
 drivers/staging/wfx/hif_tx_mib.c              | 202 ++++++++----------
 drivers/staging/wfx/hif_tx_mib.h              |  67 +++---
 drivers/staging/wfx/hwio.c                    | 171 +++++++--------
 drivers/staging/wfx/hwio.h                    |  35 +--
 drivers/staging/wfx/key.c                     |  84 +++-----
 drivers/staging/wfx/key.h                     |   5 +-
 drivers/staging/wfx/main.c                    | 183 +++++++---------
 drivers/staging/wfx/main.h                    |  12 +-
 drivers/staging/wfx/queue.c                   |  51 ++---
 drivers/staging/wfx/queue.h                   |  13 +-
 drivers/staging/wfx/scan.c                    |  27 +--
 drivers/staging/wfx/sta.c                     | 194 +++++++----------
 drivers/staging/wfx/sta.h                     |  22 +-
 drivers/staging/wfx/traces.h                  |  33 ++-
 drivers/staging/wfx/wfx.h                     |  94 ++++----
 36 files changed, 1171 insertions(+), 1413 deletions(-)