From patchwork Thu Jan 13 08:54:53 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 12712443 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F7ABC433EF for ; Thu, 13 Jan 2022 08:55:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231421AbiAMIzr (ORCPT ); Thu, 13 Jan 2022 03:55:47 -0500 Received: from mail-co1nam11on2053.outbound.protection.outlook.com ([40.107.220.53]:51425 "EHLO NAM11-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S230469AbiAMIzn (ORCPT ); Thu, 13 Jan 2022 03:55:43 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CJZmzSXFih5otQcyta3uikpOxhSMRNZKdF1jN3MMzDYeF7H929z5U8HTfoHjFJUlRCS+Iub8u1rNXwkb0dXHmCutlLEY/7b0+abK1airlmZCCAbWOpeyU1dukT2mUduvkktNuoYvUKd7+ZtaQ9HBj7LI4fw+apFejq69rMw6CDrwJeoVx3gJv6dADkbX2MPrAr5NdWlorksWNemtG4NAsrBWbRYVz+3CLnbNHTTeAcRBJC9IuZz3q8rORpuHzj4zFQFaLsNaD4/qv/pT5xL6oZg/Z5UYXhqoP2ZquVsoRYz9c/9Fu4jo8u49tcsuXvHh4Jfw8/xr2uekAbikuccHlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=obJleljcDCi1duIjWGP6FLtg1njg46Qb2c/qk7JDLQQ=; b=PP4oHAQR0IjcW93ZiPNGNpP6lF838OK+EAjK9BOZs4ODdn7uSxhGTgEx9yLmj6FLQa0i2tqCbQiA6hlM9A9LsOA1DjvOqQpRhLOc0zrV5Jz4sMZSEDKzouuzkH2CVx5MSnsCdlXlkAH/vmj2ngWg3uescRI34T1PKRyYz1wUil7hqQrA+X1Fj/lRLRm0WeZCGod5nd70clJGMEMQtqnIWAhGtvouRsskr6rATZzAQHFKMrg6RJImvR43dwvwtdXmCC0kp+uU1r/fuNvXZrNPvjfrlToN6X20uuWHp9zyW9SPrIAMQqn7RKivyQPK/58/ZYOivZWQPtqB8qJz+7Z9wg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=obJleljcDCi1duIjWGP6FLtg1njg46Qb2c/qk7JDLQQ=; b=JQBt95km0SRhPTxU5yZvmcpWigK0f3JyUC9s+7WTcZE737OwlndPUh0PjfkrTv9GWwY+wkNtVOENQhAQ6EgnHpJVt0Nvrj9GyCOllTeKPlaSTHTCkSx8VKPsy3ZahcjAV1gnDHk8/7T/YwxfU1f3EpbmajC+L+PPy9VSFSMiv7c= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=silabs.com; Received: from PH0PR11MB5657.namprd11.prod.outlook.com (2603:10b6:510:ee::19) by BY5PR11MB4040.namprd11.prod.outlook.com (2603:10b6:a03:186::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.10; Thu, 13 Jan 2022 08:55:38 +0000 Received: from PH0PR11MB5657.namprd11.prod.outlook.com ([fe80::d031:da9e:71a:73e4]) by PH0PR11MB5657.namprd11.prod.outlook.com ([fe80::d031:da9e:71a:73e4%5]) with mapi id 15.20.4888.011; Thu, 13 Jan 2022 08:55:38 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH 00/31] staging/wfx: apply suggestions from the linux-wireless review Date: Thu, 13 Jan 2022 09:54:53 +0100 Message-Id: <20220113085524.1110708-1-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.34.1 X-ClientProxiedBy: SA0PR11CA0117.namprd11.prod.outlook.com (2603:10b6:806:d1::32) To PH0PR11MB5657.namprd11.prod.outlook.com (2603:10b6:510:ee::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a734efd0-011a-47fd-2bc2-08d9d672782c X-MS-TrafficTypeDiagnostic: BY5PR11MB4040:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UsDyi/i2dbo/ir3bfDg9K031f5WTCNpP4fRyafEJ8wIG8CxYyuxF7Xs8X+uoThs+X2zB9j/Syty7WN1HIKurUUWexlfDKMbvECU/g73W7rfxx4T6OJfcaAxr0noD4vNUluQq0r9PD4IFt1GDzfaYkt8kuKes5LZOYr7XUYOZYGvaRRsIN4ixOFC088zTySVG45cz7JH0Ha9/ReCwy05lvSoPB5KT5/LpF/EcGmOJS8LAXuonYckrzyhHAV4uRQrbP916TPWaxgXxHgrmNgBjvWgtzNT/hEOiLBqCrXGQoIwNvWZEU8xHkUfA6lZfeVA6F69Xpn8KFTY6Z29kSoVE0sDF2WD87xOqHREvsjaVl7OniicjBxcIGj1jAr6A1Ykztz+lr4FILWKmZFvQrMG4ggk9ToTRJcrWYRH3szrGOyAleb+BUTKGI8GPfJ8JFi7akvDbFQxvGHS4UtA2+CTyW059Qd5pXw96GHWyC44CZ+utllOJuuOFGGvdDc4/F0s7ZlTVQoUKBezwqq0teqn1Ub/3qWx9s6wmXLZZ5qzNSiHpkHeGI+3pHRXk7M7Xv6738wLT4pXctrlbFn2DxorUhLs31w6PoQq55ZAjcyGPSAEyP+q1NHntqJ5+BMtuqJUDDUWsNZV0e2YX5Z6lpGecgSAjmq5ei/E/n4mnC5pp1QnBMATh0ieo/OJsr/wOMaR4TWBwRuBPCj8krgyzBYht4sUjvJr1KsIBcmBphGk4ve8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5657.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6506007)(508600001)(186003)(966005)(38100700002)(4326008)(8936002)(6512007)(6666004)(66946007)(83380400001)(1076003)(2616005)(54906003)(86362001)(66556008)(2906002)(66476007)(316002)(52116002)(36756003)(5660300002)(8676002)(6486002)(107886003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?ryl86WOuZtDMqflISwJXXfMrlK1i?= =?utf-8?q?CGwXLDn+k4kFmDoNsWk8MKxgwZf7C3XX7LyTpEvaNVtHCIbzL50pUICYqB0BOjDcB?= =?utf-8?q?boNgE8w7JjxFizA0h5YxwUdy4YLmoOJlnmPabs0KSIOHCRgOOz3hrOooHVBe7I6kn?= =?utf-8?q?2/oJiXO5t2emE6FDGQRAb/FhlhFya5RsQ5/dAnB3FPfUbeOs1kVIwIFNiiJlIHKE9?= =?utf-8?q?sobkOrpQRgsmvhCElVliQl+hDPyi3BLlGcWl4t0arR5TkRu4gy/jDo/YHTd4tIGyU?= =?utf-8?q?j1RrBIlNOfUs9krNOev2IzyQcxOA17/SJsXUBlChLdjEfcr/8lzHwQF2KHuQ5YyxO?= =?utf-8?q?lKrsNCmJKsQNpb8Erv9PuS21aHOmmqhmybUPZ2+I4pZzv4JTQy+vjTLQhe/dLwukM?= =?utf-8?q?ltsWDpaoREw5+oiSryw0VtbVXb2Egwui8tx6keoatSB+HLwhl0JOsSKL7JHZlOtxJ?= =?utf-8?q?v/EgBImneOwaZ9JNe+XjRsOQ+WTdPgBXPnsRI2V+sBfRNQdJexCVPgYaptPej19xU?= =?utf-8?q?M0hy9YoMYtGNP7sp8I7PnHK1PWTxEcLHLhhvXF28XHRvZeEHgjzKVbMhpmrLyMxzr?= =?utf-8?q?232L3KPRadGMYzS7w3rSKVUxczAJmdK233j9XbU3L91WeXNzn5SovxDgsdx/PTxtP?= =?utf-8?q?TyIBw8/hKF63+DIjS7L37UACC0XWgBaUbAwBzWjVwENEbZEWoicvPiTPEtnD1+LVm?= =?utf-8?q?bF8iM2mvpeZEw5Ujb3VyGj40METue+HMvqoGMny4EzEGDWpYXcbn/o9qNjormgVTF?= =?utf-8?q?Scaqcs2f8K0FmC72VTa674ibDVdMDgLChWHeHwvVkAcTFHBU70mB7In1O4LrpQBco?= =?utf-8?q?iE+FwwXdHurUkB8+3Jp/RC1b7d24xTKpMpEIm1zbYWf2/WrotmNJ38ScE3XC22h4T?= =?utf-8?q?gU8C0Ol02z0JMxpMJG7kwkGJGExKUFK8gmZYT1bgLaVjDZky14zkOZ4NMxCq9ogtu?= =?utf-8?q?cgWH8kr1VT/YDSOf5GRiKWFGXCi6Nnyt4NuB4wt9txRHbRNI/k3ClfdBE0TzEyeMC?= =?utf-8?q?6wsOv2wNIErS0Dnzy4VX8KMcRYfI7GTeZ2bmh+xJiyZx+OjfRCENdVcpqsXboLV1w?= =?utf-8?q?lEYUiSESOQUbBbAH2CxeaCI/2Z1zlnu3xRSu4S1afE7YbF0EiU9PRy+QiYFOJ9UvF?= =?utf-8?q?o32LKroE8URiQAroqY5ED3w0p9UlRAyvy7WFDkgLmVDd71QqOgiTSyuLXW8D4zZLz?= =?utf-8?q?NuGHc95Yik4q50vviJDb2jmlB0XCM77m+GN0k029/oP6DVeKGsDzLAfJgj4FvDtnw?= =?utf-8?q?CYNIMW/KQ99eEy+6CQkjt25yO4ThrfGjenUaqyQQvYpXcDt+nHVyf1fTiQBoY36+W?= =?utf-8?q?WF1/tB/rgDHstgLwki09JROaW2Wko5kOFwsxrvauQF0wbVF1mVPVjg1g3HhrQDvCh?= =?utf-8?q?pla6whJt8e0e5uFsPnNVDHgGfrvW0KAdwq7S9fH8DpfhpE9gvWY5W6aqHEfMgyNyp?= =?utf-8?q?N3O6vzmgyj0WFC7dzrRhgxyM10OSVV1LbjrhCxEfqIBrM4YrtBrUekh4n2zz5Nr2W?= =?utf-8?q?KDu4xDdYPexbXh6XY1GRY/HrLKIqpgEDEWuIlTjh7KJQ1g+gQMWVGxEki0aaX0Plb?= =?utf-8?q?9POlN3FC/CekAsuIYGlZzqx7pU7YkCDCl0NdBRUkD/86J9Buc54Yy4=3D?= X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: a734efd0-011a-47fd-2bc2-08d9d672782c X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5657.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2022 08:55:38.3849 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sOb6NvZpSXKLTojMZDGvD+eYUYtRJ27R4KLaeyeu6POaVUoijli9LG2ojn78EEMIBR4GhOsctVtZuZbEt+/PrA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4040 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller Most of the patches of this series are the result of the review process on linux-wireless[1]. The patches 1 to 25 are cosmetics. The last 3 patches are not fully backward compatible. I believe it is not a problem in the staging area. [1]: https://lore.kernel.org/netdev/20220111171424.862764-24-Jerome.Pouiller@silabs.com/T/ Jérôme Pouiller (31): staging: wfx: fix Makefile and Kconfig licenses staging: wfx: fix HIF API license staging: wfx: fix missing headers staging: wfx: fix comment correctness staging: wfx: explain uncommon Makefile statement staging: wfx: remove unnecessary braces staging: wfx: remove useless #ifdef staging: wfx: use IS_ALIGNED() staging: wfx: replace magic value by WFX_HIF_BUFFER_SIZE stagigg: wfx: replace magic number by HIF_ID_IS_INDICATION staging: wfx: preserve endianness of struct hif_ind_startup staging: wfx: fix ambiguous function name staging: wfx: fix ambiguous function name staging: wfx: prefix functions from hif_*.h with wfx_ staging: wfx: prefix functions from hwio.h with wfx_ staging: wfx: prefix functions from debug.h with wfx_ staging: wfx: prefix tx_policy_is_equal() with wfx_ staging: wfx: prefix structs hif_* with wfx_ staging: wfx: prefix structs tx_policy and hwbus_ops with wfx_ staging: wfx: reformat code on 100 columns staging: wfx: reformat comments on 100 columns staging: wfx: fix structs alignments staging: wfx: use explicit labels for errors staging: wfx: replace compiletime_assert() by BUILD_BUG_ON_MSG() staging: wfx: do not display functions names in logs staging: wfx: remove force_ps_timeout staging: wfx: map 'compatible' attribute with board name staging: wfx: fix firmware location staging: wfx: drop legacy compatible values staging: wfx: rename "config-file" DT attribute staging: wfx: do not probe the device if not in the DT .../bindings/net/wireless/silabs,wfx.yaml | 23 +- drivers/staging/wfx/Kconfig | 5 + drivers/staging/wfx/Makefile | 3 +- drivers/staging/wfx/bh.c | 67 +++--- drivers/staging/wfx/bh.h | 1 + drivers/staging/wfx/bus.h | 8 +- drivers/staging/wfx/bus_sdio.c | 97 +++++---- drivers/staging/wfx/bus_spi.c | 98 +++++---- drivers/staging/wfx/data_rx.c | 10 +- drivers/staging/wfx/data_rx.h | 5 +- drivers/staging/wfx/data_tx.c | 144 ++++++------- drivers/staging/wfx/data_tx.h | 20 +- drivers/staging/wfx/debug.c | 80 ++----- drivers/staging/wfx/debug.h | 6 +- drivers/staging/wfx/fwio.c | 113 +++++----- drivers/staging/wfx/hif_api_cmd.h | 150 ++++++------- drivers/staging/wfx/hif_api_general.h | 64 +++--- drivers/staging/wfx/hif_api_mib.h | 68 +++--- drivers/staging/wfx/hif_rx.c | 168 +++++++-------- drivers/staging/wfx/hif_tx.c | 194 ++++++++--------- drivers/staging/wfx/hif_tx.h | 67 +++--- drivers/staging/wfx/hif_tx_mib.c | 202 ++++++++---------- drivers/staging/wfx/hif_tx_mib.h | 67 +++--- drivers/staging/wfx/hwio.c | 171 +++++++-------- drivers/staging/wfx/hwio.h | 35 +-- drivers/staging/wfx/key.c | 84 +++----- drivers/staging/wfx/key.h | 5 +- drivers/staging/wfx/main.c | 183 +++++++--------- drivers/staging/wfx/main.h | 12 +- drivers/staging/wfx/queue.c | 51 ++--- drivers/staging/wfx/queue.h | 13 +- drivers/staging/wfx/scan.c | 27 +-- drivers/staging/wfx/sta.c | 194 +++++++---------- drivers/staging/wfx/sta.h | 22 +- drivers/staging/wfx/traces.h | 33 ++- drivers/staging/wfx/wfx.h | 94 ++++---- 36 files changed, 1171 insertions(+), 1413 deletions(-)