mbox series

[00/12] wifi: ath12k: Add single wiphy support

Message ID 20240111045045.28377-1-quic_srirrama@quicinc.com (mailing list archive)
Headers show
Series wifi: ath12k: Add single wiphy support | expand

Message

Sriram R Jan. 11, 2024, 4:50 a.m. UTC
With the introduction of Multi Link Operation (MLO) support in
IEEE802.11be, each EHT AP/non AP interface is capable of
operating with multiple radio links.

cfg80211/mac80211 expects drivers to abstract the communication
between such Multi Link HW and mac80211/cfg80211 since it depends
on different driver/HW implementation. Hence the single wiphy
abstraction with changes in datastructures were introduced in
"wifi: ath12k: Introduce hw abstraction"

This patchset extends the implementation to allow combination
of multiple underlying radios into a single composite hw/wiphy
for registration. Since now multiple radios are represented by
a single wiphy, changes are required in various mac ops that the
driver supports since the driver now needs to learn on how to tunnel
various mac ops properly to a specific radio.

This patchset covers the basic mac80211 ops for an interface bringup
and operation.

Note:
In addition to sanity on single radio QCN9274 and WCN7850
the single wiphy changes are tested over "wifi: ath12k: QCN9274 dualmac bring up"
where multiple radios in the dualmac SoC are combined and tested.

Monitor and hw reconfig support for Single Wiphy will be done in future
patchsets.

This patchset is dependent on "[PATCH 0/2] wifi: ath12k: Introduce hw abstraction"

Karthikeyan Periyasamy (1):
  wifi: ath12k: add multiple radio support in a single MAC HW
    un/register

Sriram R (11):
  wifi: ath12k: Modify add and remove chanctx ops for single wiphy
    support
  wifi: ath12k: modify ath12k mac start/stop ops for single wiphy
  wifi: ath12k: vdev statemachine changes for single wiphy
  wifi: ath12k: scan statemachine changes for single wiphy
  wifi: ath12k: fetch correct radio based on vdev status
  wifi: ath12k: Cache vdev configs before vdev create
  wifi: ath12k: Add additional checks for vif and sta iterators
  wifi: ath12k: modify regulatory support for single wiphy architecture
  wifi: ath12k: Modify set and get antenna mac ops for single wiphy
  wifi: ath12k: Modify rts threshold mac op for single wiphy
  wifi: ath12k: support get_survey mac op for single wiphy

 drivers/net/wireless/ath/ath12k/core.h |   40 +-
 drivers/net/wireless/ath/ath12k/hw.h   |    3 +-
 drivers/net/wireless/ath/ath12k/mac.c  | 1014 +++++++++++++++++++-----
 drivers/net/wireless/ath/ath12k/reg.c  |   62 +-
 4 files changed, 886 insertions(+), 233 deletions(-)

Comments

Jeff Johnson Jan. 11, 2024, 8:16 p.m. UTC | #1
On 1/10/2024 8:50 PM, Sriram R wrote:
> This patchset is dependent on "[PATCH 0/2] wifi: ath12k: Introduce hw abstraction"

I'm currently unable to apply the prerequisite patches to my workspace,
so I won't be able to review your patches until that is resolved.

/jeff
Sriram R Jan. 12, 2024, 4:34 a.m. UTC | #2
>-----Original Message-----
>From: Jeff Johnson (QUIC) <quic_jjohnson@quicinc.com>
>Sent: Friday, January 12, 2024 1:46 AM
>To: Sriram R (QUIC) <quic_srirrama@quicinc.com>; ath12k@lists.infradead.org
>Cc: linux-wireless@vger.kernel.org
>Subject: Re: [PATCH 00/12] wifi: ath12k: Add single wiphy support
>
>On 1/10/2024 8:50 PM, Sriram R wrote:
>> This patchset is dependent on "[PATCH 0/2] wifi: ath12k: Introduce hw
>abstraction"
>
>I'm currently unable to apply the prerequisite patches to my workspace, so I won't
>be able to review your patches until that is resolved.
Sure. I believe its resolved with "[PATCH v2 0/2] wifi: ath12k: Introduce hw abstraction".

Thanks,
Sriram.R
Jeff Johnson Jan. 12, 2024, 4:44 p.m. UTC | #3
On 1/11/2024 8:34 PM, Sriram R (QUIC) wrote:
>> -----Original Message-----
>> From: Jeff Johnson (QUIC) <quic_jjohnson@quicinc.com>
>> Sent: Friday, January 12, 2024 1:46 AM
>> To: Sriram R (QUIC) <quic_srirrama@quicinc.com>; ath12k@lists.infradead.org
>> Cc: linux-wireless@vger.kernel.org
>> Subject: Re: [PATCH 00/12] wifi: ath12k: Add single wiphy support
>>
>> On 1/10/2024 8:50 PM, Sriram R wrote:
>>> This patchset is dependent on "[PATCH 0/2] wifi: ath12k: Introduce hw
>> abstraction"
>>
>> I'm currently unable to apply the prerequisite patches to my workspace, so I won't
>> be able to review your patches until that is resolved.
> Sure. I believe its resolved with "[PATCH v2 0/2] wifi: ath12k: Introduce hw abstraction".

Yes, I have now processed the prerequisite patchset, and your patchset
applies cleanly on top of that.

As already mentioned you need to add your S-O-B to all patches that you
are posting on behalf of others. But let me review the individual
patches to make sure I don't have any other comments before you re-spin.

/jeff
Jeff Johnson Jan. 12, 2024, 6:30 p.m. UTC | #4
On 1/12/2024 8:44 AM, Jeff Johnson wrote:
> On 1/11/2024 8:34 PM, Sriram R (QUIC) wrote:
>>> -----Original Message-----
>>> From: Jeff Johnson (QUIC) <quic_jjohnson@quicinc.com>
>>> Sent: Friday, January 12, 2024 1:46 AM
>>> To: Sriram R (QUIC) <quic_srirrama@quicinc.com>; ath12k@lists.infradead.org
>>> Cc: linux-wireless@vger.kernel.org
>>> Subject: Re: [PATCH 00/12] wifi: ath12k: Add single wiphy support
>>>
>>> On 1/10/2024 8:50 PM, Sriram R wrote:
>>>> This patchset is dependent on "[PATCH 0/2] wifi: ath12k: Introduce hw
>>> abstraction"
>>>
>>> I'm currently unable to apply the prerequisite patches to my workspace, so I won't
>>> be able to review your patches until that is resolved.
>> Sure. I believe its resolved with "[PATCH v2 0/2] wifi: ath12k: Introduce hw abstraction".
> 
> Yes, I have now processed the prerequisite patchset, and your patchset
> applies cleanly on top of that.
> 
> As already mentioned you need to add your S-O-B to all patches that you
> are posting on behalf of others. But let me review the individual
> patches to make sure I don't have any other comments before you re-spin.

OK, I've reviewed the series. You are now free to incorporate the
requested changes and to post a v2. Please include my Acked-by: Jeff
Johnson <quic_jjohnson@quicinc.com> on all of the patches where I have
already supplied it on the mailing list.

/jeff