[v3,00/10] wifi: ath12k: P2P support for WCN7850

Message ID	20240122113904.8938-1-quic_kangyang@quicinc.com (mailing list archive)
Headers	show Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA9EC3D3A4 for <linux-wireless@vger.kernel.org>; Mon, 22 Jan 2024 11:39:33 +0000 (UTC) From: Kang Yang <quic_kangyang@quicinc.com> To: <ath12k@lists.infradead.org> CC: <linux-wireless@vger.kernel.org>, <quic_kangyang@quicinc.com> Subject: [PATCH v3 00/10] wifi: ath12k: P2P support for WCN7850 Date: Mon, 22 Jan 2024 19:38:54 +0800 Message-ID: <20240122113904.8938-1-quic_kangyang@quicinc.com> Precedence: bulk MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain
Series	wifi: ath12k: P2P support for WCN7850 \| expand [v3,00/10] wifi: ath12k: P2P support for WCN7850 [v3,01/10] wifi: ath12k: change interface combination for P2P mode [v3,02/10] wifi: ath12k: add P2P IE in beacon template [v3,03/10] wifi: ath12k: implement handling of P2P NoA event [v3,04/10] wifi: ath12k: implement remain on channel for P2P mode [v3,05/10] wifi: ath12k: change WLAN_SCAN_PARAMS_MAX_IE_LEN from 256 to 512 [v3,06/10] wifi: ath12k: allow specific mgmt frame tx while vdev is not up [v3,07/10] wifi: ath12k: fix broken structure wmi_vdev_create_cmd [v3,08/10] wifi: ath12k: move peer delete after vdev stop of station for WCN7850 [v3,09/10] wifi: ath12k: designating channel frequency for ROC scan [v3,10/10] wifi: ath12k: advertise P2P dev support for WCN7850

Kang Yang Jan. 22, 2024, 11:38 a.m. UTC

Add P2P support for WCN7850.

Kang Yang (10):
  wifi: ath12k: change interface combination for P2P mode
  wifi: ath12k: add P2P IE in beacon template
  wifi: ath12k: implement handling of P2P NoA event
  wifi: ath12k: implement remain on channel for P2P mode
  wifi: ath12k: change WLAN_SCAN_PARAMS_MAX_IE_LEN from 256 to 512
  wifi: ath12k: allow specific mgmt frame tx while vdev is not up
  wifi: ath12k: fix broken structure wmi_vdev_create_cmd
  wifi: ath12k: move peer delete after vdev stop of station for WCN7850
  wifi: ath12k: designating channel frequency for ROC scan
  wifi: ath12k: advertise P2P dev support for WCN7850

v3: rebase on new ath-tag, use ath12k_ah_to_ar() get ar(Karthikeyan).
v2:
    1. add Tested-on tag of QCN9274.
    2. update copyright in patch #1, #2, #4 and #10.

 drivers/net/wireless/ath/ath12k/Makefile |   3 +-
 drivers/net/wireless/ath/ath12k/core.c   |   1 +
 drivers/net/wireless/ath/ath12k/hw.c     |   7 +-
 drivers/net/wireless/ath/ath12k/mac.c    | 366 +++++++++++++++++++----
 drivers/net/wireless/ath/ath12k/p2p.c    | 142 +++++++++
 drivers/net/wireless/ath/ath12k/p2p.h    |  23 ++
 drivers/net/wireless/ath/ath12k/wmi.c    | 116 ++++++-
 drivers/net/wireless/ath/ath12k/wmi.h    |  50 +++-
 8 files changed, 643 insertions(+), 65 deletions(-)
 create mode 100644 drivers/net/wireless/ath/ath12k/p2p.c
 create mode 100644 drivers/net/wireless/ath/ath12k/p2p.h


base-commit: 8ff464a183f92836d7fd99edceef50a89d8ea797

Jeff Johnson Jan. 22, 2024, 8:04 p.m. UTC | #1

On 1/22/2024 3:38 AM, Kang Yang wrote:
> Add P2P support for WCN7850.
> 
> Kang Yang (10):
>   wifi: ath12k: change interface combination for P2P mode
>   wifi: ath12k: add P2P IE in beacon template
>   wifi: ath12k: implement handling of P2P NoA event
>   wifi: ath12k: implement remain on channel for P2P mode
>   wifi: ath12k: change WLAN_SCAN_PARAMS_MAX_IE_LEN from 256 to 512
>   wifi: ath12k: allow specific mgmt frame tx while vdev is not up
>   wifi: ath12k: fix broken structure wmi_vdev_create_cmd
>   wifi: ath12k: move peer delete after vdev stop of station for WCN7850
>   wifi: ath12k: designating channel frequency for ROC scan
>   wifi: ath12k: advertise P2P dev support for WCN7850
> 
> v3: rebase on new ath-tag, use ath12k_ah_to_ar() get ar(Karthikeyan).
> v2:
>     1. add Tested-on tag of QCN9274.
>     2. update copyright in patch #1, #2, #4 and #10.
> 
>  drivers/net/wireless/ath/ath12k/Makefile |   3 +-
>  drivers/net/wireless/ath/ath12k/core.c   |   1 +
>  drivers/net/wireless/ath/ath12k/hw.c     |   7 +-
>  drivers/net/wireless/ath/ath12k/mac.c    | 366 +++++++++++++++++++----
>  drivers/net/wireless/ath/ath12k/p2p.c    | 142 +++++++++
>  drivers/net/wireless/ath/ath12k/p2p.h    |  23 ++
>  drivers/net/wireless/ath/ath12k/wmi.c    | 116 ++++++-
>  drivers/net/wireless/ath/ath12k/wmi.h    |  50 +++-
>  8 files changed, 643 insertions(+), 65 deletions(-)
>  create mode 100644 drivers/net/wireless/ath/ath12k/p2p.c
>  create mode 100644 drivers/net/wireless/ath/ath12k/p2p.h
> 
> 
> base-commit: 8ff464a183f92836d7fd99edceef50a89d8ea797
Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>

Kalle Valo Jan. 25, 2024, 2:44 p.m. UTC | #2

Kang Yang <quic_kangyang@quicinc.com> writes:

> Add P2P support for WCN7850.
>
> Kang Yang (10):
>   wifi: ath12k: change interface combination for P2P mode
>   wifi: ath12k: add P2P IE in beacon template
>   wifi: ath12k: implement handling of P2P NoA event
>   wifi: ath12k: implement remain on channel for P2P mode
>   wifi: ath12k: change WLAN_SCAN_PARAMS_MAX_IE_LEN from 256 to 512
>   wifi: ath12k: allow specific mgmt frame tx while vdev is not up
>   wifi: ath12k: fix broken structure wmi_vdev_create_cmd
>   wifi: ath12k: move peer delete after vdev stop of station for WCN7850
>   wifi: ath12k: designating channel frequency for ROC scan
>   wifi: ath12k: advertise P2P dev support for WCN7850
>
> v3: rebase on new ath-tag, use ath12k_ah_to_ar() get ar(Karthikeyan).
> v2:
>     1. add Tested-on tag of QCN9274.
>     2. update copyright in patch #1, #2, #4 and #10.

I have not been able to run any p2p tests yet but during rmmod with
WCN7850 I now see:

[  136.260660] ------------[ cut here ]------------
[  136.260909] UBSAN: shift-out-of-bounds in drivers/net/wireless/ath/ath12k/mac.c:6005:38
[  136.261008] shift exponent 255 is too large for 64-bit type 'long long int'
[  136.261096] CPU: 1 PID: 1993 Comm: rmmod Not tainted 6.8.0-rc1-wt-ath+ #1262
[  136.261180] Hardware name: Intel(R) Client Systems NUC8i7HVK/NUC8i7HVB, BIOS HNKBLi70.86A.0067.2021.0528.1339 05/28/2021
[  136.261261] Call Trace:
[  136.261343]  <TASK>
[  136.261427]  dump_stack_lvl+0x82/0xc0
[  136.261513]  dump_stack+0x10/0x20
[  136.261597]  __ubsan_handle_shift_out_of_bounds+0x13f/0x300
[  136.261711]  ath12k_mac_op_remove_interface.cold+0x17/0x86 [ath12k]
[  136.261941]  drv_remove_interface+0x215/0x4a0 [mac80211]
[  136.262102]  ieee80211_do_stop+0xfe4/0x2390 [mac80211]
[  136.262258]  ? trace_contention_end+0xe2/0x110
[  136.262359]  ? ieee80211_del_virtual_monitor+0x60/0x60 [mac80211]
[  136.262507]  ? mutex_lock_io_nested+0x1260/0x1260
[  136.262610]  ? debug_smp_processor_id+0x17/0x20
[  136.262702]  ? trace_contention_end+0xe2/0x110
[  136.262792]  ieee80211_sdata_stop+0x4d/0x70 [mac80211]
[  136.262961]  ieee80211_stop_p2p_device+0xd/0x10 [mac80211]
[  136.263127]  cfg80211_stop_p2p_device+0x18e/0x580 [cfg80211]
[  136.263282]  cfg80211_shutdown_all_interfaces+0x10c/0x190 [cfg80211]
[  136.263434]  ieee80211_remove_interfaces+0xc7/0x8f0 [mac80211]
[  136.263611]  ? __wait_for_common+0x42f/0x6d0
[  136.263702]  ? ieee80211_sdata_stop+0x70/0x70 [mac80211]
[  136.263881]  ieee80211_unregister_hw+0x4f/0x380 [mac80211]
[  136.264045]  ath12k_mac_hw_unregister+0x7a/0x250 [ath12k]
[  136.264155]  ath12k_mac_unregister+0x7f/0xc0 [ath12k]
[  136.264265]  ath12k_core_deinit+0x2e/0x130 [ath12k]
[  136.264372]  ath12k_pci_remove+0xad/0x1a0 [ath12k]
[  136.264478]  pci_device_remove+0x93/0x1b0
[  136.264567]  device_remove+0xbf/0x150
[  136.264662]  device_release_driver_internal+0x3c3/0x580
[  136.264746]  ? __kasan_check_read+0x11/0x20
[  136.264836]  driver_detach+0xc4/0x190
[  136.264924]  bus_remove_driver+0x130/0x2a0
[  136.265012]  driver_unregister+0x68/0x90
[  136.265095]  pci_unregister_driver+0x24/0x240
[  136.265177]  ? find_module_all+0x13e/0x1c0
[  136.265267]  ath12k_pci_exit+0x10/0x20 [ath12k]
[  136.265372]  __do_sys_delete_module+0x32d/0x540
[  136.265454]  ? module_flags+0x300/0x300
[  136.265708]  ? kmem_cache_free+0xea/0x3a0
[  136.265795]  ? __fput+0x404/0xa50
[  136.265887]  ? debug_smp_processor_id+0x17/0x20
[  136.265983]  __x64_sys_delete_module+0x4f/0x70
[  136.266064]  do_syscall_64+0x66/0x130
[  136.266149]  entry_SYSCALL_64_after_hwframe+0x46/0x4e
[  136.266256] RIP: 0033:0x7efe74591c8b
[  136.266347] Code: 73 01 c3 48 8b 0d 05 c2 0c 00 f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 90 f3 0f 1e fa b8 b0 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d d5 c1 0c 00 f7 d8 64 89 01 48
[  136.266435] RSP: 002b:00007ffea9c34cb8 EFLAGS: 00000206 ORIG_RAX: 00000000000000b0
[  136.266550] RAX: ffffffffffffffda RBX: 000055db95b4c7e0 RCX: 00007efe74591c8b
[  136.266679] RDX: 000000000000000a RSI: 0000000000000800 RDI: 000055db95b4c848
[  136.266808] RBP: 00007ffea9c34d18 R08: 0000000000000000 R09: 0000000000000000
[  136.266934] R10: 00007efe7460dac0 R11: 0000000000000206 R12: 00007ffea9c34ef0
[  136.267062] R13: 00007ffea9c36ebf R14: 000055db95b4b2a0 R15: 000055db95b4c7e0
[  136.267221]  </TASK>
[  136.267390] ---[ end trace ]---

Kang Yang Jan. 26, 2024, 9:34 a.m. UTC | #3

On 1/25/2024 10:44 PM, Kalle Valo wrote:
> Kang Yang <quic_kangyang@quicinc.com> writes:
> 
>> Add P2P support for WCN7850.
>>
>> Kang Yang (10):
>>    wifi: ath12k: change interface combination for P2P mode
>>    wifi: ath12k: add P2P IE in beacon template
>>    wifi: ath12k: implement handling of P2P NoA event
>>    wifi: ath12k: implement remain on channel for P2P mode
>>    wifi: ath12k: change WLAN_SCAN_PARAMS_MAX_IE_LEN from 256 to 512
>>    wifi: ath12k: allow specific mgmt frame tx while vdev is not up
>>    wifi: ath12k: fix broken structure wmi_vdev_create_cmd
>>    wifi: ath12k: move peer delete after vdev stop of station for WCN7850
>>    wifi: ath12k: designating channel frequency for ROC scan
>>    wifi: ath12k: advertise P2P dev support for WCN7850
>>
>> v3: rebase on new ath-tag, use ath12k_ah_to_ar() get ar(Karthikeyan).
>> v2:
>>      1. add Tested-on tag of QCN9274.
>>      2. update copyright in patch #1, #2, #4 and #10.
> 
> I have not been able to run any p2p tests yet but during rmmod with
> WCN7850 I now see:
> 
> [  136.260660] ------------[ cut here ]------------
> [  136.260909] UBSAN: shift-out-of-bounds in drivers/net/wireless/ath/ath12k/mac.c:6005:38
> [  136.261008] shift exponent 255 is too large for 64-bit type 'long long int'


It seems you enable CONFIG_UBSAN, CONFIG_UBSAN_SANITIZE_ALL and other 
CONFIG_UBSAN_XXX.

I will add them to my config file and debug this warning.

It's been a long time since the last update of kernel config. Can you 
share the new one if convenient?


> [  136.261096] CPU: 1 PID: 1993 Comm: rmmod Not tainted 6.8.0-rc1-wt-ath+ #1262
> [  136.261180] Hardware name: Intel(R) Client Systems NUC8i7HVK/NUC8i7HVB, BIOS HNKBLi70.86A.0067.2021.0528.1339 05/28/2021
> [  136.261261] Call Trace:
> [  136.261343]  <TASK>
> [  136.261427]  dump_stack_lvl+0x82/0xc0
> [  136.261513]  dump_stack+0x10/0x20
> [  136.261597]  __ubsan_handle_shift_out_of_bounds+0x13f/0x300
> [  136.261711]  ath12k_mac_op_remove_interface.cold+0x17/0x86 [ath12k]
> [  136.261941]  drv_remove_interface+0x215/0x4a0 [mac80211]
> [  136.262102]  ieee80211_do_stop+0xfe4/0x2390 [mac80211]
> [  136.262258]  ? trace_contention_end+0xe2/0x110
> [  136.262359]  ? ieee80211_del_virtual_monitor+0x60/0x60 [mac80211]
> [  136.262507]  ? mutex_lock_io_nested+0x1260/0x1260
> [  136.262610]  ? debug_smp_processor_id+0x17/0x20
> [  136.262702]  ? trace_contention_end+0xe2/0x110
> [  136.262792]  ieee80211_sdata_stop+0x4d/0x70 [mac80211]
> [  136.262961]  ieee80211_stop_p2p_device+0xd/0x10 [mac80211]
> [  136.263127]  cfg80211_stop_p2p_device+0x18e/0x580 [cfg80211]
> [  136.263282]  cfg80211_shutdown_all_interfaces+0x10c/0x190 [cfg80211]
> [  136.263434]  ieee80211_remove_interfaces+0xc7/0x8f0 [mac80211]
> [  136.263611]  ? __wait_for_common+0x42f/0x6d0
> [  136.263702]  ? ieee80211_sdata_stop+0x70/0x70 [mac80211]
> [  136.263881]  ieee80211_unregister_hw+0x4f/0x380 [mac80211]
> [  136.264045]  ath12k_mac_hw_unregister+0x7a/0x250 [ath12k]
> [  136.264155]  ath12k_mac_unregister+0x7f/0xc0 [ath12k]
> [  136.264265]  ath12k_core_deinit+0x2e/0x130 [ath12k]
> [  136.264372]  ath12k_pci_remove+0xad/0x1a0 [ath12k]
> [  136.264478]  pci_device_remove+0x93/0x1b0
> [  136.264567]  device_remove+0xbf/0x150
> [  136.264662]  device_release_driver_internal+0x3c3/0x580
> [  136.264746]  ? __kasan_check_read+0x11/0x20
> [  136.264836]  driver_detach+0xc4/0x190
> [  136.264924]  bus_remove_driver+0x130/0x2a0
> [  136.265012]  driver_unregister+0x68/0x90
> [  136.265095]  pci_unregister_driver+0x24/0x240
> [  136.265177]  ? find_module_all+0x13e/0x1c0
> [  136.265267]  ath12k_pci_exit+0x10/0x20 [ath12k]
> [  136.265372]  __do_sys_delete_module+0x32d/0x540
> [  136.265454]  ? module_flags+0x300/0x300
> [  136.265708]  ? kmem_cache_free+0xea/0x3a0
> [  136.265795]  ? __fput+0x404/0xa50
> [  136.265887]  ? debug_smp_processor_id+0x17/0x20
> [  136.265983]  __x64_sys_delete_module+0x4f/0x70
> [  136.266064]  do_syscall_64+0x66/0x130
> [  136.266149]  entry_SYSCALL_64_after_hwframe+0x46/0x4e
> [  136.266256] RIP: 0033:0x7efe74591c8b
> [  136.266347] Code: 73 01 c3 48 8b 0d 05 c2 0c 00 f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 90 f3 0f 1e fa b8 b0 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d d5 c1 0c 00 f7 d8 64 89 01 48
> [  136.266435] RSP: 002b:00007ffea9c34cb8 EFLAGS: 00000206 ORIG_RAX: 00000000000000b0
> [  136.266550] RAX: ffffffffffffffda RBX: 000055db95b4c7e0 RCX: 00007efe74591c8b
> [  136.266679] RDX: 000000000000000a RSI: 0000000000000800 RDI: 000055db95b4c848
> [  136.266808] RBP: 00007ffea9c34d18 R08: 0000000000000000 R09: 0000000000000000
> [  136.266934] R10: 00007efe7460dac0 R11: 0000000000000206 R12: 00007ffea9c34ef0
> [  136.267062] R13: 00007ffea9c36ebf R14: 000055db95b4b2a0 R15: 000055db95b4c7e0
> [  136.267221]  </TASK>
> [  136.267390] ---[ end trace ]---
>

Kalle Valo Jan. 29, 2024, 1:02 p.m. UTC | #4

Kang Yang <quic_kangyang@quicinc.com> writes:

> On 1/25/2024 10:44 PM, Kalle Valo wrote:
>> Kang Yang <quic_kangyang@quicinc.com> writes:
>> 
>>> Add P2P support for WCN7850.
>>>
>>> Kang Yang (10):
>>>    wifi: ath12k: change interface combination for P2P mode
>>>    wifi: ath12k: add P2P IE in beacon template
>>>    wifi: ath12k: implement handling of P2P NoA event
>>>    wifi: ath12k: implement remain on channel for P2P mode
>>>    wifi: ath12k: change WLAN_SCAN_PARAMS_MAX_IE_LEN from 256 to 512
>>>    wifi: ath12k: allow specific mgmt frame tx while vdev is not up
>>>    wifi: ath12k: fix broken structure wmi_vdev_create_cmd
>>>    wifi: ath12k: move peer delete after vdev stop of station for WCN7850
>>>    wifi: ath12k: designating channel frequency for ROC scan
>>>    wifi: ath12k: advertise P2P dev support for WCN7850
>>>
>>> v3: rebase on new ath-tag, use ath12k_ah_to_ar() get ar(Karthikeyan).
>>> v2:
>>>      1. add Tested-on tag of QCN9274.
>>>      2. update copyright in patch #1, #2, #4 and #10.
>> I have not been able to run any p2p tests yet but during rmmod with
>> WCN7850 I now see:
>> [  136.260660] ------------[ cut here ]------------
>> [ 136.260909] UBSAN: shift-out-of-bounds in
>> drivers/net/wireless/ath/ath12k/mac.c:6005:38
>> [  136.261008] shift exponent 255 is too large for 64-bit type 'long long int'
>
>
> It seems you enable CONFIG_UBSAN, CONFIG_UBSAN_SANITIZE_ALL and other
> CONFIG_UBSAN_XXX.

Yes, I try to enable debug facilities as much as possible. They are
really good at finding issues in the code.

> I will add them to my config file and debug this warning.

Thanks.

> It's been a long time since the last update of kernel config. Can you
> share the new one if convenient?

Yeah, it is. I updated it now.

Kang Yang Jan. 30, 2024, 7:02 a.m. UTC | #5

On 1/29/24 9:02 PM, Kalle Valo <kvalo@kernel.org> wrote:
> Kang Yang <quic_kangyang@quicinc.com> writes:
> 
> > On 1/25/2024 10:44 PM, Kalle Valo wrote:
> >> Kang Yang <quic_kangyang@quicinc.com> writes:
> >>
> >>> Add P2P support for WCN7850.
> >>>
> >>> Kang Yang (10):
> >>>     wifi: ath12k: change interface combination for P2P mode
> >>>     wifi: ath12k: add P2P IE in beacon template
> >>>     wifi: ath12k: implement handling of P2P NoA event
> >>>     wifi: ath12k: implement remain on channel for P2P mode
> >>>     wifi: ath12k: change WLAN_SCAN_PARAMS_MAX_IE_LEN from 256 to 512
> >>>     wifi: ath12k: allow specific mgmt frame tx while vdev is not up
> >>>     wifi: ath12k: fix broken structure wmi_vdev_create_cmd
> >>>     wifi: ath12k: move peer delete after vdev stop of station for WCN7850
> >>>     wifi: ath12k: designating channel frequency for ROC scan
> >>>     wifi: ath12k: advertise P2P dev support for WCN7850
> >>>
> >>> v3: rebase on new ath-tag, use ath12k_ah_to_ar() get ar(Karthikeyan).
> >>> v2:
> >>>       1. add Tested-on tag of QCN9274.
> >>>       2. update copyright in patch #1, #2, #4 and #10.
> >> I have not been able to run any p2p tests yet but during rmmod with
> >> WCN7850 I now see:
> >> [  136.260660] ------------[ cut here ]------------
> >> [ 136.260909] UBSAN: shift-out-of-bounds in
> >> drivers/net/wireless/ath/ath12k/mac.c:6005:38
> >> [  136.261008] shift exponent 255 is too large for 64-bit type 'long long int'
> >
> >
> > It seems you enable CONFIG_UBSAN, CONFIG_UBSAN_SANITIZE_ALL and other
> > CONFIG_UBSAN_XXX.
> 
> Yes, I try to enable debug facilities as much as possible. They are
> really good at finding issues in the code.
> 
> > I will add them to my config file and debug this warning.
> 
> Thanks.
> 

Now, i fix this warning with new patch '[PATCH v6 02/11] wifi: ath12k: fix incorrect logic of calculating vdev_stats_id'.

Please ignore this version.


> > It's been a long time since the last update of kernel config. Can you
> > share the new one if convenient?
> 
> Yeah, it is. I updated it now.
> 
>

[v3,00/10] wifi: ath12k: P2P support for WCN7850

Message

Comments