| Message ID | 20241106044548.3530128-1-quic_rdevanat@quicinc.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | wifi: ath12k: Support Pager, Counter, SoC, Transmit Rate Stats | expand |
On 11/5/2024 8:45 PM, Roopni Devanathan wrote: > Add support to request HTT stats type 36, 37, 38 and 40 from firmware. > These stat types give downlink pager stats, counter and TPC stats, SoC > common stats and Transmit PER rate stats, respectively. > > v4: > - Addressed Jeff's comments pertaining to data type conversions. > v3: > - Added macros to fix compilation issues. > v2: > - Removed dependencies. No change in code. > > Dinesh Karthikeyan (4): > wifi: ath12k: Support Downlink Pager Stats > wifi: ath12k: Support phy counter and TPC stats > wifi: ath12k: Support SoC Common Stats > wifi: ath12k: Support Transmit PER Rate Stats > > .../wireless/ath/ath12k/debugfs_htt_stats.c | 630 +++++++++++++++++- > .../wireless/ath/ath12k/debugfs_htt_stats.h | 204 +++++- > 2 files changed, 831 insertions(+), 3 deletions(-) > > > base-commit: d63fbff74ab1af1573c1dca20cfe1e876f8ffa62 I acked 2-4/4. I can fix 1/4 in pending so no need to spin v5
On 11/5/2024 8:45 PM, Roopni Devanathan wrote: > Add support to request HTT stats type 36, 37, 38 and 40 from firmware. > These stat types give downlink pager stats, counter and TPC stats, SoC > common stats and Transmit PER rate stats, respectively. > > v4: > - Addressed Jeff's comments pertaining to data type conversions. > v3: > - Added macros to fix compilation issues. > v2: > - Removed dependencies. No change in code. > > Dinesh Karthikeyan (4): > wifi: ath12k: Support Downlink Pager Stats > wifi: ath12k: Support phy counter and TPC stats > wifi: ath12k: Support SoC Common Stats > wifi: ath12k: Support Transmit PER Rate Stats > > .../wireless/ath/ath12k/debugfs_htt_stats.c | 630 +++++++++++++++++- > .../wireless/ath/ath12k/debugfs_htt_stats.h | 204 +++++- > 2 files changed, 831 insertions(+), 3 deletions(-) > > > base-commit: d63fbff74ab1af1573c1dca20cfe1e876f8ffa62 when I build this series with W=1 drivers/net/wireless/ath/ath12k/debugfs_htt_stats.c: In function 'ath12k_htt_print_dlpager_entry': drivers/net/wireless/ath/ath12k/debugfs_htt_stats.c:2582:13: warning: variable 'ts_hi' set but not used [-Wunused-but-set-variable] drivers/net/wireless/ath/ath12k/debugfs_htt_stats.c:2581:13: warning: variable 'ts_lo' set but not used [-Wunused-but-set-variable] I can remove these locally in 'pending' if there are no other issues. /jeff
On 11/6/2024 4:15 PM, Jeff Johnson wrote: > On 11/5/2024 8:45 PM, Roopni Devanathan wrote: >> Add support to request HTT stats type 36, 37, 38 and 40 from firmware. >> These stat types give downlink pager stats, counter and TPC stats, SoC >> common stats and Transmit PER rate stats, respectively. >> >> v4: >> - Addressed Jeff's comments pertaining to data type conversions. >> v3: >> - Added macros to fix compilation issues. >> v2: >> - Removed dependencies. No change in code. >> >> Dinesh Karthikeyan (4): >> wifi: ath12k: Support Downlink Pager Stats >> wifi: ath12k: Support phy counter and TPC stats >> wifi: ath12k: Support SoC Common Stats >> wifi: ath12k: Support Transmit PER Rate Stats >> >> .../wireless/ath/ath12k/debugfs_htt_stats.c | 630 +++++++++++++++++- >> .../wireless/ath/ath12k/debugfs_htt_stats.h | 204 +++++- >> 2 files changed, 831 insertions(+), 3 deletions(-) >> >> >> base-commit: d63fbff74ab1af1573c1dca20cfe1e876f8ffa62 > I acked 2-4/4. I can fix 1/4 in pending so no need to spin v5 > Please check the fixup of the 1/4 patch: https://git.kernel.org/pub/scm/linux/kernel/git/ath/ath.git/commit/?h=pending&id=e97a15b67f1417e36d799aaa1f15e3a362293475