mbox series

[v4,0/4] wifi: ath12k: Fix the static checker warning

Message ID 20250112071630.4059410-1-quic_periyasa@quicinc.com (mailing list archive)
Headers show
Series wifi: ath12k: Fix the static checker warning | expand

Message

Karthikeyan Periyasamy Jan. 12, 2025, 7:16 a.m. UTC
This patch series fix the below Smatch static checker warnings

Warnings:
mac.c:10941 ath12k_mac_destroy() error: we previously assumed 'ab' could be null (see line 11348)
mac.c:11007 ath12k_mac_allocate() error: uninitialized symbol 'ab'.
mac.c:11013 ath12k_mac_allocate() error: uninitialized symbol 'ab'.

v4:
 wifi: ath12k: Remove ath12k_get_num_hw() helper function
  - updated copyright
v3:
 wifi: ath12k: Remove ath12k_get_num_hw() helper function
  - Renamed the patch title
  - Removed ath12k_get_num_hw() helper function
v2:
 - Rebased on ToT

Karthikeyan Periyasamy (4):
  wifi: ath12k: Refactor ath12k_hw set helper function argument
  wifi: ath12k: Refactor the ath12k_hw get helper function argument
  wifi: ath12k: Remove ath12k_get_num_hw() helper function
  wifi: ath12k: Fix uninitialized variable access in
    ath12k_mac_allocate() function

 drivers/net/wireless/ath/ath12k/core.c | 22 +++++++-----
 drivers/net/wireless/ath/ath12k/core.h | 15 +++-----
 drivers/net/wireless/ath/ath12k/mac.c  | 49 +++++++++++++++++---------
 3 files changed, 50 insertions(+), 36 deletions(-)


base-commit: 0c5fcd9069dd5f984e39820629acbfbe0f1b4256

Comments

Jeff Johnson Jan. 14, 2025, 8:54 p.m. UTC | #1
On Sun, 12 Jan 2025 12:46:26 +0530, Karthikeyan Periyasamy wrote:
> This patch series fix the below Smatch static checker warnings
> 
> Warnings:
> mac.c:10941 ath12k_mac_destroy() error: we previously assumed 'ab' could be null (see line 11348)
> mac.c:11007 ath12k_mac_allocate() error: uninitialized symbol 'ab'.
> mac.c:11013 ath12k_mac_allocate() error: uninitialized symbol 'ab'.
> 
> [...]

Applied, thanks!

[1/4] wifi: ath12k: Refactor ath12k_hw set helper function argument
      commit: 21261e4d564e866bdae810b4fb5278a3a6a1a6ed
[2/4] wifi: ath12k: Refactor the ath12k_hw get helper function argument
      commit: 812a30271d48cff5edc39aeb436b3bebd558f5cf
[3/4] wifi: ath12k: Remove ath12k_get_num_hw() helper function
      commit: 54fcdcf07baa9cb34359094f1b829b29d0845cb6
[4/4] wifi: ath12k: Fix uninitialized variable access in ath12k_mac_allocate() function
      commit: 4aae869847ce50da902005ce4d84505d54e739c9

Best regards,