From patchwork Wed Feb 10 00:42:21 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shuah Khan X-Patchwork-Id: 12079583 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BC69C433E0 for ; Wed, 10 Feb 2021 00:45:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CABFA64E54 for ; Wed, 10 Feb 2021 00:45:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234463AbhBJApR (ORCPT ); Tue, 9 Feb 2021 19:45:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33726 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234629AbhBJAnR (ORCPT ); Tue, 9 Feb 2021 19:43:17 -0500 Received: from mail-ot1-x332.google.com (mail-ot1-x332.google.com [IPv6:2607:f8b0:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6CB1FC06174A for ; Tue, 9 Feb 2021 16:42:29 -0800 (PST) Received: by mail-ot1-x332.google.com with SMTP id y11so302614otq.1 for ; Tue, 09 Feb 2021 16:42:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=etuaipsRI8VUBgOpRvDQ8x9GuLj3LBOY0jfZPD+9PZU=; b=RyZp4bKd5jXCGBD5pFwR/hdVXBbL9IX4AzrmLeByylFz7gzsGYVcbuRrTX+6s0BQcj kQ3nHfB7Oxxdz0toIE7NU2BIn/ub7gbfxk4EjGeBbiVXq9SdLaOpfbNhj0vLqF4fO1VK cBq9b3eJsmf+tmJeEtT48SPYH17zjGsqAo3yY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=etuaipsRI8VUBgOpRvDQ8x9GuLj3LBOY0jfZPD+9PZU=; b=HHFT872xmLGvdBgQ/fSxp5GLKyLakgi0pdfkY4nqmzsfCU0KISAm3fDQsKElgfA21F aWO9JYGMDm7DdS1+bDLx7vFCfsUi2qZuDUpFjnaOGSguQ4M8bolKX+CwijXxlojF3e/6 p4iwu/ySiZ3ySYvM9uL5nyL326VMAoE4wgBFik7m8ANg/QrEU6R55paGAW+xxBVUQYdJ ffOW/gmoKncgXQ4Dm3G9cbQUKVswTA74AU/7sm0IVE4l8y8Ebd6Bo3VOE3DmCujS1HPH ZzQxHNio2DG0H3wFPIFT5kEIMKiH7Kx7R5lD8YGpqbfeHEsGPqCXtZ1cZZbGhek05q0h DtBA== X-Gm-Message-State: AOAM530fawn/Ub+BxBgBihLrslHP3PKKBT/zV8ZS7mhFaN8/zgCMrhNb qT4mbzZPq+EPm/QuT0YWDmcI0g== X-Google-Smtp-Source: ABdhPJz3qC3Vss2S7hgvN3dmYgFFQWBTBmhf4k+ZiQK8BXjQbj1R8owtdETJ8jUJrHBoGGLX27ZKsg== X-Received: by 2002:a9d:a87:: with SMTP id 7mr227340otq.319.1612917748911; Tue, 09 Feb 2021 16:42:28 -0800 (PST) Received: from shuah-t480s.internal (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id s123sm103060oos.3.2021.02.09.16.42.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Feb 2021 16:42:28 -0800 (PST) From: Shuah Khan To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: Shuah Khan , ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 0/5] ath10k fixes for warns Date: Tue, 9 Feb 2021 17:42:21 -0700 Message-Id: X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org I have been seeing lockdep asserts for a couple of months and finally found time to debug and fix the problems. The dmesg looks clean with these fixes. Enabling LOCKDEP and ATH10K_DEBUGFS triggers the lockdep assert and RCU warns. The first two patches in this series are fixes to lockdep assert and RCU usage bugs. The last patch (5/5) is a fix to reduce invalid ht params rate message noise. Patch 3/4 changes a message from debug to warn. Patch 4 adds detect to assert not calling ath10k_drain_tx() holding conf_mutex. Shuah Khan (5): ath10k: fix conf_mutex lock assert in ath10k_debug_fw_stats_request() ath10k: fix WARNING: suspicious RCU usage ath10k: change ath10k_offchan_tx_work() peer present msg to a warn ath10k: detect conf_mutex held ath10k_drain_tx() calls ath10k: reduce invalid ht params rate message noise drivers/net/wireless/ath/ath10k/mac.c | 13 ++++++++----- drivers/net/wireless/ath/ath10k/wmi-tlv.c | 15 +++++++++++---- 2 files changed, 19 insertions(+), 9 deletions(-)