| Message ID | 0c2fa5b7a8724d0ee405afd05f393af95e65116c.1397006688.git.gamerh2o@gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Wed, 2014-04-09 at 09:28 +0800, Zhao, Gang wrote: > The warning doesn't show up due to duplicate including, but it's worth > fixing it. > > net/mac80211//michael.h:22:4: warning: ‘struct ieee80211_hdr’ declared inside parameter list [enabled by default] > const u8 *data, size_t data_len, u8 *mic); > ^ > net/mac80211//michael.h:22:4: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default] > > Signed-off-by: Zhao, Gang <gamerh2o@gmail.com> > --- > net/mac80211/michael.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/mac80211/michael.h b/net/mac80211/michael.h > index 3b848da..b259547 100644 > --- a/net/mac80211/michael.h > +++ b/net/mac80211/michael.h > @@ -10,7 +10,7 @@ > #ifndef MICHAEL_H > #define MICHAEL_H > > -#include <linux/types.h> > +#include <linux/ieee80211.h> This should probably include both now though. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/mac80211/michael.h b/net/mac80211/michael.h index 3b848da..b259547 100644 --- a/net/mac80211/michael.h +++ b/net/mac80211/michael.h @@ -10,7 +10,7 @@ #ifndef MICHAEL_H #define MICHAEL_H -#include <linux/types.h> +#include <linux/ieee80211.h> #define MICHAEL_MIC_LEN 8
The warning doesn't show up due to duplicate including, but it's worth fixing it. net/mac80211//michael.h:22:4: warning: ‘struct ieee80211_hdr’ declared inside parameter list [enabled by default] const u8 *data, size_t data_len, u8 *mic); ^ net/mac80211//michael.h:22:4: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default] Signed-off-by: Zhao, Gang <gamerh2o@gmail.com> --- net/mac80211/michael.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)