From patchwork Thu Aug 6 16:01:03 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Williams X-Patchwork-Id: 39651 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n76H16F8026339 for ; Thu, 6 Aug 2009 17:01:06 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756273AbZHFRA2 (ORCPT ); Thu, 6 Aug 2009 13:00:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756269AbZHFRA1 (ORCPT ); Thu, 6 Aug 2009 13:00:27 -0400 Received: from mx2.redhat.com ([66.187.237.31]:36641 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756260AbZHFRA0 (ORCPT ); Thu, 6 Aug 2009 13:00:26 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n76H0J0S027825; Thu, 6 Aug 2009 13:00:19 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n76H0Hj5027350; Thu, 6 Aug 2009 13:00:18 -0400 Received: from [10.16.10.58] (vpn-10-58.bos.redhat.com [10.16.10.58]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n76H0Fed023061; Thu, 6 Aug 2009 13:00:16 -0400 Subject: [PATCH] libertas: correct packing of rxpd structure From: Dan Williams To: John Linville Cc: wireless , Bob Dunlop Date: Thu, 06 Aug 2009 12:01:03 -0400 Message-Id: <1249574463.2916.25.camel@localhost.localdomain> Mime-Version: 1.0 X-Scanned-By: MIMEDefang 2.58 on 172.16.27.26 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Bob Dunlop Older Gcc compilers (3.4.5 tested) need additional hints in order to get the packing of the rxpd structure (which contains a 16 bit union) correct on the ARM processor. struct txpd does not need these hints since it contains a 32 bit union that packs naturally. Signed-off-by: R.J.Dunlop Acked-by: Dan Williams --- -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff -u linux-2.6.31-rc2/drivers/net/wireless/libertas/hostcmd.h{-orig,} --- linux-2.6.31-rc2/drivers/net/wireless/libertas/hostcmd.h-orig 2009-07-04 18:58:48.000000000 +0100 +++ linux-2.6.31-rc2/drivers/net/wireless/libertas/hostcmd.h 2009-07-13 08:27:45.000000000 +0100 @@ -56,8 +56,8 @@ u8 bss_type; /* BSS number */ u8 bss_num; - } bss; - } u; + } __attribute__ ((packed)) bss; + } __attribute__ ((packed)) u; /* SNR */ u8 snr;