| Message ID | 1302530175-24451-1-git-send-email-tomas.winkler@intel.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
Hi Tomas, On 04/11/2011 03:56 PM, Tomas Winkler wrote: > The module taints the kernel if the license is not specified > > Add also module description > > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com> I send a patch including kfifo.ko into compat.ko some days ago [0], but it was not yet apply. If kfifo is integrated in compat.ko this patch will cause problems. As kifo.ko is small I think it is better to get rid of this extra module and integrate it into compat.ko. [0]: https://patchwork.kernel.org/patch/692651/ Hauke -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> -----Original Message----- > From: Hauke Mehrtens [mailto:hauke@hauke-m.de] > Sent: Wednesday, April 13, 2011 11:18 PM > To: Winkler, Tomas > Cc: mcgrof@gmail.com; lrodriguez@atheros.com; linux-wireless@vger.kernel.org > Subject: Re: [compat 1/1] compat: add license and other module params to > kfifo > > Hi Tomas, > > On 04/11/2011 03:56 PM, Tomas Winkler wrote: > > The module taints the kernel if the license is not specified > > > > Add also module description > > > > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com> > I send a patch including kfifo.ko into compat.ko some days ago [0], but > it was not yet apply. If kfifo is integrated in compat.ko this patch > will cause problems. As kifo.ko is small I think it is better to get rid > of this extra module and integrate it into compat.ko. > > [0]: https://patchwork.kernel.org/patch/692651/ Sounds reasonable. Thanks Tomas --------------------------------------------------------------------- Intel Israel (74) Limited This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/compat/kfifo.c b/compat/kfifo.c index 01a0700..7890662 100644 --- a/compat/kfifo.c +++ b/compat/kfifo.c @@ -27,6 +27,8 @@ #include <linux/uaccess.h> #include <linux/kfifo.h> +MODULE_DESCRIPTION("kfifo backport"); +MODULE_LICENSE("GPL"); /* * internal helper to calculate the unused elements in a fifo */
The module taints the kernel if the license is not specified Add also module description Signed-off-by: Tomas Winkler <tomas.winkler@intel.com> --- compat/kfifo.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)