| Message ID | 1305321990-22041-2-git-send-email-balbi@ti.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Sat, 2011-05-14 at 00:26 +0300, Felipe Balbi wrote: > That's only needed during init anyway, let's free > some space after we're done probing. > > Signed-off-by: Felipe Balbi <balbi@ti.com> > --- Applied, this one. Thanks, Felipe!
On Sat, May 14, 2011 at 12:26 AM, Felipe Balbi <balbi@ti.com> wrote: > That's only needed during init anyway, let's free > some space after we're done probing. sdio devices are dynamically created whenever the hw is plugged into the mmc slot by the user. that can happen anytime while the system is up, not only during init. > -static const struct sdio_device_id wl1271_devices[] = { > +static const struct sdio_device_id wl1271_devices[] __devinitconst = { it looks to me that sdio_match_device is going to be surprised if ->id_table won't be valid. i wouldn't do this, unless you have a good explanation otherwise. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
2011/5/20 Ohad Ben-Cohen <ohad@wizery.com>: > On Sat, May 14, 2011 at 12:26 AM, Felipe Balbi <balbi@ti.com> wrote: >> That's only needed during init anyway, let's free >> some space after we're done probing. > sdio devices are dynamically created whenever the hw is plugged into > the mmc slot by the user. that can happen anytime while the system is > up, not only during init. >> -static const struct sdio_device_id wl1271_devices[] = { >> +static const struct sdio_device_id wl1271_devices[] __devinitconst = { > it looks to me that sdio_match_device is going to be surprised if > ->id_table won't be valid. > > i wouldn't do this, unless you have a good explanation otherwise. devinit sections are not freed if device hotplug is enabled. Best Regards, Micha? Miros?aw -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/wireless/wl12xx/sdio.c b/drivers/net/wireless/wl12xx/sdio.c index b1c7d03..1268efe 100644 --- a/drivers/net/wireless/wl12xx/sdio.c +++ b/drivers/net/wireless/wl12xx/sdio.c @@ -45,7 +45,7 @@ #define SDIO_DEVICE_ID_TI_WL1271 0x4076 #endif -static const struct sdio_device_id wl1271_devices[] = { +static const struct sdio_device_id wl1271_devices[] __devinitconst = { { SDIO_DEVICE(SDIO_VENDOR_ID_TI, SDIO_DEVICE_ID_TI_WL1271) }, {} };
That's only needed during init anyway, let's free some space after we're done probing. Signed-off-by: Felipe Balbi <balbi@ti.com> --- drivers/net/wireless/wl12xx/sdio.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)